Pr suggestions

Author: nmayorsplit

client/src/main/java/io/split/engine/matchers/BetweenSemverMatcher.java

@@ -16,7 +16,7 @@ public BetweenSemverMatcher(String semverStart, String semverEnd) {
 
     @Override
     public boolean match(Object matchValue, String bucketingKey, Map<String, Object> attributes, EvaluationContext evaluationContext) {
-        if (matchValue == null || _semverStart == null || _semverEnd == null) {
+        if (matchValue == null || _semverStart == null || _semverEnd == null || !(matchValue instanceof String)) {
             return false;
         }
         Semver matchSemver = Semver.build(matchValue.toString());

client/src/main/java/io/split/engine/matchers/GreaterThanOrEqualToSemverMatcher.java

@@ -14,7 +14,7 @@ public GreaterThanOrEqualToSemverMatcher(String semVer) {
 
     @Override
     public boolean match(Object matchValue, String bucketingKey, Map<String, Object> attributes, EvaluationContext evaluationContext) {
-        if (matchValue == null || _semVer == null) {
+        if (matchValue == null || _semVer == null || !(matchValue instanceof String)) {
             return false;
         }
         Semver matchSemver = Semver.build(matchValue.toString());

client/src/main/java/io/split/engine/matchers/InListSemverMatcher.java

@@ -22,7 +22,7 @@ public InListSemverMatcher(Collection<String> whitelist) {
 
     @Override
     public boolean match(Object matchValue, String bucketingKey, Map<String, Object> attributes, EvaluationContext evaluationContext) {
-        if (matchValue == null || _semverlist.isEmpty()) {
+        if (matchValue == null || !(matchValue instanceof String) || _semverlist.isEmpty()) {
             return false;
         }
         Semver matchSemver = Semver.build(matchValue.toString());
@@ -32,7 +32,6 @@ public boolean match(Object matchValue, String bucketingKey, Map<String, Object>
 
         for (Semver semverItem : _semverlist) {
             if (semverItem.Version().equals(matchSemver.Version())) return true;
-
         }
         return false;
     }

client/src/main/java/io/split/engine/matchers/LessThanOrEqualToSemverMatcher.java

@@ -14,7 +14,7 @@ public LessThanOrEqualToSemverMatcher(String semVer) {
 
     @Override
     public boolean match(Object matchValue, String bucketingKey, Map<String, Object> attributes, EvaluationContext evaluationContext) {
-        if (matchValue == null || _semVer == null) {
+        if (matchValue == null || !(matchValue instanceof String) || _semVer == null) {
             return false;
         }
         Semver matchSemver = Semver.build(matchValue.toString());

client/src/main/java/io/split/engine/matchers/Semver.java

@@ -4,7 +4,6 @@
 import io.split.engine.experiments.SplitParser;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import com.google.common.primitives.Ints;
 
 import java.util.Arrays;
 
@@ -96,8 +95,8 @@ public int Compare(Semver toCompare) {
             if (_preRelease[i].equals(toCompare.PreRelease()[i])) {
                 continue;
             }
-            if ( Ints.tryParse(_preRelease[i]) != null &&  Ints.tryParse(toCompare._preRelease[i]) != null) {
-                return Integer.compare(Integer.parseInt(_preRelease[i]), Integer.parseInt(toCompare._preRelease[i]));
+            if ( isNumeric(_preRelease[i]) &&  isNumeric(toCompare._preRelease[i])) {
+                return Long.compare(Integer.parseInt(_preRelease[i]), Long.parseLong(toCompare._preRelease[i]));
             }
             return AdjustNumber(_preRelease[i].compareTo(toCompare._preRelease[i]));
         }