polish

Bilal Al · Bilal Al · commit 450242920268 · 2024-04-19T13:49:15.000-07:00
diff --git a/client/src/main/java/io/split/engine/experiments/SplitParser.java b/client/src/main/java/io/split/engine/experiments/SplitParser.java
@@ -75,15 +75,18 @@ private ParsedSplit parseWithoutExceptionHandling(Split split) {
     }
 
     private boolean checkUnsupportedMatcherExist(List<io.split.client.dtos.Matcher> matchers) {
+        MatcherType typeCheck = null;
         for (io.split.client.dtos.Matcher matcher : matchers) {
+            typeCheck = null;
             try {
-                MatcherType typeCheck = matcher.matcherType;
+                typeCheck = matcher.matcherType;
             } catch (NullPointerException e) {
                 // If the exception is caught, it means unsupported matcher
-                return true;
+                break;
             }
         }
-        return false;
+        if (typeCheck != null)  return false;
+        return true;
     }
 
     private ParsedCondition getTemplateCondition() {

Original file line number	Diff line number	Diff line change
`@@ -75,15 +75,18 @@ private ParsedSplit parseWithoutExceptionHandling(Split split) {`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`private boolean checkUnsupportedMatcherExist(List<io.split.client.dtos.Matcher> matchers) {`
	`78`	`+ MatcherType typeCheck = null;`
`78`	`79`	`for (io.split.client.dtos.Matcher matcher : matchers) {`
	`80`	`+ typeCheck = null;`
`79`	`81`	`try {`
`80`		`- MatcherType typeCheck = matcher.matcherType;`
	`82`	`+ typeCheck = matcher.matcherType;`
`81`	`83`	`} catch (NullPointerException e) {`
`82`	`84`	`// If the exception is caught, it means unsupported matcher`
`83`		`- return true;`
	`85`	`+ break;`
`84`	`86`	`}`
`85`	`87`	`}`
`86`		`- return false;`
	`88`	`+ if (typeCheck != null) return false;`
	`89`	`+ return true;`
`87`	`90`	`}`
`88`	`91`
`89`	`92`	`private ParsedCondition getTemplateCondition() {`