Skip to content

Commit 47cff5b

Browse files
committed
Improve test cases
1 parent 7c28a58 commit 47cff5b

File tree

1 file changed

+14
-7
lines changed

1 file changed

+14
-7
lines changed

client/src/test/java/io/split/client/SplitClientConfigTest.java

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,10 @@ public void testImpressionRefreshRateConstraints() {
7878

7979
@Test
8080
public void setImpressionRefreshRateWorks() {
81-
SplitClientConfig.builder()
82-
.impressionsRefreshRate(1)
81+
SplitClientConfig config = SplitClientConfig.builder()
82+
.impressionsRefreshRate(65)
8383
.build();
84+
Assert.assertEquals(65, config.impressionsRefreshRate());
8485
}
8586

8687
@Test(expected = IllegalArgumentException.class)
@@ -92,26 +93,31 @@ public void cannotSetEventsFlushRateToEqualTo1000() {
9293

9394
@Test
9495
public void eventsFlushRateWorks() {
95-
SplitClientConfig.builder()
96+
SplitClientConfig config = SplitClientConfig.builder()
9697
.eventFlushIntervalInMillis(1000)
9798
.build();
99+
Assert.assertEquals(1000, config.eventSendIntervalInMillis());
98100
}
99101

100102
@Test(expected = IllegalArgumentException.class)
101-
public void cannotSetMetricsRefreshRateToLessTha30() {
103+
public void cannotSetMetricsRefreshRateToLessThan30() {
102104
SplitClientConfig.builder()
103105
.metricsRefreshRate(29)
104106
.build();
105107
}
106108

107109
@Test
108110
public void canSetRefreshRatesTo30() {
109-
SplitClientConfig.builder()
111+
SplitClientConfig cfg = SplitClientConfig.builder()
110112
.featuresRefreshRate(30)
111113
.segmentsRefreshRate(30)
112-
.impressionsRefreshRate(30)
113-
.metricsRefreshRate(30)
114+
.impressionsRefreshRate(65)
115+
.metricsRefreshRate(65)
114116
.build();
117+
Assert.assertEquals(30, cfg.featuresRefreshRate());
118+
Assert.assertEquals(30, cfg.segmentsRefreshRate());
119+
Assert.assertEquals(65, cfg.impressionsRefreshRate());
120+
Assert.assertEquals(65, cfg.metricsRefreshRate());
115121
}
116122

117123
@Test
@@ -175,6 +181,7 @@ public void streamingReconnectBackoffBaseAllowed() {
175181
SplitClientConfig cfg = SplitClientConfig.builder()
176182
.streamingReconnectBackoffBase(1)
177183
.build();
184+
Assert.assertEquals(1, cfg.streamingReconnectBackoffBase());
178185
}
179186

180187
@Test

0 commit comments

Comments
 (0)