polish

Author: Bilal Al

client/src/main/java/io/split/client/SplitClientConfig.java

@@ -16,7 +16,6 @@
 import java.util.List;
 import java.util.Properties;
 import java.util.concurrent.ThreadFactory;
-import java.util.Locale;
 import java.io.InputStream;
 
 import static io.split.inputValidation.FlagSetsValidator.cleanup;

client/src/main/java/io/split/service/SplitHttpClientKerberosImpl.java

@@ -14,8 +14,12 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import java.io.*;
-import java.net.*;
+import java.io.InputStreamReader;
+import java.io.BufferedReader;
+import java.io.IOException;
+import java.io.OutputStream;
+import java.net.URI;
+import java.net.HttpURLConnection;
 import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
 import java.util.List;
@@ -38,7 +42,7 @@ public class SplitHttpClientKerberosImpl implements SplitHttpClient {
 
     public static SplitHttpClientKerberosImpl create(RequestDecorator requestDecorator,
                                                      String apikey,
-                                                     SDKMetadata metadata) throws URISyntaxException {
+                                                     SDKMetadata metadata) {
         return new SplitHttpClientKerberosImpl(requestDecorator, apikey, metadata);
     }
 
@@ -99,10 +103,11 @@ public SplitHttpResponse doGet(HttpURLConnection getHttpURLConnection, FetchOpti
             inputStreamReader = new InputStreamReader(getHttpURLConnection.getInputStream());
             BufferedReader br = new BufferedReader(inputStreamReader);
             String strCurrentLine;
-            String responseBody = new String();
+            StringBuilder bld = new StringBuilder();
             while ((strCurrentLine = br.readLine()) != null) {
-                responseBody = responseBody + strCurrentLine;
+                bld.append(strCurrentLine);
             }
+            String responseBody = bld.toString();
             return new SplitHttpResponse(responseCode,
                     statusMessage,
                     responseBody,
@@ -197,7 +202,7 @@ private void setAdditionalAndDecoratedHeaders(HttpURLConnection urlConnection, M
     }
 
     private Header[] getResponseHeaders(HttpURLConnection urlConnection) {
-        List<BasicHeader> responseHeaders = new ArrayList<BasicHeader>();
+        List<BasicHeader> responseHeaders = new ArrayList<>();
         Map<String, List<String>> map = urlConnection.getHeaderFields();
         for (Map.Entry<String, List<String>> entry : map.entrySet()) {
             if (entry.getKey() != null) {
@@ -209,6 +214,6 @@ private Header[] getResponseHeaders(HttpURLConnection urlConnection) {
     }
     @Override
     public void close() throws IOException {
-
+        // Added for compatibility with HttpSplitClient, no action needed as URLConnection objects are closed.
     }
 }