updated test coverage and version

Author: Bilal Al

client/pom.xml

@@ -5,7 +5,7 @@
     <parent>
         <groupId>io.split.client</groupId>
         <artifactId>java-client-parent</artifactId>
-        <version>4.12.0-rc3</version>
+        <version>4.12.0-rc4</version>
     </parent>
     <artifactId>java-client</artifactId>
     <packaging>jar</packaging>

client/src/test/java/io/split/engine/matchers/BetweenSemverMatcherTest.java

@@ -21,5 +21,16 @@ public void works() {
         assertTrue( betweenSemverMatcher.match("3.0.0+build", null, null, null));
         assertFalse( betweenSemverMatcher.match("4.5.8", null, null, null));
         assertFalse( betweenSemverMatcher.match("1.0.4", null, null, null));
+        assertTrue(betweenSemverMatcher.equals(betweenSemverMatcher));
+        assertTrue(betweenSemverMatcher.hashCode() != 0);
+    }
+
+    @Test
+    public void testNull() {
+        BetweenSemverMatcher betweenSemverMatcher = new BetweenSemverMatcher("2.1.8", "3.0.0");
+        assertFalse( betweenSemverMatcher.match(null, null, null, null));
+
+        betweenSemverMatcher = new BetweenSemverMatcher("2.www.8", "3.xx.0");
+        assertFalse(betweenSemverMatcher.match("2.www.8", null, null, null));
     }
 }

client/src/test/java/io/split/engine/matchers/EqualToSemverMatcherTest.java

@@ -19,5 +19,16 @@ public void works() {
         assertFalse(equalToSemverMatcher.match("2.1.9", null, null, null));
         assertFalse(equalToSemverMatcher.match("2.1.8-rc", null, null, null));
         assertFalse( equalToSemverMatcher.match("2.1.8+build", null, null, null));
+        assertTrue(equalToSemverMatcher.equals(equalToSemverMatcher));
+        assertTrue(equalToSemverMatcher.hashCode() != 0);
+    }
+
+    @Test
+    public void testNull() {
+        EqualToSemverMatcher equalToSemverMatcher = new EqualToSemverMatcher("2.1.8");
+        assertFalse( equalToSemverMatcher.match(null, null, null, null));
+
+        equalToSemverMatcher = new EqualToSemverMatcher("2.ee.8");
+        assertFalse(equalToSemverMatcher.match("2.ee.8", null, null, null));
     }
 }

client/src/test/java/io/split/engine/matchers/GreaterThanOrEqualToSemverMatcherTest.java

@@ -19,5 +19,16 @@ public void works() {
         assertFalse( greaterThanOrEqualToSemverMatcher.match("2.1.8-rc", null, null, null));
         assertFalse( greaterThanOrEqualToSemverMatcher.match("2.0.10", null, null, null));
         assertTrue( greaterThanOrEqualToSemverMatcher.match("2.1.8+build", null, null, null));
+        assertTrue(greaterThanOrEqualToSemverMatcher.equals(greaterThanOrEqualToSemverMatcher));
+        assertTrue(greaterThanOrEqualToSemverMatcher.hashCode() != 0);
+    }
+
+    @Test
+    public void testNull() {
+        GreaterThanOrEqualToSemverMatcher greaterThanOrEqualToSemverMatcher = new GreaterThanOrEqualToSemverMatcher("2.1.8");
+        assertFalse( greaterThanOrEqualToSemverMatcher.match(null, null, null, null));
+
+        greaterThanOrEqualToSemverMatcher = new GreaterThanOrEqualToSemverMatcher("2.ee.8");
+        assertFalse(greaterThanOrEqualToSemverMatcher.match("2.ee.8", null, null, null));
     }
 }

client/src/test/java/io/split/engine/matchers/InListSemverMatcherTest.java

@@ -5,6 +5,7 @@
 
 import java.util.List;
 
+import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertTrue;
 
 /**
@@ -23,5 +24,18 @@ public void works() {
         assertTrue( inListSemverMatcher.match("2.1.8-rc", null, null, null) == false);
         assertTrue( inListSemverMatcher.match("3.4.0", null, null, null) == true);
         assertTrue( inListSemverMatcher.match("3.4.0+build", null, null, null) == false);
+        assertTrue(inListSemverMatcher.equals(inListSemverMatcher));
+        assertTrue(inListSemverMatcher.hashCode() != 0);
+    }
+
+    @Test
+    public void testNull() {
+        List<String> whitelist = Lists.newArrayList("2.1.8", "3.4.0");
+        InListSemverMatcher inListSemverMatcher = new InListSemverMatcher(whitelist);
+        assertFalse( inListSemverMatcher.match(null, null, null, null));
+
+        whitelist = Lists.newArrayList("2.1.eee", "3.xxx.0");
+        inListSemverMatcher = new InListSemverMatcher(whitelist);
+        assertFalse(inListSemverMatcher.match("2.1.eee", null, null, null));
     }
 }

client/src/test/java/io/split/engine/matchers/LessThanOrEqualToSemverMatcherTest.java

@@ -20,5 +20,16 @@ public void works() {
         assertTrue( lessThanOrEqualToSemverMatcher.match("2.1.8-rc", null, null, null));
         assertTrue( lessThanOrEqualToSemverMatcher.match("2.0.10", null, null, null));
         assertTrue( lessThanOrEqualToSemverMatcher.match("2.1.8+build", null, null, null));
+        assertTrue(lessThanOrEqualToSemverMatcher.equals(lessThanOrEqualToSemverMatcher));
+        assertTrue(lessThanOrEqualToSemverMatcher.hashCode() != 0);
+    }
+
+    @Test
+    public void testNull() {
+        LessThanOrEqualToSemverMatcher lessThanOrEqualToSemverMatcher = new LessThanOrEqualToSemverMatcher("2.1.8");
+        assertFalse( lessThanOrEqualToSemverMatcher.match(null, null, null, null));
+
+        lessThanOrEqualToSemverMatcher = new LessThanOrEqualToSemverMatcher("2.ee.8");
+        assertFalse(lessThanOrEqualToSemverMatcher.match("2.ee.8", null, null, null));
     }
 }

pluggable-storage/pom.xml

@@ -6,7 +6,7 @@
     <parent>
         <artifactId>java-client-parent</artifactId>
         <groupId>io.split.client</groupId>
-        <version>4.12.0-rc3</version>
+        <version>4.12.0-rc4</version>
     </parent>
 
     <version>2.1.0</version>

pom.xml

@@ -4,7 +4,7 @@
     <modelVersion>4.0.0</modelVersion>
     <groupId>io.split.client</groupId>
     <artifactId>java-client-parent</artifactId>
-    <version>4.12.0-rc3</version>
+    <version>4.12.0-rc4</version>
     <dependencyManagement>
         <dependencies>
             <dependency>

redis-wrapper/pom.xml

@@ -6,7 +6,7 @@
     <parent>
         <artifactId>java-client-parent</artifactId>
         <groupId>io.split.client</groupId>
-        <version>4.12.0-rc3</version>
+        <version>4.12.0-rc4</version>
     </parent>
     <artifactId>redis-wrapper</artifactId>
     <version>3.1.0</version>