polish

Author: Bilal Al

client/src/main/java/io/split/client/SplitClientImpl.java

@@ -455,7 +455,7 @@ private Map<String, SplitResult> processEvaluatorResult(Map<String, EvaluatorImp
             }
         });
         _telemetryEvaluationProducer.recordLatency(methodEnum, System.currentTimeMillis() - initTime);
-        if (decoratedImpressions.size() > 0) {
+        if (!decoratedImpressions.isEmpty()) {
             _impressionManager.track(decoratedImpressions);
         }
         return result;

client/src/main/java/io/split/client/dtos/DecoratedImpression.java

@@ -3,12 +3,16 @@
 import io.split.client.impressions.Impression;
 
 public class DecoratedImpression {
-    public Impression impression;
-    public boolean track;
+    private Impression impression;
+    private boolean track;
 
     public DecoratedImpression(Impression impression, boolean track) {
         this.impression = impression;
         this.track = track;
     }
+
+    public Impression impression() { return this.impression;}
+
+    public boolean track() { return this.track;}
 }
 

client/src/main/java/io/split/client/impressions/ImpressionsManagerImpl.java

@@ -132,12 +132,12 @@ public void track(List<DecoratedImpression> decoratedImpressions) {
 
         for (int i = 0; i < decoratedImpressions.size(); i++) {
             ImpressionsResult impressionsResult;
-            if (decoratedImpressions.get(i).track) {
+            if (decoratedImpressions.get(i).track()) {
                 impressionsResult = _processImpressionStrategy.process(Stream.of(
-                        decoratedImpressions.get(i).impression).collect(Collectors.toList()));
+                        decoratedImpressions.get(i).impression()).collect(Collectors.toList()));
             } else {
                 impressionsResult = _processImpressionNone.process(Stream.of(
-                        decoratedImpressions.get(i).impression).collect(Collectors.toList()));
+                        decoratedImpressions.get(i).impression()).collect(Collectors.toList()));
             }
             if (!Objects.isNull(impressionsResult.getImpressionsToQueue())) {
                 impressionsForLogs.addAll(impressionsResult.getImpressionsToQueue());

client/src/test/java/io/split/client/SplitClientImplTest.java

@@ -724,7 +724,7 @@ public void labelsArePopulated() {
         List<DecoratedImpression> impressions = impressionCaptor.getValue();
         assertNotNull(impressions);
         assertEquals(1, impressions.size());
-        Impression impression = impressions.get(0).impression;
+        Impression impression = impressions.get(0).impression();
 
         assertEquals("foolabel", impression.appliedRule());
 
@@ -824,7 +824,7 @@ private void trafficAllocation(String key, int trafficAllocation, int trafficAll
         assertNotNull(impressionCaptor.getValue());
         assertEquals(1, impressionCaptor.getValue().size());
         DecoratedImpression impression = (DecoratedImpression) impressionCaptor.getValue().get(0);
-        assertEquals(label, impression.impression.appliedRule());
+        assertEquals(label, impression.impression().appliedRule());
     }
 
     /**
@@ -880,7 +880,7 @@ public void notInTrafficAllocationDefaultConfig() {
         assertNotNull(impressionCaptor.getValue());
         assertEquals(1, impressionCaptor.getValue().size());
         DecoratedImpression impression = (DecoratedImpression) impressionCaptor.getValue().get(0);
-        assertEquals("not in split", impression.impression.appliedRule());
+        assertEquals("not in split", impression.impression().appliedRule());
     }
 
 
@@ -1044,8 +1044,8 @@ public void impressionMetadataIsPropagated() {
         assertEquals(1, impressionCaptor.getValue().size());
         DecoratedImpression impression = (DecoratedImpression) impressionCaptor.getValue().get(0);
 
-        assertEquals("foolabel", impression.impression.appliedRule());
-        assertEquals(attributes, impression.impression.attributes());
+        assertEquals("foolabel", impression.impression().appliedRule());
+        assertEquals(attributes, impression.impression().attributes());
     }
 
     private Partition partition(String treatment, int size) {

client/src/test/java/io/split/client/SplitClientIntegrationTest.java

@@ -830,7 +830,6 @@ public MockResponse dispatch(RecordedRequest request) {
         Assert.assertEquals("off", client.getTreatment("user1", "without_impression_toggle", null));
         Assert.assertEquals("off", client.getTreatment("user2", "impression_toggle_on", null));
         Assert.assertEquals("off", client.getTreatment("user3", "impression_toggle_off", null));
-        Thread.sleep(1000);
         client.destroy();
         boolean check1 = false, check2 = false;
         for (int i=0; i < allRequests.size(); i++ ) {
@@ -905,7 +904,6 @@ public MockResponse dispatch(RecordedRequest request) {
         Assert.assertEquals("off", client.getTreatment("user1", "without_impression_toggle", null));
         Assert.assertEquals("off", client.getTreatment("user2", "impression_toggle_on", null));
         Assert.assertEquals("off", client.getTreatment("user3", "impression_toggle_off", null));
-        Thread.sleep(1000);
         client.destroy();
         boolean check1 = false, check2 = false, check3 = false;
         for (int i=0; i < allRequests.size(); i++ ) {
@@ -988,7 +986,6 @@ public MockResponse dispatch(RecordedRequest request) {
         Assert.assertEquals("off", client.getTreatment("user1", "without_impression_toggle", null));
         Assert.assertEquals("off", client.getTreatment("user2", "impression_toggle_on", null));
         Assert.assertEquals("off", client.getTreatment("user3", "impression_toggle_off", null));
-        Thread.sleep(1000);
         client.destroy();
         boolean check1 = false, check2 = false, check3 = false;
         for (int i=0; i < allRequests.size(); i++ ) {