Skip to content

Commit 6551209

Browse files
author
Bilal Al
committed
polish
1 parent ccea626 commit 6551209

File tree

5 files changed

+15
-14
lines changed

5 files changed

+15
-14
lines changed

client/src/main/java/io/split/client/SplitClientImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -455,7 +455,7 @@ private Map<String, SplitResult> processEvaluatorResult(Map<String, EvaluatorImp
455455
}
456456
});
457457
_telemetryEvaluationProducer.recordLatency(methodEnum, System.currentTimeMillis() - initTime);
458-
if (decoratedImpressions.size() > 0) {
458+
if (!decoratedImpressions.isEmpty()) {
459459
_impressionManager.track(decoratedImpressions);
460460
}
461461
return result;

client/src/main/java/io/split/client/dtos/DecoratedImpression.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,16 @@
33
import io.split.client.impressions.Impression;
44

55
public class DecoratedImpression {
6-
public Impression impression;
7-
public boolean track;
6+
private Impression impression;
7+
private boolean track;
88

99
public DecoratedImpression(Impression impression, boolean track) {
1010
this.impression = impression;
1111
this.track = track;
1212
}
13+
14+
public Impression impression() { return this.impression;}
15+
16+
public boolean track() { return this.track;}
1317
}
1418

client/src/main/java/io/split/client/impressions/ImpressionsManagerImpl.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -132,12 +132,12 @@ public void track(List<DecoratedImpression> decoratedImpressions) {
132132

133133
for (int i = 0; i < decoratedImpressions.size(); i++) {
134134
ImpressionsResult impressionsResult;
135-
if (decoratedImpressions.get(i).track) {
135+
if (decoratedImpressions.get(i).track()) {
136136
impressionsResult = _processImpressionStrategy.process(Stream.of(
137-
decoratedImpressions.get(i).impression).collect(Collectors.toList()));
137+
decoratedImpressions.get(i).impression()).collect(Collectors.toList()));
138138
} else {
139139
impressionsResult = _processImpressionNone.process(Stream.of(
140-
decoratedImpressions.get(i).impression).collect(Collectors.toList()));
140+
decoratedImpressions.get(i).impression()).collect(Collectors.toList()));
141141
}
142142
if (!Objects.isNull(impressionsResult.getImpressionsToQueue())) {
143143
impressionsForLogs.addAll(impressionsResult.getImpressionsToQueue());

client/src/test/java/io/split/client/SplitClientImplTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -724,7 +724,7 @@ public void labelsArePopulated() {
724724
List<DecoratedImpression> impressions = impressionCaptor.getValue();
725725
assertNotNull(impressions);
726726
assertEquals(1, impressions.size());
727-
Impression impression = impressions.get(0).impression;
727+
Impression impression = impressions.get(0).impression();
728728

729729
assertEquals("foolabel", impression.appliedRule());
730730

@@ -824,7 +824,7 @@ private void trafficAllocation(String key, int trafficAllocation, int trafficAll
824824
assertNotNull(impressionCaptor.getValue());
825825
assertEquals(1, impressionCaptor.getValue().size());
826826
DecoratedImpression impression = (DecoratedImpression) impressionCaptor.getValue().get(0);
827-
assertEquals(label, impression.impression.appliedRule());
827+
assertEquals(label, impression.impression().appliedRule());
828828
}
829829

830830
/**
@@ -880,7 +880,7 @@ public void notInTrafficAllocationDefaultConfig() {
880880
assertNotNull(impressionCaptor.getValue());
881881
assertEquals(1, impressionCaptor.getValue().size());
882882
DecoratedImpression impression = (DecoratedImpression) impressionCaptor.getValue().get(0);
883-
assertEquals("not in split", impression.impression.appliedRule());
883+
assertEquals("not in split", impression.impression().appliedRule());
884884
}
885885

886886

@@ -1044,8 +1044,8 @@ public void impressionMetadataIsPropagated() {
10441044
assertEquals(1, impressionCaptor.getValue().size());
10451045
DecoratedImpression impression = (DecoratedImpression) impressionCaptor.getValue().get(0);
10461046

1047-
assertEquals("foolabel", impression.impression.appliedRule());
1048-
assertEquals(attributes, impression.impression.attributes());
1047+
assertEquals("foolabel", impression.impression().appliedRule());
1048+
assertEquals(attributes, impression.impression().attributes());
10491049
}
10501050

10511051
private Partition partition(String treatment, int size) {

client/src/test/java/io/split/client/SplitClientIntegrationTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -830,7 +830,6 @@ public MockResponse dispatch(RecordedRequest request) {
830830
Assert.assertEquals("off", client.getTreatment("user1", "without_impression_toggle", null));
831831
Assert.assertEquals("off", client.getTreatment("user2", "impression_toggle_on", null));
832832
Assert.assertEquals("off", client.getTreatment("user3", "impression_toggle_off", null));
833-
Thread.sleep(1000);
834833
client.destroy();
835834
boolean check1 = false, check2 = false;
836835
for (int i=0; i < allRequests.size(); i++ ) {
@@ -905,7 +904,6 @@ public MockResponse dispatch(RecordedRequest request) {
905904
Assert.assertEquals("off", client.getTreatment("user1", "without_impression_toggle", null));
906905
Assert.assertEquals("off", client.getTreatment("user2", "impression_toggle_on", null));
907906
Assert.assertEquals("off", client.getTreatment("user3", "impression_toggle_off", null));
908-
Thread.sleep(1000);
909907
client.destroy();
910908
boolean check1 = false, check2 = false, check3 = false;
911909
for (int i=0; i < allRequests.size(); i++ ) {
@@ -988,7 +986,6 @@ public MockResponse dispatch(RecordedRequest request) {
988986
Assert.assertEquals("off", client.getTreatment("user1", "without_impression_toggle", null));
989987
Assert.assertEquals("off", client.getTreatment("user2", "impression_toggle_on", null));
990988
Assert.assertEquals("off", client.getTreatment("user3", "impression_toggle_off", null));
991-
Thread.sleep(1000);
992989
client.destroy();
993990
boolean check1 = false, check2 = false, check3 = false;
994991
for (int i=0; i < allRequests.size(); i++ ) {

0 commit comments

Comments
 (0)