Merge pull request #469 from splitio/SDKS-7890

[SDKS-7890] Update naming convention and remove some imports not using

Author: nmayorsplit

client/src/main/java/io/split/client/SplitClientConfig.java

@@ -359,9 +359,17 @@ public String telemetryURL() {
         return _telemetryURL;
     }
 
+    /**
+     * @deprecated  As of release 4.X.X, replaced by {@link #getTelemetryRefreshRate()} } //todo update version
+     **/
+    @Deprecated
     public int get_telemetryRefreshRate() {
         return _telemetryRefreshRate;
     }
+
+    public int getTelemetryRefreshRate() {
+        return _telemetryRefreshRate;
+    }
     public int streamingRetryDelay() {return _onDemandFetchRetryDelayMs;}
 
     public int streamingFetchMaxRetries() {return _onDemandFetchMaxRetries;}

client/src/main/java/io/split/client/SplitFactoryImpl.java

@@ -234,9 +234,7 @@ public SplitFactoryImpl(String apiToken, SplitClientConfig config) throws URISyn
         EventsSender eventsSender = EventsSender.create(_splitHttpClient, _eventsRootTarget, _telemetryStorageProducer);
         _eventsTask = EventsTask.create(config.eventSendIntervalInMillis(), eventsStorage, eventsSender,
                 config.getThreadFactory());
-
-        _telemetrySyncTask = new TelemetrySyncTask(config.get_telemetryRefreshRate(), _telemetrySynchronizer,
-                config.getThreadFactory());
+        _telemetrySyncTask = new TelemetrySyncTask(config.getTelemetryRefreshRate(), _telemetrySynchronizer, config.getThreadFactory());
 
         // Evaluator
         _evaluator = new EvaluatorImp(splitCache, segmentCache);
@@ -330,10 +328,8 @@ protected SplitFactoryImpl(String apiToken, SplitClientConfig config, CustomStor
         _evaluator = new EvaluatorImp(userCustomSplitAdapterConsumer, userCustomSegmentAdapterConsumer);
         _impressionsSender = PluggableImpressionSender.create(customStorageWrapper);
         _uniqueKeysTracker = createUniqueKeysTracker(config);
-        _impressionsManager = buildImpressionsManager(config, userCustomImpressionAdapterConsumer,
-                userCustomImpressionAdapterProducer);
-        _telemetrySyncTask = new TelemetrySyncTask(config.get_telemetryRefreshRate(), _telemetrySynchronizer,
-                config.getThreadFactory());
+        _impressionsManager = buildImpressionsManager(config, userCustomImpressionAdapterConsumer, userCustomImpressionAdapterProducer);
+        _telemetrySyncTask = new TelemetrySyncTask(config.getTelemetryRefreshRate(), _telemetrySynchronizer, config.getThreadFactory());
 
         SplitTasks splitTasks = SplitTasks.build(null, null,
                 _impressionsManager, null, _telemetrySyncTask, _uniqueKeysTracker);

client/src/main/java/io/split/engine/SDKReadinessGates.java

@@ -3,9 +3,6 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import java.util.Map;
-import java.util.concurrent.ConcurrentHashMap;
-import java.util.concurrent.ConcurrentMap;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.TimeUnit;
 

client/src/main/java/io/split/engine/common/SplitTasks.java

@@ -5,11 +5,8 @@
 import io.split.client.impressions.UniqueKeysTracker;
 import io.split.engine.experiments.SplitSynchronizationTask;
 import io.split.engine.segments.SegmentSynchronizationTask;
-import io.split.engine.segments.SegmentSynchronizationTaskImp;
 import io.split.telemetry.synchronizer.TelemetrySyncTask;
 
-import static com.google.common.base.Preconditions.checkNotNull;
-
 public class SplitTasks {
     private final SplitSynchronizationTask _splitSynchronizationTask;
     private final SegmentSynchronizationTask _segmentSynchronizationTask;

client/src/main/java/io/split/engine/matchers/AllKeysMatcher.java

@@ -1,7 +1,6 @@
 package io.split.engine.matchers;
 
 import io.split.engine.evaluator.EvaluationContext;
-import io.split.engine.evaluator.Evaluator;
 
 import java.util.Map;
 

client/src/main/java/io/split/engine/matchers/AttributeMatcher.java

@@ -1,7 +1,6 @@
 package io.split.engine.matchers;
 
 import io.split.engine.evaluator.EvaluationContext;
-import io.split.engine.evaluator.Evaluator;
 
 import java.util.Map;
 import java.util.Objects;

client/src/main/java/io/split/engine/matchers/BetweenMatcher.java

@@ -2,7 +2,6 @@
 
 import io.split.client.dtos.DataType;
 import io.split.engine.evaluator.EvaluationContext;
-import io.split.engine.evaluator.Evaluator;
 
 import java.util.Map;
 

client/src/main/java/io/split/engine/matchers/BooleanMatcher.java

@@ -1,7 +1,6 @@
 package io.split.engine.matchers;
 
 import io.split.engine.evaluator.EvaluationContext;
-import io.split.engine.evaluator.Evaluator;
 
 import java.util.Map;
 

client/src/main/java/io/split/engine/matchers/CombiningMatcher.java

@@ -2,10 +2,8 @@
 
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.Lists;
-import io.split.client.SplitClientImpl;
 import io.split.client.dtos.MatcherCombiner;
 import io.split.engine.evaluator.EvaluationContext;
-import io.split.engine.evaluator.Evaluator;
 
 import java.util.List;
 import java.util.Map;

client/src/main/java/io/split/engine/matchers/EqualToMatcher.java

@@ -2,7 +2,6 @@
 
 import io.split.client.dtos.DataType;
 import io.split.engine.evaluator.EvaluationContext;
-import io.split.engine.evaluator.Evaluator;
 
 import java.util.Map;