Removed gettrackkeys function

Author: chillaq

client/src/main/java/io/split/client/impressions/UniqueKeysTrackerImp.java

@@ -28,6 +28,7 @@ public class UniqueKeysTrackerImp implements UniqueKeysTracker{
     private static final double MARGIN_ERROR = 0.01;
     private static final int MAX_UNIQUE_KEYS_POST_SIZE = 5000;
     private static final int MAX_AMOUNT_OF_KEYS = 10000000;
+    private int trackerKeysSize = 0;
     private FilterAdapter filterAdapter;
     private final TelemetrySynchronizer _telemetrySynchronizer;
     private final ScheduledExecutorService _uniqueKeysSyncScheduledExecutorService;
@@ -60,10 +61,11 @@ public boolean track(String featureFlagName, String key) {
                 (feature, current) -> {
                     HashSet<String> keysByFeature = Optional.ofNullable(current).orElse(new HashSet<>());
                     keysByFeature.add(key);
+                    trackerKeysSize++;
                     return keysByFeature;
                 });
         _logger.debug("The feature flag " + featureFlagName + " and key " + key + " was added");
-        if (getTrackerKeysSize() >= MAX_UNIQUE_KEYS_POST_SIZE){
+        if (trackerKeysSize >= MAX_UNIQUE_KEYS_POST_SIZE){
             _logger.warn("The UniqueKeysTracker size reached the maximum limit");
             try {
                 sendUniqueKeys();
@@ -108,6 +110,7 @@ public HashMap<String,HashSet<String>> popAll(){
             HashSet<String> value = uniqueKeysTracker.remove(key);
             toReturn.put(key, value);
         }
+        trackerKeysSize = 0;
         return toReturn;
     }
 
@@ -188,6 +191,7 @@ private int getTrackerKeysSize() {
     private interface ExecuteUniqueKeysAction{
         void execute();
     }
+
     private class ExecuteCleanFilter implements ExecuteUniqueKeysAction {
 
         @Override

client/src/test/java/io/split/client/impressions/UniqueKeysTrackerImpTest.java

@@ -6,6 +6,8 @@
 import org.junit.Assert;
 import org.junit.Test;
 import org.mockito.Mockito;
+
+import java.lang.reflect.Field;
 import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
 import java.util.HashMap;
@@ -158,17 +160,18 @@ public void testUniqueKeysChunks() throws NoSuchMethodException, InvocationTarge
     }
 
     @Test
-    public void testTrackReachMaxKeys() throws NoSuchMethodException, InvocationTargetException, IllegalAccessException {
+    public void testTrackReachMaxKeys() throws NoSuchMethodException, InvocationTargetException, IllegalAccessException, NoSuchFieldException {
         TelemetrySynchronizer telemetrySynchronizer = Mockito.mock(TelemetryInMemorySubmitter.class);
         UniqueKeysTrackerImp uniqueKeysTrackerImp = new UniqueKeysTrackerImp(telemetrySynchronizer, 10000, 10000, null);
         for (int i=1; i<6000; i++) {
             Assert.assertTrue(uniqueKeysTrackerImp.track("feature1", "key" + i));
             Assert.assertTrue(uniqueKeysTrackerImp.track("feature2", "key" + i));
         }
         Mockito.verify(telemetrySynchronizer, Mockito.times(2)).synchronizeUniqueKeys(Mockito.anyObject());
-        Method methodGetTrackerSize = uniqueKeysTrackerImp.getClass().getDeclaredMethod("getTrackerKeysSize");
-        methodGetTrackerSize.setAccessible(true);
-        int trackerSize = (int) methodGetTrackerSize.invoke(uniqueKeysTrackerImp);
+
+        Field getTrackerSize = uniqueKeysTrackerImp.getClass().getDeclaredField("trackerKeysSize");
+        getTrackerSize.setAccessible(true);
+        int trackerSize = (int) getTrackerSize.get(uniqueKeysTrackerImp);
         Assert.assertTrue(trackerSize == 1998);
     }
 }