Skip to content

Commit 8a3cf10

Browse files
committed
[SDKS-7889] Add YML in FileTypeEnum
1 parent 98526f0 commit 8a3cf10

File tree

4 files changed

+30
-0
lines changed

4 files changed

+30
-0
lines changed

client/src/main/java/io/split/client/SplitFactoryImpl.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -674,6 +674,7 @@ private SplitChangeFetcher createSplitChangeFetcher(SplitClientConfig splitClien
674674
case JSON:
675675
return new JsonLocalhostSplitChangeFetcher(inputStreamProvider);
676676
case YAML:
677+
case YML:
677678
return new YamlLocalhostSplitChangeFetcher(inputStreamProvider);
678679
default:
679680
_log.warn(LEGACY_LOG_MESSAGE);

client/src/main/java/io/split/client/utils/FileTypeEnum.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,6 @@
33
public enum FileTypeEnum {
44
LEGACY,
55
YAML,
6+
YML,
67
JSON
78
}

client/src/test/java/io/split/client/LocalhostSplitFactoryYamlCompactSampleTest.java

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,4 +42,29 @@ public void works() throws IOException, URISyntaxException {
4242
assertThat(client.getTreatmentWithConfig("user_e", "split_2").treatment(), is(equalTo("off")));
4343
assertThat(client.getTreatmentWithConfig("user_e", "split_2").config(), is(equalTo("{ \"size\" : 55 }")));
4444
}
45+
46+
@Test
47+
public void worksYML() throws IOException, URISyntaxException {
48+
49+
String file = getClass().getClassLoader().getResource("split_compact.yml").getFile();
50+
51+
SplitClientConfig config = SplitClientConfig.builder().splitFile(file).build();
52+
SplitFactory splitFactory = SplitFactoryBuilder.build("localhost", config);
53+
SplitClient client = splitFactory.client();
54+
55+
assertThat(client.getTreatment(null, "foo"), is(equalTo(Treatments.CONTROL)));
56+
assertThat(client.getTreatment("user_c", "foo"), is(equalTo(Treatments.CONTROL)));
57+
58+
assertThat(client.getTreatment("user_c", "split_1"), is(equalTo("off")));
59+
assertThat(client.getTreatmentWithConfig("user_c", "split_1").treatment(), is(equalTo("off")));
60+
assertThat(client.getTreatmentWithConfig("user_c", "split_1").config(), is(equalTo("{ \"size\" : 10 }")));
61+
62+
assertThat(client.getTreatment("user_d", "split_1"), is(equalTo("on")));
63+
assertThat(client.getTreatmentWithConfig("user_d", "split_1").treatment(), is(equalTo("on")));
64+
assertThat(client.getTreatmentWithConfig("user_d", "split_1").config(), is(nullValue()));
65+
66+
assertThat(client.getTreatment("user_e", "split_2"), is(equalTo("off")));
67+
assertThat(client.getTreatmentWithConfig("user_e", "split_2").treatment(), is(equalTo("off")));
68+
assertThat(client.getTreatmentWithConfig("user_e", "split_2").config(), is(equalTo("{ \"size\" : 55 }")));
69+
}
4570
}
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
- split_1: {keys: user_c, treatment: 'off', config: '{ "size" : 10 }'}
2+
- split_1: {keys: user_d, treatment: 'on'}
3+
- split_2: {keys: user_e, treatment: 'off', config: '{ "size" : 55 }'}

0 commit comments

Comments
 (0)