Skip to content

Commit 9c11e85

Browse files
committed
Updated pom and proxy config
1 parent 741e23d commit 9c11e85

File tree

4 files changed

+16
-19
lines changed

4 files changed

+16
-19
lines changed

client/src/main/java/io/split/client/dtos/ProxyConfiguration.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import org.apache.hc.core5.http.HttpHost;
44

5+
import java.net.MalformedURLException;
56
import java.net.URL;
67

78
public class ProxyConfiguration {
@@ -39,8 +40,12 @@ public ProxyConfiguration.Builder credentialsProvider(ProxyCredentialsProvider p
3940
return this;
4041
}
4142

42-
public ProxyConfiguration.Builder url(URL url) {
43-
_proxyHost = new HttpHost(url.getProtocol(), url.getHost(), url.getPort());
43+
public ProxyConfiguration.Builder url(URL url) throws MalformedURLException {
44+
try {
45+
_proxyHost = new HttpHost(url.getProtocol(), url.getHost(), url.getPort());
46+
} catch (Exception exc) {
47+
throw new MalformedURLException("roxy configuration is ignored. The proxy `url` was not provided or is malformed");
48+
}
4449
return this;
4550
}
4651

client/src/test/java/io/split/client/SplitClientConfigTest.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -324,6 +324,15 @@ public void cannotUseInvalidHttpScheme() throws MalformedURLException {
324324
.build();
325325
}
326326

327+
@Test(expected = MalformedURLException.class)
328+
public void cannotUseInvalidUrl() throws MalformedURLException {
329+
SplitClientConfig.builder()
330+
.proxyConfiguration(new ProxyConfiguration.Builder()
331+
.url(new URL(""))
332+
.build())
333+
.build();
334+
}
335+
327336
@Test(expected = IllegalArgumentException.class)
328337
public void mustUseP12FileWithProxyMtls() throws MalformedURLException {
329338
SplitClientConfig.builder()

client/src/test/java/io/split/client/SplitFactoryImplTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package io.split.client;
22

3-
import io.split.client.dtos.BearerCredentialsProvider;
43
import io.split.client.dtos.ProxyConfiguration;
54
import io.split.client.impressions.ImpressionsManager;
65
import io.split.client.utils.FileTypeEnum;

pom.xml

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -53,16 +53,8 @@
5353
<id>ossrh</id>
5454
<url>https://oss.sonatype.org/content/repositories/releases</url>
5555
</repository>
56-
<repository>
57-
<id>maven-all-virtual</id>
58-
<url>https://splitio.jfrog.io/artifactory/maven-all-virtual</url>
59-
</repository>
6056
</repositories>
6157
<pluginRepositories>
62-
<pluginRepository>
63-
<id>maven-all-virtual</id>
64-
<url>https://splitio.jfrog.io/artifactory/maven-all-virtual</url>
65-
</pluginRepository>
6658
</pluginRepositories>
6759
<properties>
6860
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
@@ -146,14 +138,6 @@
146138
<profile>
147139
<id>test</id>
148140
<distributionManagement>
149-
<repository>
150-
<id>maven-dev</id>
151-
<url>https://splitio.jfrog.io/artifactory/maven-dev/</url>
152-
</repository>
153-
<snapshotRepository>
154-
<id>maven-dev</id>
155-
<url>https://splitio.jfrog.io/artifactory/maven-dev/</url>
156-
</snapshotRepository>
157141
</distributionManagement>
158142
<build>
159143
<plugins>

0 commit comments

Comments
 (0)