polish

Author: chillaq

client/src/main/java/io/split/client/SplitClientImpl.java

@@ -1,8 +1,6 @@
 package io.split.client;
 
-import com.google.gson.Gson;
 import com.google.gson.GsonBuilder;
-import com.google.gson.JsonParser;
 import io.split.client.api.Key;
 import io.split.client.api.SplitResult;
 import io.split.client.dtos.DecoratedImpression;
@@ -26,7 +24,6 @@
 import io.split.telemetry.domain.enums.MethodEnum;
 import io.split.telemetry.storage.TelemetryConfigProducer;
 import io.split.telemetry.storage.TelemetryEvaluationProducer;
-import io.split.client.utils.Json;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 

client/src/test/java/io/split/client/SplitClientImplTest.java

@@ -2143,16 +2143,24 @@ public void impressionPropertiesTest() {
         assertEquals("on", client.getTreatmentsByFlagSets(new Key("bilal13@codigo.com", "bilal13@codigo.com"), Arrays.asList("set"), attributes, properties).get(test));
         assertEquals("on", client.getTreatmentsWithConfigByFlagSet(new Key("bilal14@codigo.com", "bilal14@codigo.com"), "set", attributes, properties).get(test).treatment());
         assertEquals("on", client.getTreatmentsWithConfigByFlagSets(new Key("bilal15@codigo.com", "bilal15@codigo.com"), Arrays.asList("set"), attributes, properties).get(test).treatment());
+        assertEquals("off", client.getTreatment("bilal16@codigo.com", test, properties));
+        assertEquals("off", client.getTreatmentWithConfig("bilal17@codigo.com", test, properties).treatment());
+        assertEquals("off", client.getTreatments("bilal18@codigo.com", Arrays.asList(test), properties).get(test));
+        assertEquals("off", client.getTreatmentsWithConfig("bilal19@codigo.com", Arrays.asList(test), properties).get(test).treatment());
+        assertEquals("off", client.getTreatmentsByFlagSet("bilal20@codigo.com", "set", properties).get(test));
+        assertEquals("off", client.getTreatmentsByFlagSets("bilal21@codigo.com", Arrays.asList("set"), properties).get(test));
+        assertEquals("off", client.getTreatmentsWithConfigByFlagSet("bilal22@codigo.com", "set", properties).get(test).treatment());
+        assertEquals("off", client.getTreatmentsWithConfigByFlagSets("bilal23@codigo.com", Arrays.asList("set"), properties).get(test).treatment());
 
         ArgumentCaptor<List> impressionCaptor = ArgumentCaptor.forClass(List.class);
-        verify(impressionsManager, times(16)).track(impressionCaptor.capture());
+        verify(impressionsManager, times(24)).track(impressionCaptor.capture());
         assertNotNull(impressionCaptor.getValue());
 
         DecoratedImpression impression = (DecoratedImpression) impressionCaptor.getAllValues().get(0).get(0);
         assertEquals("pato@codigo.com", impression.impression().key());
         assertEquals("{\"prop2\":\"val2\",\"prop1\":\"val1\"}", impression.impression().properties());
 
-        for (int i=1; i<=15; i++) {
+        for (int i=1; i<=23; i++) {
             impression = (DecoratedImpression) impressionCaptor.getAllValues().get(i).get(0);
             assertEquals("bilal" + i + "@codigo.com", impression.impression().key());
             assertEquals("{\"prop2\":\"val2\",\"prop1\":\"val1\"}", impression.impression().properties());

testing/src/main/java/io/split/client/testing/SplitClientForTest.java

@@ -5,11 +5,9 @@
 import io.split.client.api.SplitResult;
 import io.split.client.dtos.EvaluationOptions;
 import io.split.grammar.Treatments;
-import io.split.telemetry.domain.enums.MethodEnum;
 
 import java.util.*;
 import java.util.concurrent.TimeoutException;
-import java.util.stream.Collectors;
 
 public class SplitClientForTest implements SplitClient {
     private Map<String, String> _tests;