Merge pull request #470 from splitio/SDKS-7889

[SDKS-7889] Add YML in FileTypeEnum

Author: nmayorsplit

CHANGES.txt

@@ -1,5 +1,6 @@
 4.11.0 (Jan 9, 2024)
 - Added impressionsListener method in the IntegrationConfig builder to set Sync or Async Listener execution.
+- Fixed localhost to read files with yml ending.
 
 4.10.2 (Dec 1, 2023)
 - Added getTreatmentsByFlagSets without attributes.

client/pom.xml

@@ -5,7 +5,7 @@
     <parent>
         <groupId>io.split.client</groupId>
         <artifactId>java-client-parent</artifactId>
-        <version>4.10.2</version>
+        <version>4.11.0</version>
     </parent>
     <artifactId>java-client</artifactId>
     <packaging>jar</packaging>

client/src/main/java/io/split/client/SplitFactoryImpl.java

@@ -674,6 +674,7 @@ private SplitChangeFetcher createSplitChangeFetcher(SplitClientConfig splitClien
                 case JSON:
                     return new JsonLocalhostSplitChangeFetcher(inputStreamProvider);
                 case YAML:
+                case YML:
                     return new YamlLocalhostSplitChangeFetcher(inputStreamProvider);
                 default:
                     _log.warn(LEGACY_LOG_MESSAGE);

client/src/main/java/io/split/client/utils/FileTypeEnum.java

@@ -3,5 +3,6 @@
 public enum FileTypeEnum {
     LEGACY,
     YAML,
+    YML,
     JSON
 }

client/src/test/java/io/split/client/LocalhostSplitFactoryYamlCompactSampleTest.java

@@ -42,4 +42,29 @@ public void works() throws IOException, URISyntaxException {
         assertThat(client.getTreatmentWithConfig("user_e", "split_2").treatment(), is(equalTo("off")));
         assertThat(client.getTreatmentWithConfig("user_e", "split_2").config(), is(equalTo("{ \"size\" : 55 }")));
     }
+
+    @Test
+    public void worksYML() throws IOException, URISyntaxException {
+
+        String file = getClass().getClassLoader().getResource("split_compact.yml").getFile();
+
+        SplitClientConfig config = SplitClientConfig.builder().splitFile(file).build();
+        SplitFactory splitFactory = SplitFactoryBuilder.build("localhost", config);
+        SplitClient client = splitFactory.client();
+
+        assertThat(client.getTreatment(null, "foo"), is(equalTo(Treatments.CONTROL)));
+        assertThat(client.getTreatment("user_c", "foo"), is(equalTo(Treatments.CONTROL)));
+
+        assertThat(client.getTreatment("user_c", "split_1"), is(equalTo("off")));
+        assertThat(client.getTreatmentWithConfig("user_c", "split_1").treatment(), is(equalTo("off")));
+        assertThat(client.getTreatmentWithConfig("user_c", "split_1").config(), is(equalTo("{ \"size\" : 10 }")));
+
+        assertThat(client.getTreatment("user_d", "split_1"), is(equalTo("on")));
+        assertThat(client.getTreatmentWithConfig("user_d", "split_1").treatment(), is(equalTo("on")));
+        assertThat(client.getTreatmentWithConfig("user_d", "split_1").config(), is(nullValue()));
+
+        assertThat(client.getTreatment("user_e", "split_2"), is(equalTo("off")));
+        assertThat(client.getTreatmentWithConfig("user_e", "split_2").treatment(), is(equalTo("off")));
+        assertThat(client.getTreatmentWithConfig("user_e", "split_2").config(), is(equalTo("{ \"size\" : 55 }")));
+    }
 }

client/src/test/resources/split_compact.yml

@@ -0,0 +1,3 @@
+- split_1: {keys: user_c, treatment: 'off', config: '{ "size" : 10 }'}
+- split_1: {keys: user_d, treatment: 'on'}
+- split_2: {keys: user_e, treatment: 'off', config: '{ "size" : 55 }'}

pluggable-storage/pom.xml

@@ -6,7 +6,7 @@
     <parent>
         <artifactId>java-client-parent</artifactId>
         <groupId>io.split.client</groupId>
-        <version>4.10.2</version>
+        <version>4.11.0</version>
     </parent>
 
     <version>2.1.0</version>

pom.xml

@@ -4,7 +4,7 @@
     <modelVersion>4.0.0</modelVersion>
     <groupId>io.split.client</groupId>
     <artifactId>java-client-parent</artifactId>
-    <version>4.10.2</version>
+    <version>4.11.0</version>
     <dependencyManagement>
         <dependencies>
             <dependency>

redis-wrapper/pom.xml

@@ -6,7 +6,7 @@
     <parent>
         <artifactId>java-client-parent</artifactId>
         <groupId>io.split.client</groupId>
-        <version>4.10.2</version>
+        <version>4.11.0</version>
     </parent>
     <artifactId>redis-wrapper</artifactId>
     <version>3.1.0</version>

testing/pom.xml

@@ -5,7 +5,7 @@
     <parent>
         <groupId>io.split.client</groupId>
         <artifactId>java-client-parent</artifactId>
-        <version>4.10.2</version>
+        <version>4.11.0</version>
     </parent>
     <artifactId>java-client-testing</artifactId>
     <packaging>jar</packaging>