Fix to show log message 'not contain cached feature flag names' for consumer mode

Author: nmayorsplit

client/pom.xml

@@ -5,7 +5,7 @@
     <parent>
         <groupId>io.split.client</groupId>
         <artifactId>java-client-parent</artifactId>
-        <version>4.10.2-rc1</version>
+        <version>4.10.2-rc2</version>
     </parent>
     <artifactId>java-client</artifactId>
     <packaging>jar</packaging>

client/src/main/java/io/split/client/SplitClientImpl.java

@@ -414,8 +414,7 @@ private Map<String, SplitResult> getTreatmentsBySetsWithConfigInternal(String ma
         List<String> featureFlagNames = new ArrayList<>();
         try {
             checkSDKReady(methodEnum);
-            featureFlagNames = getAllFlags(cleanFlagSets);
-            Map<String, SplitResult> result = validateBeforeEvaluate(featureFlagNames, matchingKey, methodEnum,bucketingKey);
+            Map<String, SplitResult> result = validateBeforeEvaluateByFlagSets(matchingKey, methodEnum,bucketingKey);
             if(result != null) {
                 return result;
             }
@@ -457,6 +456,20 @@ private Map<String, SplitResult> processEvaluatorResult(Map<String, EvaluatorImp
         return result;
     }
 
+    private Map<String, SplitResult> validateBeforeEvaluateByFlagSets(String matchingKey, MethodEnum methodEnum,
+                                                            String bucketingKey) {
+        if (_container.isDestroyed()) {
+            _log.error(CLIENT_DESTROY);
+            return new HashMap<>();
+        }
+        if (!KeyValidator.isValid(matchingKey, "matchingKey", _config.maxStringLength(), methodEnum.getMethod())) {
+            return new HashMap<>();
+        }
+        if (!KeyValidator.bucketingKeyIsValid(bucketingKey, _config.maxStringLength(), methodEnum.getMethod())) {
+            return new HashMap<>();
+        }
+        return null;
+    }
     private Map<String, SplitResult> validateBeforeEvaluate(List<String> featureFlagNames, String matchingKey, MethodEnum methodEnum,
                                                             String bucketingKey) {
         if (_container.isDestroyed()) {

client/src/main/java/io/split/engine/evaluator/EvaluatorImp.java

@@ -63,7 +63,7 @@ private List<String> getFeatureFlagNamesByFlagSets(List<String> flagSets) {
         Map<String, HashSet<String>> namesByFlagSets = _splitCacheConsumer.getNamesByFlagSets(flagSets);
         for (String set: flagSets) {
             HashSet<String> flags = namesByFlagSets.get(set);
-            if (flags == null) {
+            if (flags == null || flags.isEmpty()) {
                 _log.warn(String.format("You passed %s Flag Set that does not contain cached feature flag names, please double check " +
                         "what Flag Sets are in use in the Split user interface.", set));
                 continue;

client/src/test/java/io/split/engine/evaluator/EvaluatorTest.java

@@ -153,9 +153,10 @@ public void evaluateWithWhitelistConditionReturnTreatment() {
     @Test
     public void evaluateWithSets() {
         ParsedSplit split = ParsedSplit.createParsedSplitForTests(SPLIT_NAME, 0, false, DEFAULT_TREATMENT_VALUE, _conditions, TRAFFIC_TYPE_VALUE, CHANGE_NUMBER, 2, new HashSet<>(Arrays.asList("set1", "set2")));
-        List<String> sets = new ArrayList<>(Arrays.asList("set1"));
+        List<String> sets = new ArrayList<>(Arrays.asList("set1", "empty_set"));
         Map<String, HashSet<String>> flagSets = new HashMap<>();
         flagSets.put("set1", new HashSet<>(Arrays.asList(SPLIT_NAME)));
+        flagSets.put("empty_set", null);
         Mockito.when(_splitCacheConsumer.getNamesByFlagSets(sets)).thenReturn(flagSets);
         Map<String, ParsedSplit> parsedSplits = new HashMap<>();
         parsedSplits.put(SPLIT_NAME, split);

pluggable-storage/pom.xml

@@ -6,7 +6,7 @@
     <parent>
         <artifactId>java-client-parent</artifactId>
         <groupId>io.split.client</groupId>
-        <version>4.10.2-rc1</version>
+        <version>4.10.2-rc2</version>
     </parent>
 
     <version>2.1.0</version>

pom.xml

@@ -4,7 +4,7 @@
     <modelVersion>4.0.0</modelVersion>
     <groupId>io.split.client</groupId>
     <artifactId>java-client-parent</artifactId>
-    <version>4.10.2-rc1</version>
+    <version>4.10.2-rc2</version>
     <dependencyManagement>
         <dependencies>
             <dependency>

redis-wrapper/pom.xml

@@ -6,7 +6,7 @@
     <parent>
         <artifactId>java-client-parent</artifactId>
         <groupId>io.split.client</groupId>
-        <version>4.10.2-rc1</version>
+        <version>4.10.2-rc2</version>
     </parent>
     <artifactId>redis-wrapper</artifactId>
     <version>3.1.0</version>

testing/pom.xml

@@ -5,7 +5,7 @@
     <parent>
         <groupId>io.split.client</groupId>
         <artifactId>java-client-parent</artifactId>
-        <version>4.10.2-rc1</version>
+        <version>4.10.2-rc2</version>
     </parent>
     <artifactId>java-client-testing</artifactId>
     <packaging>jar</packaging>