Skip to content

Commit dc30d42

Browse files
author
Bilal Al
committed
polish
1 parent ab2fb7f commit dc30d42

File tree

5 files changed

+29
-30
lines changed

5 files changed

+29
-30
lines changed

client/src/main/java/io/split/engine/experiments/SplitParser.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import io.split.engine.matchers.GreaterThanOrEqualToMatcher;
2020
import io.split.engine.matchers.LessThanOrEqualToMatcher;
2121
import io.split.engine.matchers.UserDefinedSegmentMatcher;
22-
import io.split.engine.matchers.EqualToMatcherSemver;
22+
import io.split.engine.matchers.EqualToSemverMatcher;
2323
import io.split.engine.matchers.collections.ContainsAllOfSetMatcher;
2424
import io.split.engine.matchers.collections.ContainsAnyOfSetMatcher;
2525
import io.split.engine.matchers.collections.EqualToSetMatcher;
@@ -198,7 +198,7 @@ private AttributeMatcher toMatcher(Matcher matcher) {
198198
break;
199199
case EQUAL_TO_SEMVER:
200200
checkNotNull(matcher.stringMatcherData);
201-
delegate = new EqualToMatcherSemver(matcher.stringMatcherData);
201+
delegate = new EqualToSemverMatcher(matcher.stringMatcherData);
202202
break;
203203
case GREATER_THAN_OR_EQUAL_TO_SEMVER:
204204
checkNotNull(matcher.stringMatcherData);

client/src/main/java/io/split/engine/matchers/EqualToMatcherSemver.java renamed to client/src/main/java/io/split/engine/matchers/EqualToSemverMatcher.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@
44

55
import java.util.Map;
66

7-
public class EqualToMatcherSemver implements Matcher {
7+
public class EqualToSemverMatcher implements Matcher {
88

99
private final Semver _semVer;
1010

11-
public EqualToMatcherSemver(String semVer) {
11+
public EqualToSemverMatcher(String semVer) {
1212
_semVer = Semver.build(semVer);
1313
}
1414

@@ -44,9 +44,9 @@ public int hashCode() {
4444
public boolean equals(Object obj) {
4545
if (obj == null) return false;
4646
if (this == obj) return true;
47-
if (!(obj instanceof EqualToMatcherSemver)) return false;
47+
if (!(obj instanceof EqualToSemverMatcher)) return false;
4848

49-
EqualToMatcherSemver other = (EqualToMatcherSemver) obj;
49+
EqualToSemverMatcher other = (EqualToSemverMatcher) obj;
5050

5151
return _semVer == other._semVer;
5252
}
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
package io.split.engine.matchers;
2+
3+
import org.junit.Test;
4+
5+
import static org.junit.Assert.assertTrue;
6+
7+
/**
8+
* Tests for EqualToSemverMatcher
9+
*/
10+
11+
public class EqualToSemverMatcherTest {
12+
13+
@Test
14+
public void works() {
15+
EqualToSemverMatcher equalToSemverMatcher = new EqualToSemverMatcher("2.1.8");
16+
17+
assertTrue( equalToSemverMatcher.match("2.1.8", null, null, null) == true);
18+
assertTrue( equalToSemverMatcher.match("2.1.9", null, null, null) == false);
19+
assertTrue( equalToSemverMatcher.match("2.1.8-rc", null, null, null) == false);
20+
assertTrue( equalToSemverMatcher.match("2.1.8+build", null, null, null) == false);
21+
}
22+
}

client/src/test/java/io/split/engine/matchers/EqualToSemverTest.java

Lines changed: 0 additions & 23 deletions
This file was deleted.

client/src/test/java/io/split/engine/matchers/GreaterThanOrEqualToSemverTest.java renamed to client/src/test/java/io/split/engine/matchers/GreaterThanOrEqualToSemverMatcherTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
* Tests for EqualToSemverMatcher
99
*/
1010

11-
public class GreaterThanOrEqualToSemverTest {
11+
public class GreaterThanOrEqualToSemverMatcherTest {
1212

1313
@Test
1414
public void works() {

0 commit comments

Comments
 (0)