Update to 1.0.2

Rename from nodejs to just js
Up-to-date with latest spec

Author: Josh Sirota

.eslintrc.json

@@ -2,4 +2,7 @@
 - First release. Up to date with spec 0.4.0, and @openfeature/nodejs-sdk v0.2.0
 1.0.1
 - Fixes issues with flag details and error codes in negative cases, adds unit tests
-- Up to date with spec 0.4.0 and @openfeature/nodejs-sdk v0.3.2
+- Up to date with spec 0.4.0 and @openfeature/nodejs-sdk v0.3.2
+1.0.2
+- Changes name from Node-specific implementation to generic JSON
+- Up to date with spec 0.4.0 and @openfeature/js-sdk 0.4.0

CHANGES.txt

@@ -11,12 +11,13 @@ This Provider is designed to allow the use of OpenFeature with Split, the platfo
 Below is a simple example that describes the instantiation of the Split Provider. Please see the [OpenFeature Documentation](https://docs.openfeature.dev/docs/reference/concepts/evaluation-api) for details on how to use the OpenFeature SDK.
 
 ```js
-const OpenFeature = require('@openfeature/nodejs-sdk').OpenFeature;
+const OpenFeature = require('@openfeature/js-sdk').OpenFeature;
 const SplitFactory = require('@splitsoftware/splitio').SplitFactory;
 const OpenFeatureSplitProvider = require('@splitsoftware/openfeature-nodejs-split-provider').OpenFeatureSplitProvider;
 
 splitClient = SplitFactory({core: {authorizationKey: 'localhost'}}).client();
-openFeature.setProvider(splitClient);
+provider = new OpenFeatureSplitProvider({splitClient});
+openFeature.setProvider(provider);
 ```
 
 ## Use of OpenFeature with Split

README.md

@@ -1,6 +1,6 @@
 {
-  "name": "@splitsoftware/openfeature-nodejs-split-provider",
-  "version": "1.0.1",
+  "name": "@splitsoftware/openfeature-js-split-provider",
+  "version": "1.0.2",
   "description": "Split OpenFeature Provider",
   "files": [
     "README.md",
@@ -27,75 +27,32 @@
     "node": ">=6"
   },
   "dependencies": {
-    "@openfeature/nodejs-sdk": "^0.3.2",
+    "@openfeature/js-sdk": "^0.4.0",
     "@splitsoftware/splitio": "^10.21.1"
   },
   "devDependencies": {
-    "@types/node-fetch": "^2.5.12",
     "copyfiles": "^2.4.1",
     "cross-env": "^7.0.3",
-    "csv-streamify": "4.0.0",
-    "eslint": "^8.0.1",
-    "eslint-plugin-compat": "^3.13.0",
-    "eslint-plugin-import": "^2.25.4",
-    "fetch-mock": "^9.11.0",
-    "karma": "^6.3.16",
-    "karma-chrome-launcher": "^3.1.0",
-    "karma-tap": "4.1.4",
-    "karma-webpack": "^5.0.0",
-    "lodash": "^4.17.21",
-    "node-polyfill-webpack-plugin": "^1.1.4",
-    "proxyquire": "^2.1.3",
-    "puppeteer": "^3.3.0",
-    "redis-dumpz": "0.1.12",
-    "redis-server": "1.2.2",
     "replace": "^1.2.1",
     "rimraf": "^3.0.2",
-    "sinon": "^9.2.4",
     "tap-min": "^2.0.0",
     "tape": "4.13.2",
     "tape-catch": "1.0.6",
-    "ts-loader": "^9.2.6",
     "ts-node": "^10.5.0",
-    "typescript": "4.4.4",
-    "webpack": "^5.53.0",
-    "webpack-cli": "^4.8.0",
-    "webpack-merge": "^5.8.0"
+    "typescript": "4.4.4"
   },
   "scripts": {
     "build-esm": "rimraf es && tsc -outDir es",
     "postbuild-esm": "cross-env NODE_ENV=es node scripts/copy.packages.json.js && ./scripts/build_esm_replace_imports.sh",
-    "build-umd:stats": "webpack --progress --env production --json > ./stats/stat_results.json",
     "build-cjs": "rimraf lib && tsc -outDir lib -m CommonJS",
     "postbuild-cjs": "cross-env NODE_ENV=cjs node scripts/copy.packages.json.js && ./scripts/build_cjs_replace_imports.sh",
-    "build-umd": "webpack --config webpack.dev.js --env branch=$BUILD_BRANCH --env commit_hash=$BUILD_COMMIT && webpack --config webpack.prod.js --env branch=$BUILD_BRANCH --env commit_hash=$BUILD_COMMIT && ./scripts/clean_umd_build.sh",
-    "build:npm": "rimraf lib es && npm run build-cjs && npm run build-esm",
-    "build": "rimraf lib umd es && npm run build-cjs && npm run build-esm && npm run build-umd",
-    "check": "npm run check:lint && npm run check:version",
-    "check:lint": "eslint src",
+    "build": "rimraf lib es && npm run build-cjs && npm run build-esm",
+    "check": "npm run check:version",
     "check:version": "cross-env NODE_ENV=test tape -r ./ts-node.register src/settings/__tests__/defaults.spec.js",
-    "test-browser-local": "cross-env NODE_ENV=test karma start karma/local.karma.conf.js",
-    "test-browser-e2e-local": "cross-env NODE_ENV=test karma start karma/e2e.local.karma.conf.js",
-    "test-browser": "npm run test-browser-unit && npm run test-browser-online && npm run test-browser-offline && npm run test-browser-destroy && npm run test-browser-errors && npm run test-browser-push && npm run test-browser-gaintegration",
-    "test-browser-unit": "cross-env NODE_ENV=test karma start karma/ci.karma.conf.js",
-    "test-browser-online": "cross-env NODE_ENV=test karma start karma/e2e.ci.karma.conf.js",
-    "test-browser-offline": "cross-env NODE_ENV=test karma start karma/offline.karma.conf.js",
-    "test-browser-destroy": "cross-env NODE_ENV=test karma start karma/destroy.ci.karma.conf.js",
-    "test-browser-errors": "cross-env NODE_ENV=test karma start karma/errors.ci.karma.conf.js",
-    "test-browser-gaintegration": "cross-env NODE_ENV=test karma start karma/gaintegration.ci.karma.conf.js",
-    "test-browser-push": "cross-env NODE_ENV=test karma start karma/push.ci.karma.conf.js",
-    "test-node": "npm run test-node-unit && npm run test-node-online && npm run test-node-redis && npm run test-node-offline && npm run test-node-destroy && npm run test-node-errors && npm run test-node-push",
-    "test-node-unit": "cross-env NODE_ENV=test tape -r ./ts-node.register \"src/*/**/__tests__/**/!(browser).spec.js\" | tap-min",
-    "test-node-online": "cross-env NODE_ENV=test tape -r ./ts-node.register src/__tests__/node.spec.js | tap-min",
-    "test-node-destroy": "cross-env NODE_ENV=test tape -r ./ts-node.register src/__tests__/destroy/node.spec.js | tap-min",
-    "test-node-errors": "cross-env NODE_ENV=test tape -r ./ts-node.register src/__tests__/errorCatching/node.spec.js | tap-min",
-    "test-node-offline": "cross-env NODE_ENV=test tape -r ./ts-node.register src/__tests__/offline/node.spec.js | tap-min",
-    "test-node-redis": "cross-env NODE_ENV=test tape -r ./ts-node.register src/__tests__/node_redis.spec.js | tap-min",
-    "test-node-push": "cross-env NODE_ENV=test tape -r ./ts-node.register src/__tests__/push/node.spec.js | tap-min",
     "pretest-ts-decls": "npm run build-esm && npm run build-cjs && npm link",
     "test-ts-decls": "./scripts/ts-tests.sh",
     "posttest-ts-decls": "npm unlink && npm install",
-    "test": "npm run test-node && npm run test-browser",
+    "test": "cross-env NODE_ENV=test tape -r ./ts-node.register src/__tests__/node.spec.js | tap-min",
     "publish:rc": "npm run check && npm run build && npm publish --tag canary",
     "publish:stable": "npm run check && npm run build && npm publish"
   },

package.json

@@ -1,4 +1,4 @@
-const OpenFeature = require('@openfeature/nodejs-sdk').OpenFeature;
+const OpenFeature = require('@openfeature/js-sdk').OpenFeature;
 const SplitFactory = require('@splitsoftware/splitio').SplitFactory;
 import { OpenFeatureSplitProvider } from '../..';
 
@@ -148,7 +148,7 @@ export default async function(assert) {
       authorizationKey: 'localhost'
     },
     features: './split.yaml',
-    debug: 'WARN'
+    debug: 'DEBUG'
   }).client();
 
   let provider = new OpenFeatureSplitProvider({splitClient});
@@ -158,7 +158,7 @@ export default async function(assert) {
   let evaluationContext = {
     targetingKey: 'key'
   };
-  client.context = evaluationContext;
+  client.setContext(evaluationContext);
 
   await useDefaultTest(client);
   await missingTargetingKeyTest(client);  

src/__tests__/split.yaml split.yamlsrc/__tests__/split.yaml renamed to split.yaml

@@ -1,12 +1,6 @@
-import { EvaluationContext, Provider, ResolutionDetails, ParseError, FlagNotFoundError, OpenFeatureError, StandardResolutionReasons } from '@openfeature/nodejs-sdk';
+import { EvaluationContext, Provider, ResolutionDetails, ParseError, FlagNotFoundError, JsonValue, OpenFeatureError, StandardResolutionReasons } from '@openfeature/js-sdk';
 import SplitIO from '@splitsoftware/splitio/types/splitio';
 
-/**
- * This simple provider implementation relies on storing all data as strings in the treatment value.
- *
- * It may be more idiomatic to only rely on that for the "isEnabled" calls,
- * and for all values store the data in teh associated "split config" JSON.
- */
 export interface SplitProviderOptions {
   splitClient: SplitIO.IClient;
 }
@@ -16,11 +10,6 @@ type Consumer = {
   attributes: SplitIO.Attributes;
 };
 
-/**
- * NOTE: This is an unofficial provider that was created for demonstration
- * purposes only. The playground environment will be updated to use official
- * providers once they're available.
- */
 export class OpenFeatureSplitProvider implements Provider {
   metadata = {
     name: 'split',
@@ -30,8 +19,6 @@ export class OpenFeatureSplitProvider implements Provider {
 
   constructor(options: SplitProviderOptions) {
     this.client = options.splitClient;
-    // we don't expose any init events at the moment (we might later) so for now, lets create a private
-    // promise to await into before we evaluate any flags.
     this.initialized = new Promise((resolve) => {
       this.client.on(this.client.Event.SDK_READY, () => {
         console.log(`${this.metadata.name} provider initialized`);
@@ -98,7 +85,7 @@ export class OpenFeatureSplitProvider implements Provider {
     return { ...details, value: this.parseValidNumber(details.value) };
   }
 
-  async resolveObjectEvaluation<U extends object>(
+  async resolveObjectEvaluation<U extends JsonValue>(
     flagKey: string,
     _: U,
     context: EvaluationContext
@@ -149,7 +136,7 @@ export class OpenFeatureSplitProvider implements Provider {
     return result;
   }
 
-  private parseValidJsonObject<T extends Object>(stringValue: string | undefined): T {
+  private parseValidJsonObject<T extends JsonValue>(stringValue: string | undefined): T {
     if (stringValue === undefined) {
       throw new ParseError(`Invalid 'undefined' JSON value.`);
     }