Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Commit 0441787

Browse files
committed
gh-1243 GitProperties shown should be for the SCDF Implementation
1 parent 2193d11 commit 0441787

File tree

4 files changed

+10
-16
lines changed
  • spring-cloud-dataflow-server-core
  • spring-cloud-dataflow-server-local
  • spring-cloud-starter-dataflow-server-local

4 files changed

+10
-16
lines changed

spring-cloud-dataflow-server-core/pom.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -161,11 +161,5 @@
161161
</includes>
162162
</resource>
163163
</resources>
164-
<plugins>
165-
<plugin>
166-
<groupId>pl.project13.maven</groupId>
167-
<artifactId>git-commit-id-plugin</artifactId>
168-
</plugin>
169-
</plugins>
170164
</build>
171165
</project>

spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/controller/AboutController.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -110,10 +110,12 @@ public AboutResource getAboutResource() {
110110
versionInfo.setShell(new Dependency("Spring Cloud Data Flow Shell",versionInfoProperties.getDataflowShellVersion()));
111111
versionInfo.setDashboard(new Dependency("Spring Cloud Dataflow UI", versionInfoProperties.getDataflowDashboardVersion()));
112112

113-
versionInfo.setBranch(this.gitProperties.getBranch());
114-
versionInfo.setCommitId(this.gitProperties.getCommitId());
115-
versionInfo.setShortCommitId(this.gitProperties.getShortCommitId());
116-
versionInfo.setCommitTime(this.gitProperties.getCommitTime());
113+
if (this.gitProperties != null) {
114+
versionInfo.setBranch(this.gitProperties.getBranch());
115+
versionInfo.setCommitId(this.gitProperties.getCommitId());
116+
versionInfo.setShortCommitId(this.gitProperties.getShortCommitId());
117+
versionInfo.setCommitTime(this.gitProperties.getCommitTime());
118+
}
117119

118120
aboutResource.setFeatureInfo(featureInfo);
119121
aboutResource.setVersionInfo(versionInfo);

spring-cloud-dataflow-server-local/pom.xml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,6 @@
123123
</plugin>
124124
<plugin>
125125
<artifactId>maven-javadoc-plugin</artifactId>
126-
<version>2.10.4</version>
127126
<executions>
128127
<execution>
129128
<id>javadoc</id>
@@ -139,7 +138,6 @@
139138
</plugin>
140139
<plugin>
141140
<artifactId>maven-source-plugin</artifactId>
142-
<version>2.4</version>
143141
<executions>
144142
<execution>
145143
<id>attach-sources</id>
@@ -150,6 +148,10 @@
150148
</execution>
151149
</executions>
152150
</plugin>
151+
<plugin>
152+
<groupId>pl.project13.maven</groupId>
153+
<artifactId>git-commit-id-plugin</artifactId>
154+
</plugin>
153155
</plugins>
154156
</build>
155157

spring-cloud-starter-dataflow-server-local/pom.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,6 @@
5050
</resource>
5151
</resources>
5252
<plugins>
53-
<plugin>
54-
<groupId>pl.project13.maven</groupId>
55-
<artifactId>git-commit-id-plugin</artifactId>
56-
</plugin>
5753
<plugin>
5854
<groupId>org.apache.maven.plugins</groupId>
5955
<artifactId>maven-jar-plugin</artifactId>

0 commit comments

Comments
 (0)