Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Commit 5e51f10

Browse files
committed
Revert "Added AppBootSchemaVersion tests and updated controller."
This reverts commit 693423f.
1 parent 91ec899 commit 5e51f10

File tree

34 files changed

+146
-536
lines changed

34 files changed

+146
-536
lines changed

.settings.xml

Lines changed: 11 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,6 @@
2020
<activeByDefault>true</activeByDefault>
2121
</activation>
2222
<repositories>
23-
<repository>
24-
<id>maven-central</id>
25-
<name>Maven Central</name>
26-
<url>https://repo.maven.apache.org/maven2</url>
27-
<snapshots>
28-
<enabled>false</enabled>
29-
</snapshots>
30-
</repository>
3123
<repository>
3224
<id>spring-snapshots</id>
3325
<name>Spring Snapshots</name>
@@ -45,23 +37,15 @@
4537
</snapshots>
4638
</repository>
4739
<repository>
48-
<id>spring-releases</id>
49-
<name>Spring Releases</name>
50-
<url>https://repo.spring.io/libs-release</url>
51-
<snapshots>
52-
<enabled>true</enabled>
53-
</snapshots>
54-
</repository>
55-
</repositories>
56-
<pluginRepositories>
57-
<pluginRepository>
5840
<id>maven-central</id>
5941
<name>Maven Central</name>
6042
<url>https://repo.maven.apache.org/maven2</url>
6143
<snapshots>
6244
<enabled>false</enabled>
6345
</snapshots>
64-
</pluginRepository>
46+
</repository>
47+
</repositories>
48+
<pluginRepositories>
6549
<pluginRepository>
6650
<id>spring-snapshots</id>
6751
<name>Spring Snapshots</name>
@@ -78,6 +62,14 @@
7862
<enabled>false</enabled>
7963
</snapshots>
8064
</pluginRepository>
65+
<pluginRepository>
66+
<id>maven-central</id>
67+
<name>Maven Central</name>
68+
<url>https://repo.maven.apache.org/maven2</url>
69+
<snapshots>
70+
<enabled>false</enabled>
71+
</snapshots>
72+
</pluginRepository>
8173
</pluginRepositories>
8274
<distributionManagement>
8375
<repository>

spring-cloud-dataflow-core/pom.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@
3232
<groupId>com.fasterxml.jackson.core</groupId>
3333
<artifactId>jackson-annotations</artifactId>
3434
</dependency>
35-
<dependency>
36-
<groupId>com.fasterxml.jackson.core</groupId>
37-
<artifactId>jackson-databind</artifactId>
38-
</dependency>
3935
<dependency>
4036
<groupId>org.springframework.data</groupId>
4137
<artifactId>spring-data-keyvalue</artifactId>

spring-cloud-dataflow-core/src/main/java/org/springframework/cloud/dataflow/core/AppBootSchemaVersion.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,6 @@
1818

1919
import java.util.Arrays;
2020

21-
import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
22-
import com.fasterxml.jackson.databind.annotation.JsonSerialize;
23-
2421
/**
2522
* Defines the possible schema versions that currently map to Spring {@code "Boot"}. A registered application can only support one schema version.
2623
*
@@ -29,8 +26,6 @@
2926
* @author Chris Bono
3027
* @author Corneil du Plessis
3128
*/
32-
@JsonSerialize(using = AppBootSchemaVersionSerializer.class)
33-
@JsonDeserialize(using = AppBootSchemaVersionDeserializer.class)
3429
public enum AppBootSchemaVersion {
3530

3631
BOOT2("2"),

spring-cloud-dataflow-core/src/main/java/org/springframework/cloud/dataflow/core/AppBootSchemaVersionDeserializer.java

Lines changed: 0 additions & 44 deletions
This file was deleted.

spring-cloud-dataflow-core/src/main/java/org/springframework/cloud/dataflow/core/AppBootSchemaVersionSerializer.java

Lines changed: 0 additions & 46 deletions
This file was deleted.

spring-cloud-dataflow-core/src/main/java/org/springframework/cloud/dataflow/core/AppRegistration.java

Lines changed: 1 addition & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@
2121
import java.util.Objects;
2222

2323
import javax.persistence.Entity;
24-
import javax.persistence.EnumType;
25-
import javax.persistence.Enumerated;
2624
import javax.persistence.Lob;
2725
import javax.persistence.Table;
2826
import javax.persistence.Transient;
@@ -76,12 +74,6 @@ public class AppRegistration extends AbstractEntity implements Comparable<AppReg
7674
*/
7775
private Boolean defaultVersion = false;
7876

79-
/**
80-
* Boot version to identify Task / Batch Schema.
81-
*/
82-
@Enumerated(EnumType.STRING)
83-
private AppBootSchemaVersion bootVersion;
84-
8577
@Transient
8678
private HashSet<String> versions;
8779

@@ -132,21 +124,6 @@ public AppRegistration(String name, ApplicationType type, String version, URI ur
132124
this.metadataUri = metadataUri;
133125
}
134126

135-
/**
136-
* Construct an {@code AppRegistration} object.
137-
*
138-
* @param name app name
139-
* @param type app type
140-
* @param version app version
141-
* @param uri URI for the app resource
142-
* @param metadataUri URI for the app metadata resource
143-
* @param schemaTargetName The name of the SchemaVersionTarget. Null means the default entry.
144-
*/
145-
public AppRegistration(String name, ApplicationType type, String version, URI uri, URI metadataUri, AppBootSchemaVersion bootVersion) {
146-
this(name,type,version,uri,metadataUri);
147-
this.bootVersion = bootVersion;
148-
}
149-
150127
/**
151128
* @return the name of the app
152129
*/
@@ -199,14 +176,6 @@ public void setMetadataUri(URI metadataUri) {
199176
this.metadataUri = metadataUri;
200177
}
201178

202-
public AppBootSchemaVersion getBootVersion() {
203-
return bootVersion == null ? AppBootSchemaVersion.defaultVersion() : bootVersion;
204-
}
205-
206-
public void setBootVersion(AppBootSchemaVersion bootVersion) {
207-
this.bootVersion = bootVersion;
208-
}
209-
210179
public Boolean isDefaultVersion() {
211180
return this.defaultVersion;
212181
}
@@ -227,8 +196,7 @@ public void setVersions(HashSet<String> versions) {
227196
public String toString() {
228197
return "AppRegistration{" + "name='" + this.getName() + '\'' + ", type='" + this.getType()
229198
+ '\'' + ", version='" + this.getVersion() + '\'' + ", uri=" + this.getUri()
230-
+ ", metadataUri=" + this.getMetadataUri() +
231-
", bootVersion=\'" + this.getBootVersion().getBootVersion() + '}';
199+
+ ", metadataUri=" + this.getMetadataUri() + '}';
232200
}
233201

234202
@Override

spring-cloud-dataflow-registry/src/main/java/org/springframework/cloud/dataflow/registry/service/AppRegistryService.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import java.net.URI;
1919
import java.util.List;
2020

21-
import org.springframework.cloud.dataflow.core.AppBootSchemaVersion;
2221
import org.springframework.cloud.dataflow.core.AppRegistration;
2322
import org.springframework.cloud.dataflow.core.ApplicationType;
2423
import org.springframework.cloud.dataflow.registry.support.NoSuchAppRegistrationException;
@@ -70,10 +69,9 @@ public interface AppRegistryService {
7069
* @param version Version of the AppRegistration to save
7170
* @param uri Resource uri of the AppRegistration to save
7271
* @param metadataUri metadata of the AppRegistration to save
73-
* @param bootVersion Spring Boot schema version indicating Task 2, Batch 4 or Task 3, Batch 5
7472
* @return the saved AppRegistration
7573
*/
76-
AppRegistration save(String name, ApplicationType type, String version, URI uri, URI metadataUri, AppBootSchemaVersion bootVersion);
74+
AppRegistration save(String name, ApplicationType type, String version, URI uri, URI metadataUri);
7775

7876
/**
7977
* Deletes an {@link AppRegistration}. If the {@link AppRegistration} does not exist, a

0 commit comments

Comments
 (0)