Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Commit ff59fad

Browse files
jvalkealilayaperumalg
authored andcommitted
Skip importing missing versions
- Modify URI_REGISTRY migration so that now we just log a warning if version cannot be calculated using a same way dataflow already expects during a deployment. As in this case version in a data item is left empty, only use those items where version is defined. - Fixes #2933
1 parent d770cea commit ff59fad

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/db/migration/AbstractMigrateUriRegistrySqlCommand.java

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@
1616
package org.springframework.cloud.dataflow.server.db.migration;
1717

1818
import java.sql.Connection;
19-
import java.util.ArrayList;
2019
import java.util.Collection;
2120
import java.util.HashMap;
2221
import java.util.HashSet;
2322
import java.util.List;
2423
import java.util.Map;
24+
import java.util.stream.Collectors;
2525

2626
import org.slf4j.Logger;
2727
import org.slf4j.LoggerFactory;
@@ -31,6 +31,7 @@
3131
import org.springframework.cloud.deployer.resource.maven.MavenProperties;
3232
import org.springframework.cloud.deployer.resource.support.DelegatingResourceLoader;
3333
import org.springframework.jdbc.core.JdbcTemplate;
34+
import org.springframework.util.ObjectUtils;
3435

3536
/**
3637
* Base implementation for a {@link SqlCommand} copying data from
@@ -122,7 +123,12 @@ protected List<AppRegistrationMigrationData> createAppRegistrationMigrationData(
122123
armd.setName(split[1]);
123124
armd.setType(ApplicationType.valueOf(split[0]).ordinal());
124125
armd.setUri(uri);
125-
armd.setVersion(arc.getResourceVersion(arc.getResource(uri)));
126+
try {
127+
armd.setVersion(arc.getResourceVersion(arc.getResource(uri)));
128+
}
129+
catch (Exception e) {
130+
logger.warn("Skipping URI_REGISTRY item {} migration with URI {} due to lack of version number in the URI", name, uri, e);
131+
}
126132
}
127133
else {
128134
// we got *.*.metadata first
@@ -135,8 +141,8 @@ protected List<AppRegistrationMigrationData> createAppRegistrationMigrationData(
135141
data.put(key, armd);
136142
}
137143
});
138-
139-
return new ArrayList<>(data.values());
144+
// if we skipper version errors, filter those out
145+
return data.values().stream().filter(i -> !ObjectUtils.isEmpty(i.getVersion())).collect(Collectors.toList());
140146
}
141147

142148
/**

0 commit comments

Comments
 (0)