Use shared instance of DefaultParameterNameDiscoverer.

Author: christophstrobl

src/main/java/org/springframework/data/mapping/model/InstanceCreatorMetadataDiscoverer.java

@@ -51,8 +51,6 @@
  */
 class InstanceCreatorMetadataDiscoverer {
 
-	private static final ParameterNameDiscoverer PARAMETER_NAME_DISCOVERER = new DefaultParameterNameDiscoverer();
-
 	/**
 	 * Discover an entity creator
 	 *
@@ -146,7 +144,7 @@ private static <T, P extends PersistentProperty<P>> FactoryMethod<Object, P> get
 		Annotation[][] parameterAnnotations = method.getParameterAnnotations();
 		List<TypeInformation<?>> types = entity.getTypeInformation().getParameterTypes(method);
 
-		String[] parameterNames = PARAMETER_NAME_DISCOVERER.getParameterNames(method);
+		String[] parameterNames = DefaultParameterNameDiscoverer.getSharedInstance().getParameterNames(method);
 
 		for (int i = 0; i < parameters.length; i++) {
 

src/main/java/org/springframework/data/mapping/model/PreferredConstructorDiscoverer.java

@@ -213,8 +213,6 @@ <T, P extends PersistentProperty<P>> PreferredConstructor<T, P> discover(TypeInf
 			}
 		};
 
-		private static final ParameterNameDiscoverer PARAMETER_NAME_DISCOVERER = new DefaultParameterNameDiscoverer();
-
 		/**
 		 * Find the appropriate discoverer for {@code type}.
 		 *
@@ -249,7 +247,7 @@ private static <T, P extends PersistentProperty<P>> PreferredConstructor<T, P> b
 			}
 
 			List<TypeInformation<?>> parameterTypes = typeInformation.getParameterTypes(constructor);
-			String[] parameterNames = PARAMETER_NAME_DISCOVERER.getParameterNames(constructor);
+			String[] parameterNames = DefaultParameterNameDiscoverer.getSharedInstance().getParameterNames(constructor);
 
 			Parameter<Object, P>[] parameters = new Parameter[parameterTypes.size()];
 			Annotation[][] parameterAnnotations = constructor.getParameterAnnotations();

src/main/java/org/springframework/data/repository/aot/generate/AotRepositoryBeanDefinitionPropertiesDecorator.java

@@ -102,7 +102,7 @@ public CodeBlock decorate() {
 			for (int i = 0; i < it.getParameterCount(); i++) {
 
 				MethodParameter parameter = new MethodParameter(it, i);
-				parameter.initParameterNameDiscovery(new DefaultParameterNameDiscoverer());
+				parameter.initParameterNameDiscovery(DefaultParameterNameDiscoverer.getSharedInstance());
 
 				callbackMethod.addParameter(parameter.getParameterType(), parameter.getParameterName());
 			}

src/main/java/org/springframework/data/repository/aot/generate/MethodMetadata.java

@@ -63,9 +63,8 @@ class MethodMetadata {
 		Map<String, MethodParameter> methodParameters = new LinkedHashMap<>();
 
 		ResolvableType repositoryInterface = ResolvableType.forClass(repositoryInformation.getRepositoryInterface());
-		ParameterNameDiscoverer nameDiscoverer = new DefaultParameterNameDiscoverer();
 
-		initializeMethodArguments(method, nameDiscoverer, repositoryInterface, methodArguments, methodParameters);
+		initializeMethodArguments(method, DefaultParameterNameDiscoverer.getSharedInstance(), repositoryInterface, methodArguments, methodParameters);
 
 		this.methodArguments = Collections.unmodifiableMap(methodArguments);
 		this.methodParameters = Collections.unmodifiableMap(methodParameters);

src/main/java/org/springframework/data/repository/query/Parameters.java

@@ -23,9 +23,7 @@
 import java.util.List;
 import java.util.function.Function;
 
-import org.springframework.core.DefaultParameterNameDiscoverer;
 import org.springframework.core.MethodParameter;
-import org.springframework.core.ParameterNameDiscoverer;
 import org.springframework.core.ResolvableType;
 import org.springframework.data.domain.Limit;
 import org.springframework.data.domain.Pageable;
@@ -56,8 +54,6 @@ public abstract class Parameters<S extends Parameters<S, T>, T extends Parameter
 			"Either use @%s on all parameters except %s and %s typed once, or none at all", Param.class.getSimpleName(),
 			Pageable.class.getSimpleName(), Sort.class.getSimpleName());
 
-	private static final ParameterNameDiscoverer PARAMETER_NAME_DISCOVERER = new DefaultParameterNameDiscoverer();
-
 	private final int vectorIndex;
 	private final int scoreIndex;
 	private final int scoreRangeIndex;
@@ -102,8 +98,6 @@ protected Parameters(ParametersSource parametersSource, Function<MethodParameter
 			MethodParameter methodParameter = new MethodParameter(method, i)
 					.withContainingClass(parametersSource.getContainingClass());
 
-			methodParameter.initParameterNameDiscovery(PARAMETER_NAME_DISCOVERER);
-
 			T parameter = parameterFactory.apply(methodParameter);
 
 			if (parameter.isSpecialParameter() && parameter.isNamedParameter()) {

src/main/java/org/springframework/data/repository/support/MethodParameters.java

@@ -39,7 +39,6 @@
  */
 class MethodParameters {
 
-	private final static ParameterNameDiscoverer discoverer = new DefaultParameterNameDiscoverer();
 	private final List<MethodParameter> parameters;
 
 	/**
@@ -66,7 +65,7 @@ public MethodParameters(Method method, Optional<AnnotationAttribute> namingAnnot
 		for (int i = 0; i < method.getParameterCount(); i++) {
 
 			MethodParameter parameter = new AnnotationNamingMethodParameter(method, i, namingAnnotation);
-			parameter.initParameterNameDiscovery(discoverer);
+			parameter.initParameterNameDiscovery(DefaultParameterNameDiscoverer.getSharedInstance());
 			parameters.add(parameter);
 		}
 	}

src/main/java/org/springframework/data/util/NullnessMethodInvocationValidator.java

@@ -52,7 +52,6 @@
  */
 public class NullnessMethodInvocationValidator implements MethodInterceptor {
 
-	private final ParameterNameDiscoverer discoverer = new DefaultParameterNameDiscoverer();
 	private final Map<Method, MethodNullness> nullabilityCache = new ConcurrentHashMap<>(16);
 
 	/**
@@ -79,7 +78,7 @@ public static boolean supports(Class<?> type) {
 
 		if (nullness == null) {
 
-			nullness = MethodNullness.of(method, discoverer);
+			nullness = MethodNullness.of(method, DefaultParameterNameDiscoverer.getSharedInstance());
 			nullabilityCache.put(method, nullness);
 		}