Polishing.

This commit performs the following polishing changes:

- remove manual not null check in `TrimOptions.<init>` as it's already `@NullMarked`
- annotate `RedisStreamCommands.XDelOptions` with `@NullMarked`
- remove usage of `var` in main code
- use since `4.1` instead of `4.0`
- rename pendingReferences to deletionPolicy
- use ParameterizedTest for StreamConvertersUnitTest
- simplify test to not verify things it does not do
- fix formatting in various classes
- minor tweak to javadocs
- inline converters in Lettuce StreamConverters

Original pull request #3247
See #3232

Signed-off-by: Chris Bono <chris.bono@broadcom.com>

Author: onobc

src/main/java/org/springframework/data/redis/connection/ReactiveStreamCommands.java

@@ -312,7 +312,7 @@ public AddStreamRecord approximateTrimming(boolean approximateTrimming) {
 		 *
 		 * @param options the {@link XAddOptions} to apply. Must not be {@literal null}.
 		 * @return a new {@link AddStreamRecord} with the specified options applied.
-		 * @since 4.0
+		 * @since 4.1
 		 */
 		public AddStreamRecord withOptions(XAddOptions options) {
 			return new AddStreamRecord(record, options);
@@ -379,7 +379,7 @@ public boolean hasMinId() {
 
 		/**
 		 * @return the XAddOptions options.
-		 * @since 4.0
+		 * @since 4.1
 		 */
 		public XAddOptions getOptions() {
 			return options;
@@ -618,7 +618,7 @@ public List<RecordId> getRecordIds() {
 	 * {@code XDELEX} command parameters.
 	 *
 	 * @author Viktoriya Kutsarova
-	 * @since 4.0
+	 * @since 4.1
 	 * @see <a href="https://redis.io/commands/xdelex">Redis Documentation: XDELEX</a>
 	 */
 	class DeleteExCommand extends KeyCommand {
@@ -702,7 +702,7 @@ public XDelOptions getOptions() {
 	 * {@code XACKDEL} command parameters.
 	 *
 	 * @author Viktoriya Kutsarova
-	 * @since 4.0
+	 * @since 4.1
 	 * @see <a href="https://redis.io/commands/xackdel">Redis Documentation: XACKDEL</a>
 	 */
 	class AcknowledgeDeleteCommand extends KeyCommand {
@@ -857,7 +857,7 @@ default Mono<Long> xDel(ByteBuffer key, RecordId... recordIds) {
 	 * @param recordIds stream record Id's.
 	 * @return {@link Flux} emitting {@link StreamEntryDeletionResult} for each ID.
 	 * @see <a href="https://redis.io/commands/xdelex">Redis Documentation: XDELEX</a>
-	 * @since 4.0
+	 * @since 4.1
 	 */
 	default Flux<StreamEntryDeletionResult> xDelEx(ByteBuffer key,
 			XDelOptions options, String... recordIds) {
@@ -881,7 +881,7 @@ default Flux<StreamEntryDeletionResult> xDelEx(ByteBuffer key,
 	 * @param recordIds stream record Id's.
 	 * @return {@link Flux} emitting {@link StreamEntryDeletionResult} for each ID.
 	 * @see <a href="https://redis.io/commands/xdelex">Redis Documentation: XDELEX</a>
-	 * @since 4.0
+	 * @since 4.1
 	 */
 	default Flux<StreamEntryDeletionResult> xDelEx(ByteBuffer key,
 			XDelOptions options, RecordId... recordIds) {
@@ -900,7 +900,7 @@ default Flux<StreamEntryDeletionResult> xDelEx(ByteBuffer key,
 	 * @param commands must not be {@literal null}.
 	 * @return {@link Flux} emitting a list of {@link StreamEntryDeletionResult} per {@link DeleteExCommand}.
 	 * @see <a href="https://redis.io/commands/xdelex">Redis Documentation: XDELEX</a>
-	 * @since 4.0
+	 * @since 4.1
 	 */
 	Flux<CommandResponse<DeleteExCommand, List<StreamEntryDeletionResult>>> xDelEx(
 			Publisher<DeleteExCommand> commands);
@@ -917,7 +917,7 @@ Flux<CommandResponse<DeleteExCommand, List<StreamEntryDeletionResult>>> xDelEx(
 	 * @param recordIds stream record Id's.
 	 * @return {@link Flux} emitting {@link StreamEntryDeletionResult} for each ID.
 	 * @see <a href="https://redis.io/commands/xackdel">Redis Documentation: XACKDEL</a>
-	 * @since 4.0
+	 * @since 4.1
 	 */
 	default Flux<StreamEntryDeletionResult> xAckDel(ByteBuffer key, String group,
 			XDelOptions options, String... recordIds) {
@@ -943,7 +943,7 @@ default Flux<StreamEntryDeletionResult> xAckDel(ByteBuffer key, String group,
 	 * @param recordIds stream record Id's.
 	 * @return {@link Flux} emitting {@link StreamEntryDeletionResult} for each ID.
 	 * @see <a href="https://redis.io/commands/xackdel">Redis Documentation: XACKDEL</a>
-	 * @since 4.0
+	 * @since 4.1
 	 */
 	default Flux<StreamEntryDeletionResult> xAckDel(ByteBuffer key, String group,
 			XDelOptions options, RecordId... recordIds) {
@@ -963,7 +963,7 @@ default Flux<StreamEntryDeletionResult> xAckDel(ByteBuffer key, String group,
 	 * @param commands must not be {@literal null}.
 	 * @return {@link Flux} emitting a list of {@link StreamEntryDeletionResult} per {@link AcknowledgeDeleteCommand}.
 	 * @see <a href="https://redis.io/commands/xackdel">Redis Documentation: XACKDEL</a>
-	 * @since 4.0
+	 * @since 4.1
 	 */
 	Flux<CommandResponse<AcknowledgeDeleteCommand, List<StreamEntryDeletionResult>>> xAckDel(
 			Publisher<AcknowledgeDeleteCommand> commands);
@@ -1233,7 +1233,7 @@ public PendingRecordsCommand consumer(String consumerName) {
 		 *
 		 * @param minIdleTime must not be {@literal null}.
 		 * @return new instance of {@link PendingRecordsCommand}.
-		 * @since 4.0
+		 * @since 4.1
 		 */
 		public PendingRecordsCommand minIdleTime(Duration minIdleTime) {
 
@@ -1980,7 +1980,7 @@ public TrimCommand approximate(boolean approximateTrimming) {
 		 *
 		 * @param options the {@link XTrimOptions} to apply. Must not be {@literal null}.
 		 * @return a new {@link TrimCommand} with the specified options applied.
-		 * @since 4.0
+		 * @since 4.1
 		 */
 		public TrimCommand options(XTrimOptions options) {
 			return new TrimCommand(getKey(), options);
@@ -2044,6 +2044,15 @@ default Mono<Long> xTrim(ByteBuffer key, long count, boolean approximateTrimming
 				.map(NumericResponse::getOutput);
 	}
 
+	/**
+	 * Trims the stream to {@code count} elements.
+	 *
+	 * @param key the stream key.
+	 * @param options the trim options
+	 * @return {@link Mono} emitting the number of removed entries.
+	 * @since 4.1
+	 * @see <a href="https://redis.io/commands/xtrim">Redis Documentation: XTRIM</a>
+	 */
 	default Mono<Long> xTrim(ByteBuffer key, XTrimOptions options) {
 
 		Assert.notNull(key, "Key must not be null");