Remove unused casts and variables

Author: sbrannen

spring-core/src/test/java/org/springframework/core/codec/ResourceEncoderTests.java

@@ -80,7 +80,7 @@ protected void testEncodeError(Publisher<?> input, ResolvableType outputType,
 
 		Flux<Resource> i = Flux.error(new InputException());
 
-		Flux<DataBuffer> result = ((Encoder<Resource>) this.encoder).encode(i,
+		Flux<DataBuffer> result = this.encoder.encode(i,
 				this.bufferFactory, outputType,
 				mimeType, hints);
 

spring-expression/src/test/java/org/springframework/expression/spel/SpelCompilationCoverageTests.java

@@ -2522,7 +2522,7 @@ void functionReferenceNonCompilableArguments_SPR12359() throws Exception {
 		expression = parser.parseExpression("#negate(#ints.?[#this<2][0])");
 		assertThat(expression.getValue(context, Integer.class).toString()).isEqualTo("-1");
 		// Selection isn't compilable.
-		assertThat(((SpelNodeImpl)((SpelExpression) expression).getAST()).isCompilable()).isFalse();
+		assertThat(((SpelExpression) expression).getAST().isCompilable()).isFalse();
 	}
 
 	@Test

spring-expression/src/test/java/org/springframework/expression/spel/ast/InlineCollectionTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2023 the original author or authors.
+ * Copyright 2002-2024 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -88,14 +88,14 @@ void listWithPropertyAccessIsNotCached() {
 		@Test
 		void listCanBeCompiled() {
 			SpelExpression listExpression = parseExpression("{1, -2, 3, 4}");
-			assertThat(((SpelNodeImpl) listExpression.getAST()).isCompilable()).isTrue();
+			assertThat(listExpression.getAST().isCompilable()).isTrue();
 			assertThat(SpelCompiler.compile(listExpression)).isTrue();
 		}
 
 		@Test
 		void dynamicListCannotBeCompiled() {
 			SpelExpression listExpression = parseExpression("{1, (5 - 3), 3, 4}");
-			assertThat(((SpelNodeImpl) listExpression.getAST()).isCompilable()).isFalse();
+			assertThat(listExpression.getAST().isCompilable()).isFalse();
 			assertThat(SpelCompiler.compile(listExpression)).isFalse();
 		}
 

spring-web/src/main/java/org/springframework/http/client/JdkClientHttpRequest.java

@@ -120,7 +120,7 @@ protected ClientHttpResponse executeInternal(HttpHeaders headers, @Nullable Body
 		catch (ExecutionException ex) {
 			Throwable cause = ex.getCause();
 
-			if (cause instanceof CancellationException caEx) {
+			if (cause instanceof CancellationException) {
 				throw new HttpTimeoutException("Request timed out");
 			}
 			if (cause instanceof UncheckedIOException uioEx) {

spring-web/src/test/java/org/springframework/web/ErrorResponseExceptionTests.java

@@ -459,7 +459,7 @@ private void assertDetailMessageCode(
 			ErrorResponse ex, @Nullable String suffix, @Nullable Object[] arguments) {
 
 		assertThat(ex.getDetailMessageCode())
-				.isEqualTo(ErrorResponse.getDefaultDetailMessageCode(((Exception) ex).getClass(), suffix));
+				.isEqualTo(ErrorResponse.getDefaultDetailMessageCode(ex.getClass(), suffix));
 
 		if (arguments != null) {
 			assertThat(ex.getDetailMessageArguments()).containsExactlyElementsOf(Arrays.asList(arguments));