Skip to content

Commit 5ce1154

Browse files
garyrussellartembilan
authored andcommitted
GH-1811: MessageConverter Nullable - Kotlin Compat.
Resolves #1811
1 parent 056d9fd commit 5ce1154

File tree

4 files changed

+14
-7
lines changed

4 files changed

+14
-7
lines changed

spring-kafka/src/main/java/org/springframework/kafka/config/AbstractKafkaListenerEndpoint.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -482,7 +482,9 @@ public void afterPropertiesSet() {
482482
}
483483

484484
@Override
485-
public void setupListenerContainer(MessageListenerContainer listenerContainer, MessageConverter messageConverter) {
485+
public void setupListenerContainer(MessageListenerContainer listenerContainer,
486+
@Nullable MessageConverter messageConverter) {
487+
486488
setupMessageListener(listenerContainer, messageConverter);
487489
}
488490

@@ -494,10 +496,12 @@ public void setupListenerContainer(MessageListenerContainer listenerContainer, M
494496
* @return a {@link MessageListener} instance.
495497
*/
496498
protected abstract MessagingMessageListenerAdapter<K, V> createMessageListener(MessageListenerContainer container,
497-
MessageConverter messageConverter);
499+
@Nullable MessageConverter messageConverter);
498500

499501
@SuppressWarnings("unchecked")
500-
private void setupMessageListener(MessageListenerContainer container, MessageConverter messageConverter) {
502+
private void setupMessageListener(MessageListenerContainer container,
503+
@Nullable MessageConverter messageConverter) {
504+
501505
MessagingMessageListenerAdapter<K, V> adapter = createMessageListener(container, messageConverter);
502506
if (this.replyHeadersConfigurer != null) {
503507
adapter.setReplyHeadersConfigurer(this.replyHeadersConfigurer);

spring-kafka/src/main/java/org/springframework/kafka/config/KafkaListenerEndpoint.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,8 @@ default Properties getConsumerProperties() {
135135
* @param listenerContainer the listener container to configure
136136
* @param messageConverter the message converter - can be null
137137
*/
138-
void setupListenerContainer(MessageListenerContainer listenerContainer, MessageConverter messageConverter);
138+
void setupListenerContainer(MessageListenerContainer listenerContainer,
139+
@Nullable MessageConverter messageConverter);
139140

140141
/**
141142
* When true, {@link Iterable} return results will be split into discrete records.

spring-kafka/src/main/java/org/springframework/kafka/config/KafkaListenerEndpointAdapter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ public Boolean getAutoStartup() { // NOSONAR
9393

9494
@Override
9595
public void setupListenerContainer(MessageListenerContainer listenerContainer,
96-
MessageConverter messageConverter) {
96+
@Nullable MessageConverter messageConverter) {
9797
}
9898

9999
@Override

spring-kafka/src/main/java/org/springframework/kafka/config/MethodKafkaListenerEndpoint.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ protected MessageHandlerMethodFactory getMessageHandlerMethodFactory() {
169169

170170
@Override
171171
protected MessagingMessageListenerAdapter<K, V> createMessageListener(MessageListenerContainer container,
172-
MessageConverter messageConverter) {
172+
@Nullable MessageConverter messageConverter) {
173173

174174
Assert.state(this.messageHandlerMethodFactory != null,
175175
"Could not create message listener - MessageHandlerMethodFactory not set");
@@ -202,7 +202,9 @@ protected HandlerAdapter configureListenerAdapter(MessagingMessageListenerAdapte
202202
* @param messageConverter the converter (may be null).
203203
* @return the {@link MessagingMessageListenerAdapter} instance.
204204
*/
205-
protected MessagingMessageListenerAdapter<K, V> createMessageListenerInstance(MessageConverter messageConverter) {
205+
protected MessagingMessageListenerAdapter<K, V> createMessageListenerInstance(
206+
@Nullable MessageConverter messageConverter) {
207+
206208
MessagingMessageListenerAdapter<K, V> listener;
207209
if (isBatchListener()) {
208210
BatchMessagingMessageListenerAdapter<K, V> messageListener = new BatchMessagingMessageListenerAdapter<K, V>(

0 commit comments

Comments
 (0)