Skip to content

Commit dc85bd6

Browse files
wxmerktolivier-stasse
authored andcommitted
Ignore Wsign-conversion warnings
There are a lot of implicit std::size_t to Eigen::Index (long) conversions. This deactivates the warnings for now since fixing them directly might be quite verbose (by explicit casting everywhere)
1 parent e5c9239 commit dc85bd6

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ set(${PROJECT_NAME}_HEADERS
5757
include/${PROJECT_NAME}/eiquadprog-utils.hxx)
5858

5959
add_library(${PROJECT_NAME} SHARED src/eiquadprog-fast.cpp src/eiquadprog.cpp)
60+
target_compile_options(${PROJECT_NAME} PRIVATE "-Wno-sign-conversion") # We have a lot of implicit size_t to Eigen::Index conversions
6061

6162
if(TRACE_SOLVER)
6263
target_compile_definitions(${PROJECT_NAME} PRIVATE EIQGUADPROG_TRACE_SOLVER)

tests/CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,10 @@ set(TESTS eiquadprog-basic eiquadprog-fast eiquadprog-rt eiquadprog-both
2424
foreach(test ${TESTS})
2525
add_unit_test(${test} ${test}.cpp)
2626
target_link_libraries(${test} ${PROJECT_NAME} Boost::unit_test_framework)
27+
target_compile_options(${test} PRIVATE "-Wno-sign-conversion") # We have a lot of implicit size_t to Eigen::Index conversions
2728
endforeach(test ${TESTS})
2829

2930
add_library(testab SHARED TestA.cpp TestB.cpp)
3031
target_link_libraries(testab ${PROJECT_NAME})
3132
target_link_libraries(test-integration testab)
33+
target_compile_options(testab PRIVATE "-Wno-sign-conversion") # We have a lot of implicit size_t to Eigen::Index conversions

0 commit comments

Comments
 (0)