refactor nodename templating for DRY

Author: sjpb

environments/skeleton/{{cookiecutter.environment}}/tofu/control.tf

@@ -1,5 +1,13 @@
 locals {
   control_volumes = concat([openstack_blockstorage_volume_v3.state], var.home_volume_size > 0 ? [openstack_blockstorage_volume_v3.home][0] : [])
+  nodename = templatestring(
+    var.cluster_nodename_template,
+    {
+      node="control",
+      cluster_name=var.cluster_name,
+      cluster_domain_suffix=var.cluster_domain_suffix
+    }
+  )
 }
 
 resource "openstack_networking_port_v2" "control" {
@@ -24,7 +32,7 @@ resource "openstack_networking_port_v2" "control" {
 
 resource "openstack_compute_instance_v2" "control" {
 
-  name = split(".", templatestring(var.cluster_nodename_template, {node="control", cluster_name=var.cluster_name,cluster_domain_suffix=var.cluster_domain_suffix}))[0]
+  name = split(".", local.nodename)[0]
   image_id = var.cluster_image_id
   flavor_name = var.control_node_flavor
   key_pair = var.key_pair
@@ -65,7 +73,7 @@ resource "openstack_compute_instance_v2" "control" {
 
   user_data = <<-EOF
     #cloud-config
-    fqdn: ${templatestring(var.cluster_nodename_template, {node="control", cluster_name=var.cluster_name,cluster_domain_suffix=var.cluster_domain_suffix})}
+    fqdn: ${local.nodename}
     
     bootcmd:
       %{for volume in local.control_volumes}

environments/skeleton/{{cookiecutter.environment}}/tofu/node_group/nodes.tf

@@ -12,6 +12,18 @@ locals {
 
   # Workaround for lifecycle meta-argument only taking static values
   compute_instances = var.ignore_image_changes ? openstack_compute_instance_v2.compute_fixed_image : openstack_compute_instance_v2.compute
+  
+  # Define nodenames here to avoid repetition
+  nodenames = {
+    for n in var.nodes: n => templatestring(
+      var.nodename_template,
+      {
+        node=n,
+        cluster_name=var.cluster_name,
+        cluster_domain_suffix=var.cluster_domain_suffix
+      }
+    )
+  }
 }
 
 resource "openstack_blockstorage_volume_v3" "compute" {
@@ -57,7 +69,7 @@ resource "openstack_compute_instance_v2" "compute_fixed_image" {
 
   for_each = var.ignore_image_changes ? toset(var.nodes) : []
 
-  name = split(".", templatestring(var.nodename_template, {node=each.key, cluster_name=var.cluster_name,cluster_domain_suffix=var.cluster_domain_suffix}))[0]
+  name = split(".", local.nodenames[each.key])[0]
   image_id = var.image_id
   flavor_name = var.flavor
   key_pair = var.key_pair
@@ -94,7 +106,7 @@ resource "openstack_compute_instance_v2" "compute_fixed_image" {
 
   user_data = <<-EOF
     #cloud-config
-    fqdn: ${templatestring(var.nodename_template, {node=each.key, cluster_name=var.cluster_name,cluster_domain_suffix=var.cluster_domain_suffix})}
+    fqdn: ${local.nodenames[each.key]}
   EOF
 
   availability_zone = var.match_ironic_node ? "${var.availability_zone}::${var.baremetal_nodes[each.key]}" : null
@@ -111,7 +123,7 @@ resource "openstack_compute_instance_v2" "compute" {
 
   for_each = var.ignore_image_changes ? [] : toset(var.nodes)
 
-  name = split(".", templatestring(var.nodename_template, {node=each.key, cluster_name=var.cluster_name,cluster_domain_suffix=var.cluster_domain_suffix}))[0]
+  name = split(".", local.nodenames[each.key])[0]
   image_id = var.image_id
   flavor_name = var.flavor
   key_pair = var.key_pair
@@ -148,7 +160,7 @@ resource "openstack_compute_instance_v2" "compute" {
 
   user_data = <<-EOF
     #cloud-config
-    fqdn: ${templatestring(var.nodename_template, {node=each.key, cluster_name=var.cluster_name,cluster_domain_suffix=var.cluster_domain_suffix})}
+    fqdn: ${local.nodenames[each.key]}
   EOF
 
   availability_zone = var.match_ironic_node ? "${var.availability_zone}::${var.baremetal_nodes[each.key]}" : null