discover volume path from volume descriptions; remove *_device_path TF vars

Author: sjpb

environments/.stackhpc/terraform/ARCUS.tfvars

@@ -3,5 +3,3 @@ cluster_subnet = "portal-internal"
 vnic_type = "normal"
 control_node_flavor = "vm.ska.cpu.general.quarter"
 other_node_flavor = "vm.ska.cpu.general.small"
-state_volume_device_path = "/dev/sdb"
-home_volume_device_path = "/dev/sdc"

environments/.stackhpc/terraform/SMS.tfvars

@@ -3,5 +3,3 @@ cluster_subnet = "stackhpc-ipv4-geneve-subnet"
 vnic_type = "normal"
 control_node_flavor = "general.v1.medium"
 other_node_flavor = "general.v1.tiny"
-state_volume_device_path = "/dev/vdb"
-home_volume_device_path = "/dev/vdc"

environments/.stackhpc/terraform/main.tf

@@ -31,10 +31,6 @@ variable "volume_backed_instances" {
     default = false
 }
 
-variable "state_volume_device_path" {}
-
-variable "home_volume_device_path" {}
-
 module "cluster" {
     source = "../../skeleton/{{cookiecutter.environment}}/terraform/"
 
@@ -76,6 +72,4 @@ module "cluster" {
     state_volume_size = 10
     home_volume_size = 20
 
-    state_volume_device_path = var.state_volume_device_path
-    home_volume_device_path = var.home_volume_device_path
 }

environments/skeleton/{{cookiecutter.environment}}/terraform/nodes.tf

@@ -126,19 +126,14 @@ resource "openstack_compute_instance_v2" "control" {
     #cloud-config
     fqdn: ${var.cluster_name}-${each.key}.${var.cluster_name}.${var.cluster_domain_suffix}
     
-    fs_setup:
-      - label: state
-        filesystem: ext4
-        device: ${var.state_volume_device_path}
-        partition: auto
-      - label: home
-        filesystem: ext4
-        device: ${var.home_volume_device_path}
-        partition: auto
+    bootcmd:
+      %{for volume in [openstack_blockstorage_volume_v3.state, openstack_blockstorage_volume_v3.home]}
+      - BLKDEV=$(readlink -f $(ls /dev/disk/by-id/*${substr(volume.id, 0, 20)}* | head -n1 )); blkid -o value -s TYPE $BLKDEV ||  mke2fs -t ext4 -L ${lower(split(" ", volume.description)[0])} $BLKDEV
+      %{endfor}
 
     mounts:
       - [LABEL=state, ${var.state_dir}]
-      - [LABEL=home, /exports/home, auto, "x-systemd.required-by=nfs-server.service,x-systemd.before=nfs-server.service"]
+      - [LABEL=home, /exports/home]
   EOF
 
 }

environments/skeleton/{{cookiecutter.environment}}/terraform/variables.tf

@@ -55,18 +55,6 @@ variable "environment_root" {
     description = "Path to environment root, automatically set by activate script"
 }
 
-variable "state_volume_device_path" {
-    type = string
-    description = "Path to block device for state"
-    default = "/dev/sdb"
-}
-
-variable "home_volume_device_path" {
-    type = string
-    description = "Path to block device name for home directories"
-    default = "/dev/sdc"
-}
-
 variable "state_dir" {
     type = string
     description = "Path to state directory on control node"