Skip to content

Commit 8e922b8

Browse files
committed
chore(edge): fix review comments
relates to STACKITCLI-357
1 parent 512c504 commit 8e922b8

4 files changed

Lines changed: 7 additions & 15 deletions

File tree

internal/cmd/beta/edge/instance/create/create.go

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -114,15 +114,11 @@ func parseInput(p *print.Printer, cmd *cobra.Command, _ []string) (*inputModel,
114114
return nil, &cliErr.ProjectIdError{}
115115
}
116116

117-
displayNameValue := flags.FlagToStringValue(p, cmd, displayNameFlag)
118-
planIdValue := flags.FlagToStringValue(p, cmd, planIdFlag)
119-
descriptionValue := flags.FlagToStringPointer(p, cmd, descriptionFlag)
120-
121117
model := inputModel{
122118
GlobalFlagModel: globalFlags,
123-
DisplayName: displayNameValue,
124-
Description: descriptionValue,
125-
PlanId: planIdValue,
119+
DisplayName: flags.FlagToStringValue(p, cmd, displayNameFlag),
120+
Description: flags.FlagToStringPointer(p, cmd, descriptionFlag),
121+
PlanId: flags.FlagToStringValue(p, cmd, planIdFlag),
126122
}
127123

128124
p.DebugInputModel(model)

internal/cmd/beta/edge/instance/delete/delete.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,5 @@ func parseInput(p *print.Printer, cmd *cobra.Command, inputArgs []string) (*inpu
120120
}
121121

122122
func buildRequest(ctx context.Context, model *inputModel, apiClient *edge.APIClient) edge.ApiDeleteInstanceRequest {
123-
req := apiClient.DefaultAPI.DeleteInstance(ctx, model.ProjectId, model.Region, model.InstanceId)
124-
return req
123+
return apiClient.DefaultAPI.DeleteInstance(ctx, model.ProjectId, model.Region, model.InstanceId)
125124
}

internal/cmd/beta/edge/instance/describe/describe.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,7 @@ func parseInput(p *print.Printer, cmd *cobra.Command, inputArgs []string) (*inpu
8989
}
9090

9191
func buildRequest(ctx context.Context, model *inputModel, apiClient *edge.APIClient) edge.ApiGetInstanceRequest {
92-
req := apiClient.DefaultAPI.GetInstance(ctx, model.ProjectId, model.Region, model.InstanceId)
93-
return req
92+
return apiClient.DefaultAPI.GetInstance(ctx, model.ProjectId, model.Region, model.InstanceId)
9493
}
9594

9695
func outputResult(p *print.Printer, outputFormat string, instance *edge.Instance) error {

internal/cmd/beta/edge/instance/list/list.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command {
6666
}
6767

6868
// Call API
69-
req := buildRequest(ctx, model, apiClient)
70-
resp, err := req.Execute()
69+
resp, err := buildRequest(ctx, model, apiClient).Execute()
7170
if err != nil {
7271
return fmt.Errorf("get Edge Cloud instances: %w", err)
7372
}
@@ -114,8 +113,7 @@ func parseInput(p *print.Printer, cmd *cobra.Command, _ []string) (*inputModel,
114113
}
115114

116115
func buildRequest(ctx context.Context, model *inputModel, apiClient *edge.APIClient) edge.ApiListInstancesRequest {
117-
req := apiClient.DefaultAPI.ListInstances(ctx, model.ProjectId, model.Region)
118-
return req
116+
return apiClient.DefaultAPI.ListInstances(ctx, model.ProjectId, model.Region)
119117
}
120118

121119
func outputResult(p *print.Printer, outputFormat, projectLabel string, instances []edge.Instance) error {

0 commit comments

Comments
 (0)