golang-version-1.25.3 (#583)

* golang-version-1.25.3

Summary:

- Update `golang` version to `1.25.3` on all platofrms.
- Future proofing for use of stable `testing/synctest`.

* - Linnter alarms supressed.

* - Linter restored.
- Newly forbidden fmt usage altered.

* - Doc uplift.
- Linter inconsistency failsafe.

* - `mingw` to version `15.2.0`.

* - Shim for build behaviour change.

* - Shim for build behaviour change.

* - Shim for build behaviour change.

* - Shim for build behaviour change.

* - Shim for build behaviour change.

* - Shim for build behaviour change.

* - Another try.

* - Another try.

Author: general-kroll-4-life

.github/workflows/build.yml

@@ -91,7 +91,7 @@ jobs:
     - name: Set up Go 1.x
       uses: actions/setup-go@v5.0.0
       with:
-        go-version: '~1.23'
+        go-version: '1.25.3'
         check-latest: true
         cache: true
       id: go
@@ -174,12 +174,32 @@ jobs:
         BUILDBRANCH: ${{github.ref}}
         BUILDPLATFORM: ${{runner.os}}
         BUILDPATCHVERSION: ${{github.run_number}}
-        CGO_ENABLED: 1
+        CGO_ENABLED: '1'
         GH_ACCESS_TOKEN: ${{env.GH_ACCESS_TOKEN}}
         GOPRIVATE: ${{env.GOPRIVATE}}
         GOOS: windows
         GOARCH: amd64
+        GOMINGWID: 'x86_64-w64-mingw32'
       run: |
+        # Explicitly prioritize the correct MinGW in the PATH
+        $mingwPath = "C:\mingw64"
+        if (-not (Test-Path -Path $mingwPath)) {
+            # Fallback to the chocolatey path, which we know exists
+            $mingwPath = "C:\ProgramData\chocolatey\lib\mingw\tools\install\mingw64"
+        }
+
+        # Use Resolve-Path to get the guaranteed absolute path
+        # Now that we've ensured $mingwPath isn't empty, Resolve-Path will succeed.
+        $mingwPath = Resolve-Path $mingwPath
+        $env:Path = "$mingwPath\bin;" + $env:Path
+
+        # Set CC and CXX with the fully resolved absolute path
+        $env:CC = "$mingwPath\bin\x86_64-w64-mingw32-gcc"
+        $env:CXX = "$mingwPath\bin\x86_64-w64-mingw32-g++"
+        echo "Current PATH:"
+        echo $env:PATH
+
+
         git config --global url.https://$env:GH_ACCESS_TOKEN@github.com/.insteadOf https://github.com/
         $Version = convertfrom-stringdata (get-content ./cicd/version.txt -raw)
         $BuildMajorVersion = $Version.'MajorVersion'
@@ -192,9 +212,59 @@ jobs:
         echo "BUILDMINORVERSION=$env:BUILDMINORVERSION" >> $GITHUB_ENV
         echo "BUILDPATCHVERSION=$env:BUILDPATCHVERSION" >> $GITHUB_ENV
 
+        # This creates a PowerShell function to intercept the 'go build' command
+        # and inject the static linker flags.
+        # The function calls the actual go.exe with the added arguments.
+        $originalGoPath = (Get-Command go.exe).Path
+        function go {
+            & $originalGoPath @args -ldflags "-linkmode external -extldflags '-static -s -w'"
+        }
+
         python cicd/python/build.py --verbose --build
         python cicd/python/build.py --verbose --build-mcp-client
 
+        ls ".\build"
+
+        function Copy-FileIfExists {
+          [CmdletBinding()]
+          param (
+              [Parameter(Mandatory = $true, HelpMessage = "The relative or absolute path of the file to be copied.")]
+              [string]$SourcePath,
+
+              [Parameter(Mandatory = $true, HelpMessage = "The relative or absolute path of the destination directory or file.")]
+              [string]$Destination
+          )
+
+          if (Test-Path -Path $SourcePath -PathType Leaf) {
+              # Check if the destination directory exists and create it if not
+              $destinationDir = Split-Path -Path $Destination -Parent
+              if (-not (Test-Path -Path $destinationDir)) {
+                  Write-Verbose "Creating destination directory: $destinationDir"
+                  New-Item -ItemType Directory -Path $destinationDir | Out-Null
+              }
+
+              # Copy the file
+              Write-Host "Copying '$SourcePath' to '$Destination'..."
+              Copy-Item -Path $SourcePath -Destination $Destination -Force -Verbose
+              Write-Host "Copy complete."
+          }
+          else {
+              Write-Warning "Source file not found: $SourcePath"
+          }
+        }
+
+        $sourcePath = ".\build\stackql"
+        $destinationPath = ".\build\stackql.exe"
+
+        Copy-FileIfExists -SourcePath $sourcePath -Destination $destinationPath
+
+        $mcpSourcePath = ".\build\stackql_mcp_client"
+        $mcpDestinationPath = ".\build\stackql_mcp_client.exe"
+
+        Copy-FileIfExists -SourcePath $mcpSourcePath -Destination $mcpDestinationPath
+
+        ls ".\build"
+
         build\stackql.exe --help
 
     - name: Test
@@ -261,7 +331,7 @@ jobs:
     - name: Set up Go 1.x
       uses: actions/setup-go@v5.0.0
       with:
-        go-version: '~1.24'
+        go-version: '1.25.3'
         check-latest: true
         cache: true
       id: go
@@ -505,7 +575,7 @@ jobs:
     - name: Set up Go 1.x
       uses: actions/setup-go@v5.0.0
       with:
-        go-version: '~1.24'
+        go-version: '1.25.3'
         check-latest: true
         cache: true
       id: go
@@ -708,7 +778,7 @@ jobs:
     - name: Set up Go 1.x
       uses: actions/setup-go@v5.0.0
       with:
-        go-version: '~1.23'
+        go-version: '1.25.3'
         check-latest: true
         cache: true
       id: go
@@ -1134,7 +1204,7 @@ jobs:
     - name: Set up Go 1.x
       uses: actions/setup-go@v5.0.0
       with:
-        go-version: '~1.23'
+        go-version: '1.25.3'
         check-latest: true
         cache: true
       id: go
@@ -1281,7 +1351,7 @@ jobs:
     - name: Set up Go 1.x
       uses: actions/setup-go@v5.0.0
       with:
-        go-version: '~1.23'
+        go-version: '1.25.3'
         check-latest: true
         cache: true
       id: go

.golangci.yml

@@ -196,6 +196,9 @@ linters:
           - lll
           - revive
         path: mcp_client\/cmd\/.*\.go
+      - linters:
+          - revive
+        path: internal\/stackql\/acid\/tsm_physio\/.*\.go
       - linters: 
           - staticcheck
         path: ast_format_postgres\.go

AGENTS.md

@@ -4,6 +4,8 @@ These guidelines help contributors, human and otherwise, understand and work eff
 
 We also encourage reading [`docs/developer_guide.md`](/docs/developer_guide.md) for further useful information.  For deeper understanding of the "brains" of `stackql`, it is worthwhile to consult [the `AGENTS.md` file of `any-sdk`](https://github.com/stackql/any-sdk/blob/main/AGENTS.md) and linked documents from there.
 
+We have upgraded to golang `>= 1.25.3` in order to take advantage of [time simultion and other capabilites in `testing/synctest`](https://go.dev/blog/testing-time).
+
 
 ## Project Structure & Module Organization
 

Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.23-bullseye AS sourceprep
+FROM golang:1.25.3-bookworm AS sourceprep
 
 ENV SRC_DIR=/work/stackql/src
 

docs/developer_guide.md

@@ -66,6 +66,8 @@ env CGO_ENABLED=1 PLANCACHEENABLED=false go build \
 
 At this time, we are not dogmatic about how to implement unit tests.  Aspirationally, unit tests can be implemented in similar fashion to the none-too opinionated [official testing package documentation](https://pkg.go.dev/testing), and in particular [the overview section](https://pkg.go.dev/testing#pkg-overview).
 
+We have upgraded to golang `>= 1.25.3` in order to take advantage of [time simultion and other capabilites in `testing/synctest`](https://go.dev/blog/testing-time).
+
 To run all unit tests:
 
 ```bash

go.mod

@@ -1,6 +1,6 @@
 module github.com/stackql/stackql
 
-go 1.23.0
+go 1.25.3
 
 require (
 	github.com/DATA-DOG/go-sqlmock v1.5.1

internal/stackql/acid/tsm_physio/best_effort_orchestrator.go

@@ -121,7 +121,7 @@ func (orc *bestEffortOrchestrator) processQuery(
 			retVal = append(retVal, internaldto.NewNopEmptyExecutorOutput([]string{"OK"}))
 			return retVal, true
 		}
-		noParentErr := fmt.Errorf(noParentMessage)
+		noParentErr := fmt.Errorf("%s", noParentMessage)
 		retVal = append(retVal, internaldto.NewErroneousExecutorOutput(noParentErr))
 		return retVal, true
 	} else if transactStatement.IsRollback() {
@@ -152,7 +152,7 @@ func (orc *bestEffortOrchestrator) processQuery(
 		retVal = append(
 			retVal,
 			internaldto.NewErroneousExecutorOutput(
-				fmt.Errorf(noParentMessage)),
+				fmt.Errorf("%s", noParentMessage)),
 		)
 		return retVal, true
 	}

internal/stackql/acid/tsm_physio/txn_orchestrator.go

@@ -136,7 +136,7 @@ func (orc *standardOrchestrator) processQuery(
 			retVal = append(retVal, internaldto.NewNopEmptyExecutorOutput([]string{"OK"}))
 			return retVal, true
 		}
-		noParentErr := fmt.Errorf(noParentMessage)
+		noParentErr := fmt.Errorf("%s", noParentMessage)
 		retVal = append(retVal, internaldto.NewErroneousExecutorOutput(noParentErr))
 		return retVal, true
 	} else if transactStatement.IsRollback() {
@@ -155,7 +155,7 @@ func (orc *standardOrchestrator) processQuery(
 		retVal = append(
 			retVal,
 			internaldto.NewErroneousExecutorOutput(
-				fmt.Errorf(noParentMessage)),
+				fmt.Errorf("%s", noParentMessage)),
 		)
 		return retVal, true
 	}

internal/stackql/astvisit/internally_routable_typing.go

@@ -110,10 +110,10 @@ func (v *standardInternallyRoutableTypingAstVisitor) getStarColumns(
 	tbl.SetSelectItemsKey(selectItemsKey)
 	unsuitableSchemaMsg := "standardInternallyRoutableTypingAstVisitor.getStarColumns(): schema unsuitable for select query"
 	if err != nil {
-		return nil, fmt.Errorf(unsuitableSchemaMsg)
+		return nil, fmt.Errorf("%s", unsuitableSchemaMsg)
 	}
 	if itemObjS == nil {
-		return nil, fmt.Errorf(unsuitableSchemaMsg)
+		return nil, fmt.Errorf("%s", unsuitableSchemaMsg)
 	}
 	var cols []parserutil.ColumnHandle
 	colNames := itemObjS.GetAllColumns(util.TrimSelectItemsKey(selectItemsKey))

internal/stackql/astvisit/query_rewriting.go

@@ -175,10 +175,10 @@ func (v *standardQueryRewriteAstVisitor) getStarColumns(
 	tbl.SetSelectItemsKey(selectItemsKey)
 	unsuitableSchemaMsg := "standardQueryRewriteAstVisitor.getStarColumns(): schema unsuitable for select query"
 	if err != nil {
-		return nil, fmt.Errorf(unsuitableSchemaMsg)
+		return nil, fmt.Errorf("%s", unsuitableSchemaMsg)
 	}
 	if itemObjS == nil {
-		return nil, fmt.Errorf(unsuitableSchemaMsg)
+		return nil, fmt.Errorf("%s", unsuitableSchemaMsg)
 	}
 	var cols []parserutil.ColumnHandle
 	colNames := itemObjS.GetAllColumns(util.TrimSelectItemsKey(selectItemsKey))