From c6fe297cac40e222e673b08ecbc86d5b8f9114a6 Mon Sep 17 00:00:00 2001 From: Jay George Date: Wed, 14 Jan 2026 10:12:00 +0000 Subject: [PATCH 1/5] Tighten up menu spacing. It feels too floaty otherwise if we're removing icons --- resources/js/components/ui/Context/Item.vue | 2 +- resources/js/components/ui/Dropdown/Item.vue | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/resources/js/components/ui/Context/Item.vue b/resources/js/components/ui/Context/Item.vue index 11429a0415..cc4ec015d5 100644 --- a/resources/js/components/ui/Context/Item.vue +++ b/resources/js/components/ui/Context/Item.vue @@ -31,7 +31,7 @@ const tag = computed(() => { const classes = cva({ base: [ 'col-span-2 grid grid-cols-subgrid items-center', - 'rounded-lg px-1 py-1.5 text-sm antialiased', + 'rounded-lg px-1 py-1.25 text-sm antialiased', 'text-gray-700 dark:text-gray-300', 'not-data-disabled:cursor-pointer data-disabled:opacity-50', 'hover:not-data-disabled:bg-gray-50 dark:hover:not-data-disabled:bg-gray-950 outline-hidden', diff --git a/resources/js/components/ui/Dropdown/Item.vue b/resources/js/components/ui/Dropdown/Item.vue index a0d7742b00..dde073dfc1 100644 --- a/resources/js/components/ui/Dropdown/Item.vue +++ b/resources/js/components/ui/Dropdown/Item.vue @@ -29,7 +29,7 @@ const tag = computed(() => { }); const classes = cva({ - base: 'col-span-2 grid grid-cols-subgrid items-center rounded-lg px-1 py-1.5 text-sm antialiased text-gray-900 dark:text-gray-300 not-data-disabled:cursor-pointer data-disabled:opacity-50 hover:not-data-disabled:bg-gray-100 dark:hover:not-data-disabled:bg-gray-800 outline-hidden', + base: 'col-span-2 grid grid-cols-subgrid items-center rounded-lg px-1 py-1.25 text-sm antialiased text-gray-900 dark:text-gray-300 not-data-disabled:cursor-pointer data-disabled:opacity-50 hover:not-data-disabled:bg-gray-100 dark:hover:not-data-disabled:bg-gray-800 outline-hidden', variants: { variant: { default: 'text-gray-700 dark:text-gray-300', @@ -58,7 +58,7 @@ const iconClasses = cva({ :href :target > -
+
From 1d8d528a697fa0f978044c684f6bdb4d901063a4 Mon Sep 17 00:00:00 2001 From: Jay George Date: Wed, 14 Jan 2026 10:15:31 +0000 Subject: [PATCH 2/5] Remove the trash icon. You don't usually hunt for destructive actions, and the menu is already red and at the bottom --- resources/js/components/blueprints/Listing.vue | 1 - resources/js/components/blueprints/Tab.vue | 2 +- resources/js/components/fieldtypes/grid/Row.vue | 2 +- resources/js/pages/navigation/Show.vue | 1 - src/Actions/Delete.php | 2 -- 5 files changed, 2 insertions(+), 6 deletions(-) diff --git a/resources/js/components/blueprints/Listing.vue b/resources/js/components/blueprints/Listing.vue index a9520c39ce..a43d007d40 100644 --- a/resources/js/components/blueprints/Listing.vue +++ b/resources/js/components/blueprints/Listing.vue @@ -55,7 +55,6 @@ const reloadPage = () => router.reload(); diff --git a/resources/js/components/blueprints/Tab.vue b/resources/js/components/blueprints/Tab.vue index 6a5713d783..74dbe0d8c9 100644 --- a/resources/js/components/blueprints/Tab.vue +++ b/resources/js/components/blueprints/Tab.vue @@ -15,7 +15,7 @@ - + diff --git a/resources/js/components/fieldtypes/grid/Row.vue b/resources/js/components/fieldtypes/grid/Row.vue index ada524d98f..3e4eef570b 100644 --- a/resources/js/components/fieldtypes/grid/Row.vue +++ b/resources/js/components/fieldtypes/grid/Row.vue @@ -15,7 +15,7 @@ - + diff --git a/resources/js/pages/navigation/Show.vue b/resources/js/pages/navigation/Show.vue index 52327379c6..7a3f36c605 100644 --- a/resources/js/pages/navigation/Show.vue +++ b/resources/js/pages/navigation/Show.vue @@ -527,7 +527,6 @@ export default { :text="__('Remove')" variant="destructive" @click="deleteTreeBranch(branch, removeBranch)" - icon="trash" /> diff --git a/src/Actions/Delete.php b/src/Actions/Delete.php index aa37d489da..cab7b0cc5a 100644 --- a/src/Actions/Delete.php +++ b/src/Actions/Delete.php @@ -8,8 +8,6 @@ class Delete extends Action { protected $dangerous = true; - protected $icon = 'trash'; - public static function title() { return __('Delete'); From e09a8122efcfcb8af57b8d392913264d60ceb9bc Mon Sep 17 00:00:00 2001 From: Jay George Date: Wed, 14 Jan 2026 10:42:01 +0000 Subject: [PATCH 3/5] Try removing some icons --- resources/js/components/collections/Listing.vue | 4 ++-- resources/js/components/entries/Listing.vue | 2 +- src/Actions/Unpublish.php | 2 -- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/resources/js/components/collections/Listing.vue b/resources/js/components/collections/Listing.vue index 4c4cdb4c3d..fe62f07b1f 100644 --- a/resources/js/components/collections/Listing.vue +++ b/resources/js/components/collections/Listing.vue @@ -32,11 +32,11 @@ > - + - + - + diff --git a/src/Actions/Unpublish.php b/src/Actions/Unpublish.php index 08c78e6d08..c30e807da3 100644 --- a/src/Actions/Unpublish.php +++ b/src/Actions/Unpublish.php @@ -7,8 +7,6 @@ class Unpublish extends Action { - protected $icon = 'eye-slash'; - public function visibleTo($item) { return $this->context['view'] === 'list' && $item instanceof Entry && $item->published(); From f1efaafc5c5ac6c529e50fc1fa53c1cca66d2b5d Mon Sep 17 00:00:00 2001 From: Jay George Date: Wed, 14 Jan 2026 11:33:17 +0000 Subject: [PATCH 4/5] Revert removing icons --- resources/js/components/blueprints/Listing.vue | 1 + resources/js/components/blueprints/Tab.vue | 2 +- resources/js/components/collections/Listing.vue | 4 ++-- resources/js/components/entries/Listing.vue | 2 +- resources/js/components/fieldtypes/grid/Row.vue | 2 +- resources/js/pages/navigation/Show.vue | 1 + src/Actions/Delete.php | 2 ++ src/Actions/Unpublish.php | 2 ++ 8 files changed, 11 insertions(+), 5 deletions(-) diff --git a/resources/js/components/blueprints/Listing.vue b/resources/js/components/blueprints/Listing.vue index a43d007d40..a9520c39ce 100644 --- a/resources/js/components/blueprints/Listing.vue +++ b/resources/js/components/blueprints/Listing.vue @@ -55,6 +55,7 @@ const reloadPage = () => router.reload(); diff --git a/resources/js/components/blueprints/Tab.vue b/resources/js/components/blueprints/Tab.vue index 74dbe0d8c9..6a5713d783 100644 --- a/resources/js/components/blueprints/Tab.vue +++ b/resources/js/components/blueprints/Tab.vue @@ -15,7 +15,7 @@ - + diff --git a/resources/js/components/collections/Listing.vue b/resources/js/components/collections/Listing.vue index fe62f07b1f..4c4cdb4c3d 100644 --- a/resources/js/components/collections/Listing.vue +++ b/resources/js/components/collections/Listing.vue @@ -32,11 +32,11 @@ > - + - + - + diff --git a/resources/js/components/fieldtypes/grid/Row.vue b/resources/js/components/fieldtypes/grid/Row.vue index 3e4eef570b..ada524d98f 100644 --- a/resources/js/components/fieldtypes/grid/Row.vue +++ b/resources/js/components/fieldtypes/grid/Row.vue @@ -15,7 +15,7 @@ - + diff --git a/resources/js/pages/navigation/Show.vue b/resources/js/pages/navigation/Show.vue index 7a3f36c605..52327379c6 100644 --- a/resources/js/pages/navigation/Show.vue +++ b/resources/js/pages/navigation/Show.vue @@ -527,6 +527,7 @@ export default { :text="__('Remove')" variant="destructive" @click="deleteTreeBranch(branch, removeBranch)" + icon="trash" /> diff --git a/src/Actions/Delete.php b/src/Actions/Delete.php index cab7b0cc5a..aa37d489da 100644 --- a/src/Actions/Delete.php +++ b/src/Actions/Delete.php @@ -8,6 +8,8 @@ class Delete extends Action { protected $dangerous = true; + protected $icon = 'trash'; + public static function title() { return __('Delete'); diff --git a/src/Actions/Unpublish.php b/src/Actions/Unpublish.php index c30e807da3..08c78e6d08 100644 --- a/src/Actions/Unpublish.php +++ b/src/Actions/Unpublish.php @@ -7,6 +7,8 @@ class Unpublish extends Action { + protected $icon = 'eye-slash'; + public function visibleTo($item) { return $this->context['view'] === 'list' && $item instanceof Entry && $item->published(); From 324aca5efcc93d82f2e5332f80c0f38f14d3add0 Mon Sep 17 00:00:00 2001 From: Jay George Date: Wed, 14 Jan 2026 11:35:32 +0000 Subject: [PATCH 5/5] Spacing halfway house --- resources/js/components/ui/Context/Item.vue | 2 +- resources/js/components/ui/Dropdown/Item.vue | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/js/components/ui/Context/Item.vue b/resources/js/components/ui/Context/Item.vue index cc4ec015d5..11429a0415 100644 --- a/resources/js/components/ui/Context/Item.vue +++ b/resources/js/components/ui/Context/Item.vue @@ -31,7 +31,7 @@ const tag = computed(() => { const classes = cva({ base: [ 'col-span-2 grid grid-cols-subgrid items-center', - 'rounded-lg px-1 py-1.25 text-sm antialiased', + 'rounded-lg px-1 py-1.5 text-sm antialiased', 'text-gray-700 dark:text-gray-300', 'not-data-disabled:cursor-pointer data-disabled:opacity-50', 'hover:not-data-disabled:bg-gray-50 dark:hover:not-data-disabled:bg-gray-950 outline-hidden', diff --git a/resources/js/components/ui/Dropdown/Item.vue b/resources/js/components/ui/Dropdown/Item.vue index dde073dfc1..6b517d1f71 100644 --- a/resources/js/components/ui/Dropdown/Item.vue +++ b/resources/js/components/ui/Dropdown/Item.vue @@ -29,7 +29,7 @@ const tag = computed(() => { }); const classes = cva({ - base: 'col-span-2 grid grid-cols-subgrid items-center rounded-lg px-1 py-1.25 text-sm antialiased text-gray-900 dark:text-gray-300 not-data-disabled:cursor-pointer data-disabled:opacity-50 hover:not-data-disabled:bg-gray-100 dark:hover:not-data-disabled:bg-gray-800 outline-hidden', + base: 'col-span-2 grid grid-cols-subgrid items-center rounded-lg px-1 py-1.5 text-sm antialiased text-gray-900 dark:text-gray-300 not-data-disabled:cursor-pointer data-disabled:opacity-50 hover:not-data-disabled:bg-gray-100 dark:hover:not-data-disabled:bg-gray-800 outline-hidden', variants: { variant: { default: 'text-gray-700 dark:text-gray-300',