Skip to content

Commit 637ee53

Browse files
committed
fixed makefun in setup.py, optional loading in estimator_getter
1 parent ff326b4 commit 637ee53

File tree

2 files changed

+15
-13
lines changed

2 files changed

+15
-13
lines changed

setup.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@
1010
install_requires = ['numpy',
1111
'pandas',
1212
'scikit-learn',
13-
'scipy'
13+
'scipy',
14+
'makefun'
1415
]
1516

1617

ya_glm/estimator_getter.py

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -35,18 +35,6 @@
3535
from ya_glm.backends.fista.WL1SolverGlm import WL1SolverGlm as WL1SolverGlmFista
3636

3737

38-
# andersoncd solvers
39-
from ya_glm.backends.andersoncd.glm_solver import solve_glm as \
40-
solve_glm_andersoncd
41-
from ya_glm.backends.andersoncd.glm_solver import solve_glm_path \
42-
as solve_glm_path_andersoncd
43-
44-
# cvxpy solvers
45-
from ya_glm.backends.cvxpy.glm_solver import solve_glm as solve_glm_cvxpy
46-
from ya_glm.backends.cvxpy.glm_solver import solve_glm_path \
47-
as solve_glm_path_cvxpy
48-
49-
5038
# other
5139
from ya_glm.init_signature import add_from_classes, add_multi_resp_params
5240
from ya_glm.make_docs import make_est_docs, make_cv_docs
@@ -183,10 +171,23 @@ def get_solver(backend='fista'):
183171
wl1_solver = WL1SolverGlmFista
184172

185173
elif backend == 'andersoncd':
174+
175+
# load andersoncd solvers
176+
from ya_glm.backends.andersoncd.glm_solver import solve_glm as \
177+
solve_glm_andersoncd
178+
from ya_glm.backends.andersoncd.glm_solver import solve_glm_path \
179+
as solve_glm_path_andersoncd
180+
186181
solve_glm = solve_glm_andersoncd
187182
solve_glm_path = solve_glm_path_andersoncd
188183

189184
elif backend == 'cvxpy':
185+
186+
# load cvxpy solvers
187+
from ya_glm.backends.cvxpy.glm_solver import solve_glm as solve_glm_cvxpy
188+
from ya_glm.backends.cvxpy.glm_solver import solve_glm_path \
189+
as solve_glm_path_cvxpy
190+
190191
solve_glm = solve_glm_cvxpy
191192
solve_glm_path = solve_glm_path_cvxpy
192193

0 commit comments

Comments
 (0)