Skip to content

Dirichlet::sample() is incorrect #344

@divergentdave

Description

@divergentdave

I noticed that #253 omitted the normalization step when refactoring the sample() method of the Dirichlet distribution. The sum local variable is not used after it is computed. For large dimensions of alpha, the magnitude of sampled vectors is noticeably shorter than those generated by statrs@0.17.1 or scipy.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions