Add unit tests

Author: steevanb

.scrutinizer.yml

@@ -1,5 +1,6 @@
 build:
     environment:
+        # lib require with PHP 7.1 but PHPUnit require 7.2 and Scrutinizer use dev environment
         php: 7.2
 checks:
     php:

bin/phpcs

@@ -11,10 +11,10 @@ if [ $(which docker || false) ]; then
 else
     cd /var/steevanb/php-code-sniffs/vendor/steevanb/php-code-sniffs
     ../../bin/phpcs \
+        --bootstrap=/var/phpcs/phpcs.bootstrap.php \
         --standard=ruleset.xml \
         --report=steevanb\\PhpCodeSniffs\\Reports\\Steevanb \
         --warning-severity=0 \
-        -s \
         --ignore=/var/phpcs/vendor/ \
         /var/phpcs
 fi

changelog.md

@@ -3,3 +3,8 @@
 - Create `steevanb\SymfonyOptionsResolver\OptionsResolver`.
 - Add `OptionsResolver::configureOption()`.
 - Add `OptionsResolver::configureRequiredOption()`.
+- Add CirclecCI build
+- Add phpcs
+- Add phpstan
+- Add phpunit
+- Add Scrutinizer

phpcs.bootstrap.php

@@ -0,0 +1,7 @@
+<?php
+
+declare(strict_types=1);
+
+use steevanb\PhpCodeSniffs\Steevanb\Sniffs\Uses\GroupUsesSniff;
+
+GroupUsesSniff::addSymfonyPrefixes();

phpstan.neon

@@ -2,5 +2,3 @@ parameters:
     level: 5
     paths:
         - src/
-        - tests/
-    ignoreErrors: []

src/OptionsResolver.php

@@ -29,6 +29,7 @@ public function configureRequiredOption(string $name, array $allowedTypes, array
     protected function setAllowedTypesAndValues(string $name, array $allowedTypes, array $allowedValues): self
     {
         $this
+            ->setDefined($name)
             ->setAllowedTypes($name, $allowedTypes)
             ->setAllowedValues($name, $allowedValues);
 

tests/OptionsResolverConfigureOptionTest.php

@@ -0,0 +1,51 @@
+<?php
+
+declare(strict_types=1);
+
+namespace steevanb\SymfonyOptionsResolver\Tests;
+
+use PHPUnit\Framework\TestCase;
+use steevanb\SymfonyOptionsResolver\OptionsResolver;
+use Symfony\Component\OptionsResolver\Exception\InvalidOptionsException;
+
+final class OptionsResolverConfigureOptionTest extends TestCase
+{
+    public function testValid(): void
+    {
+        $this
+            ->createOptionsResolver()
+            ->resolve(['foo' => 'bar']);
+
+        static::addToAssertionCount(1);
+    }
+
+    public function testInvalidType(): void
+    {
+        $optionsResolver = $this->createOptionsResolver();
+
+        static::expectException(InvalidOptionsException::class);
+        $optionsResolver->resolve(['foo' => 1]);
+    }
+
+    public function testInvalidAllowedValue(): void
+    {
+        $optionsResolver = $this->createOptionsResolver();
+
+        static::expectException(InvalidOptionsException::class);
+        $optionsResolver->resolve(['foo' => 'baz']);
+    }
+
+    public function testDefaultValue(): void
+    {
+        $optionsResolver = $this->createOptionsResolver('bar');
+        $optionsResolver->resolve([]);
+
+        static::addToAssertionCount(1);
+    }
+
+    private function createOptionsResolver(string $defaultValue = null): OptionsResolver
+    {
+        return (new OptionsResolver())
+            ->configureOption('foo', ['string'], ['bar'], $defaultValue);
+    }
+}

tests/OptionsResolverConfigureRequiredOptionTest.php

@@ -0,0 +1,54 @@
+<?php
+
+declare(strict_types=1);
+
+namespace steevanb\SymfonyOptionsResolver\Tests;
+
+use PHPUnit\Framework\TestCase;
+use steevanb\SymfonyOptionsResolver\OptionsResolver;
+use Symfony\Component\OptionsResolver\{
+    Exception\InvalidOptionsException,
+    Exception\MissingOptionsException
+};
+
+final class OptionsResolverConfigureRequiredOptionTest extends TestCase
+{
+    public function testValid(): void
+    {
+        $this
+            ->createOptionsResolver()
+            ->resolve(['foo' => 'bar']);
+
+        static::addToAssertionCount(1);
+    }
+
+    public function testInvalidType(): void
+    {
+        $optionsResolver = $this->createOptionsResolver();
+
+        static::expectException(InvalidOptionsException::class);
+        $optionsResolver->resolve(['foo' => 1]);
+    }
+
+    public function testInvalidAllowedValue(): void
+    {
+        $optionsResolver = $this->createOptionsResolver();
+
+        static::expectException(InvalidOptionsException::class);
+        $optionsResolver->resolve(['foo' => 'baz']);
+    }
+
+    public function testRequiredOption(): void
+    {
+        $optionsResolver = $this->createOptionsResolver();
+
+        static::expectException(MissingOptionsException::class);
+        $optionsResolver->resolve([]);
+    }
+
+    private function createOptionsResolver(): OptionsResolver
+    {
+        return (new OptionsResolver())
+            ->configureRequiredOption('foo', ['string'], ['bar']);
+    }
+}