HeatingController_MQTT/ValveController.cpp at main · steffsplace/HeatingController_MQTT · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
#include "ValveController.h"
#include <math.h>

ValveController::ValveController(int openPin, int closePin)
: _openPin(openPin), _closePin(closePin) {}

void ValveController::begin() {
  pinMode(_openPin, OUTPUT);
  pinMode(_closePin, OUTPUT);
  digitalWrite(_openPin, LOW);
  digitalWrite(_closePin, LOW);
}

void ValveController::update(float error) {
  const unsigned long now = millis();

  // Finish movement when elapsed
  if (_state != Idle && (long)(now - _untilMs) >= 0) {
    digitalWrite(_openPin, LOW);
    digitalWrite(_closePin, LOW);
    _state = Idle;
    _lastEndMs = now;
  }

  // If moving or resting, do nothing
  if (_state != Idle) return;
  if ((now - _lastEndMs) < _cycleInterval) return;

  // Deadband ±0.5 °C, proportional pulse 2.0 s/°C clamped 3–20 s
  if (error > 0.5f) {
    int ms = (int)constrain((long)(fabsf(error) * 2000.0f), 3000L, 20000L);
    digitalWrite(_openPin, HIGH);
    digitalWrite(_closePin, LOW);
    _state = MovingOpen;
    _untilMs = now + (unsigned long)ms;
  } else if (error < -0.5f) {
    int ms = (int)constrain((long)(fabsf(error) * 2000.0f), 3000L, 20000L);
    digitalWrite(_openPin, LOW);
    digitalWrite(_closePin, HIGH);
    _state = MovingClose;
    _untilMs = now + (unsigned long)ms;
  }
}