From a5270f27bdc6dc7f7caf881a68d413b25862bfa5 Mon Sep 17 00:00:00 2001 From: Sergi Siso Date: Fri, 17 Apr 2026 16:03:40 +0100 Subject: [PATCH 1/6] Remove NEMO compiler signal 11 exclusions --- examples/nemo/scripts/omp_gpu_trans.py | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/examples/nemo/scripts/omp_gpu_trans.py b/examples/nemo/scripts/omp_gpu_trans.py index 1e3bc3a9af..75a088ff66 100755 --- a/examples/nemo/scripts/omp_gpu_trans.py +++ b/examples/nemo/scripts/omp_gpu_trans.py @@ -98,18 +98,6 @@ # The following issues only affect BENCH (because ice is enabled?) # Runtime Error: Illegal address during kernel execution "trcrad.f90", - # Signal 11 issues - "trcbbl.f90", - "bdyice.f90", - "sedfunc.f90", - "stpmlf.f90", - "trddyn.f90", - "trczdf.f90", - "trcice_pisces.f90", - "dtatsd.f90", - "trcatf.f90", - "stp2d.f90", - "trabbc.f90", ] ASYNC_ISSUES = [ @@ -123,8 +111,6 @@ "zdfsh2.f90", # Diverging results with asynchronicity "traadv_fct.f90", - # Signal 11 in build - "zdfswm.f90", ] From 47d0a2a0937b866449d5d2fa378a6b8a11e43a5c Mon Sep 17 00:00:00 2001 From: Sergi Siso Date: Tue, 21 Apr 2026 11:25:11 +0100 Subject: [PATCH 2/6] Re-introduce some exclusions to avoid nvfortran signal11 --- examples/nemo/scripts/omp_gpu_trans.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/examples/nemo/scripts/omp_gpu_trans.py b/examples/nemo/scripts/omp_gpu_trans.py index 75a088ff66..efd050341f 100755 --- a/examples/nemo/scripts/omp_gpu_trans.py +++ b/examples/nemo/scripts/omp_gpu_trans.py @@ -98,6 +98,9 @@ # The following issues only affect BENCH (because ice is enabled?) # Runtime Error: Illegal address during kernel execution "trcrad.f90", + # Signal 11 issues + "trcatf.f90", + "seddsrjac.f90" ] ASYNC_ISSUES = [ From 13f1aef0260730641d3ea7bb369bb3cccb77d8e7 Mon Sep 17 00:00:00 2001 From: Sergi Siso Date: Thu, 23 Apr 2026 13:57:50 +0100 Subject: [PATCH 3/6] Modify NEMO exclusions --- examples/nemo/scripts/omp_gpu_trans.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/examples/nemo/scripts/omp_gpu_trans.py b/examples/nemo/scripts/omp_gpu_trans.py index efd050341f..f725dba7b6 100755 --- a/examples/nemo/scripts/omp_gpu_trans.py +++ b/examples/nemo/scripts/omp_gpu_trans.py @@ -74,12 +74,14 @@ # List of all files that psyclone will skip processing FILES_TO_SKIP = [ - "icefrm.f90", # Has an unsupported implicit symbol declaration + # Has an implicit symbol declaration (psyclone only works + # with 'implicit none' Fortran + "icefrm.f90", ] NEMOV5_EXCLUSIONS = [ - # get_cssrcsurf produces signal SIGFPE, Arithmetic exception - "sbcclo.f90", + # Excluded in NEMOv5 for performance + "lbclnk.f90", ] NEMOV4_EXCLUSIONS = [ @@ -92,12 +94,10 @@ "iom_def.f90", "timing.f90", "histcom.f90", + "dtatsd.f90", ] OFFLOADING_ISSUES = [ - # The following issues only affect BENCH (because ice is enabled?) - # Runtime Error: Illegal address during kernel execution - "trcrad.f90", # Signal 11 issues "trcatf.f90", "seddsrjac.f90" From dcc64f6f758ff4ccbbcaac334b53d7e4d4781685 Mon Sep 17 00:00:00 2001 From: Sergi Siso Date: Thu, 23 Apr 2026 14:34:04 +0100 Subject: [PATCH 4/6] Reintroduce ASYNC signal 11 exclusion --- examples/nemo/scripts/omp_gpu_trans.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/nemo/scripts/omp_gpu_trans.py b/examples/nemo/scripts/omp_gpu_trans.py index f725dba7b6..1b53e02a8f 100755 --- a/examples/nemo/scripts/omp_gpu_trans.py +++ b/examples/nemo/scripts/omp_gpu_trans.py @@ -114,6 +114,8 @@ "zdfsh2.f90", # Diverging results with asynchronicity "traadv_fct.f90", + # Signal 11 in build + "zdfswm.f90", ] From cf8cebe552ed4ec2e64a2d88d05b94aaf2f1ac7d Mon Sep 17 00:00:00 2001 From: Sergi Siso Date: Thu, 23 Apr 2026 15:34:55 +0100 Subject: [PATCH 5/6] Fix comments --- examples/nemo/scripts/omp_gpu_trans.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/nemo/scripts/omp_gpu_trans.py b/examples/nemo/scripts/omp_gpu_trans.py index 1b53e02a8f..dc5c078252 100755 --- a/examples/nemo/scripts/omp_gpu_trans.py +++ b/examples/nemo/scripts/omp_gpu_trans.py @@ -75,12 +75,12 @@ # List of all files that psyclone will skip processing FILES_TO_SKIP = [ # Has an implicit symbol declaration (psyclone only works - # with 'implicit none' Fortran + # with 'implicit none' Fortran) "icefrm.f90", ] NEMOV5_EXCLUSIONS = [ - # Excluded in NEMOv5 for performance + # Excluded only in NEMOv5 for performance "lbclnk.f90", ] From 8b3e2357e185f04b0f76c006e9245414215a2cb8 Mon Sep 17 00:00:00 2001 From: LonelyCat124 <3043914+LonelyCat124@users.noreply.github.com.> Date: Fri, 24 Apr 2026 10:31:20 +0100 Subject: [PATCH 6/6] #3279 update changelog --- changelog | 3 +++ 1 file changed, 3 insertions(+) diff --git a/changelog b/changelog index 2200b1cc57..24a15f5876 100644 --- a/changelog +++ b/changelog @@ -1,3 +1,6 @@ + 11) PR #3414 for #3279. Update the lists of exclusions to improve GPU + performance for NEMO. + 10) PR #3413 for #3411. Remove OpenMP SUB reduction operator and relpace with ADD as is required by OpenMP 5.2.