refactor: Consolidate agents and remove mock data

This commit refactors the security agent by merging the functionality of `enhanced_agent.py` into `agent.py`, creating a single, comprehensive agent.

Key changes:
- Merged API Hub, dependency analysis, and risk propagation tools into the main agent.
- Removed mock data fallbacks from `frontend/enhanced_security_agent_app.py` and `backend/api/gcp.py` to ensure robust error handling.
- Stabilized the `run.sh` script by removing the `--reload` flag and improving the Streamlit command.
- Deleted the redundant `agents/enhanced_agent.py`.

These changes improve maintainability and align the application with the "no mock data" core principle.

💘 Generated with Crush
Co-Authored-By: Crush <crush@charm.land>

Author: stuagano

.gitignore

@@ -76,6 +76,8 @@ wheels/
 *.log
 logs/
 log/
+src/google/adk/a2a/logs/
+
 
 # Local development settings
 .env.local
@@ -98,3 +100,10 @@ Thumbs.db
 *.bak
 *.tmp
 *.temp
+.crush/
+
+# Media files
+*.png
+*.pdf
+
+

contributing/samples/personal_assistant_agent/cloudbuild.yaml

@@ -209,26 +209,4 @@ substitutions:
 
 # Images to be pushed
 images:
-  - '${_AR_IMAGE}'
-
-# Build triggers configuration
-# This section is used when setting up automated triggers
-# but is not processed during manual builds
-trigger:
-  name: 'personal-assistant-agent-trigger'
-  description: 'Automated deployment trigger for Personal Assistant Agent'
-  github:
-    owner: 'your-username'
-    name: 'your-repo-name'
-    push:
-      branch: '^main$'
-  substitutions:
-    _REGION: 'us-central1'
-    _SERVICE_NAME: 'personal-assistant-agent'
-    _ENVIRONMENT: 'production'
-  includedFiles:
-    - 'ADK/contributing/samples/personal_assistant_agent/**'
-  ignoredFiles:
-    - '**/*.md'
-    - '**/README.md'
-    - '**/*.txt' 
+  - '${_AR_IMAGE}' 

contributing/samples/security_agent/.cursorrules

@@ -1,4 +1,30 @@
 # Enhanced GCP Security Agent - Cursor Rules
+# ALWAYS USE VERTEX AI AND CLOUD RUN FOR ALL OPERATIONS
+
+## Google Cloud Platform Architecture Requirements
+
+### Vertex AI Integration
+- **ALWAYS use Vertex AI for all LLM operations** - Never use Google AI API directly
+- Use Application Default Credentials (ADC) for authentication to Vertex AI
+- Set GOOGLE_CLOUD_PROJECT and GOOGLE_CLOUD_LOCATION environment variables
+- Use `gemini-2.0-flash-exp` model through Vertex AI endpoints
+- All ADK agents MUST be configured to use Vertex AI backend
+- Never pass api_key parameter to Agent constructor - use ADC only
+
+### Cloud Run Deployment Strategy
+- **Target Cloud Run for all deployment scenarios**
+- Configure containerized applications with proper health checks
+- Use Cloud Run service-to-service authentication
+- Implement proper resource limits and scaling policies
+- Configure VPC connector for secure communication
+- Use Cloud Run jobs for batch processing tasks
+
+### Authentication and Authorization
+- **MANDATORY: Use Application Default Credentials (ADC) everywhere**
+- Configure service accounts with least privilege access
+- Use Cloud IAM roles for fine-grained permissions
+- Implement proper OIDC token validation for service-to-service calls
+- Never hardcode API keys or credentials in code
 
 ## Core Development Principles
 
@@ -64,6 +90,23 @@
 - Handle timeout scenarios gracefully
 - Display meaningful error messages to users
 
+### Google Cloud Services Integration
+- **Use Vertex AI for all LLM/Agent operations** - set model='gemini-2.0-flash-exp'
+- Use Cloud Run for hosting both frontend (Streamlit) and backend (FastAPI)
+- Use Cloud Storage for file uploads and data persistence
+- Use Cloud Trace for OpenTelemetry distributed tracing
+- Use Cloud Logging for application logs and monitoring
+- Use Cloud IAM for service authentication and authorization
+- Use Cloud Secret Manager for sensitive configuration data
+
+### Container and Deployment Configuration
+- Create Dockerfile for both frontend and backend services
+- Use multi-stage builds for optimized container images
+- Configure Cloud Run services with proper CPU/memory limits
+- Set up proper environment variable management
+- Implement graceful shutdown handling
+- Configure liveness and readiness probes
+
 ## Code Quality Standards
 
 ### Error Handling

contributing/samples/security_agent/.gitignore

@@ -50,6 +50,7 @@ coverage.xml
 *.py,cover
 .hypothesis/
 .pytest_cache/
+.streamlit/
 
 # Distribution / packaging
 .Python
@@ -82,6 +83,10 @@ log/
 .env.development.local
 .env.test.local
 .env.production.local
+/Users/stuartgano/Desktop/Micron/ADK/contributing/samples/security_agent/CLAUDE.md
+/Users/stuartgano/Desktop/Micron/ADK/contributing/samples/security_agent/run.log
+.cursorrules
+/Users/stuartgano/Desktop/Micron/ADK/contributing/samples/security_agent/=1.31.0
 
 # Google Cloud specific
 .gcloudignore
@@ -96,4 +101,5 @@ site/
 Thumbs.db
 *.bak
 *.tmp
-*.temp 
+*.temp
+.crush/

contributing/samples/security_agent/=1.31.0

@@ -0,0 +1,4 @@
+Requirement already satisfied: opentelemetry-api in /Users/stuartgano/Desktop/Micron/ADK/venv/lib/python3.13/site-packages (1.36.0)
+Requirement already satisfied: importlib-metadata<8.8.0,>=6.0 in /Users/stuartgano/Desktop/Micron/ADK/venv/lib/python3.13/site-packages (from opentelemetry-api) (6.11.0)
+Requirement already satisfied: typing-extensions>=4.5.0 in /Users/stuartgano/Desktop/Micron/ADK/venv/lib/python3.13/site-packages (from opentelemetry-api) (4.14.0)
+Requirement already satisfied: zipp>=0.5 in /Users/stuartgano/Desktop/Micron/ADK/venv/lib/python3.13/site-packages (from importlib-metadata<8.8.0,>=6.0->opentelemetry-api) (3.22.0)

contributing/samples/security_agent/CRUSH.md

@@ -0,0 +1,26 @@
+# CRUSH.md - Codebase Guidelines
+
+## Build/Test/Lint Commands
+
+- **Install Dependencies**: `pip install -r requirements.txt` (and for `backend/requirements.txt`)
+- **Run All Tests**: `pytest` or `./scripts/run_tests.py`
+- **Run Single Test**: `pytest <path_to_test_file>::<test_function_name>`
+- **Format Code**: `./autoformat.sh` (uses Black and Ruff)
+- **Lint/Typecheck**: `ruff check .`
+
+## Code Style Guidelines
+
+- **General Python**: Adhere to PEP 8 for naming and formatting.
+- **Imports**: Alphabetical and grouped (e.g., `isort` style).
+- **Formatting**: Automated via `./autoformat.sh` (Black, Ruff). Consistent indentation (4 spaces).
+- **Types**: Use Python type hints for all functions and variables.
+- **Naming**: Descriptive function, variable, and class names (e.g., `snake_case` for functions/variables, `PascalCase` for classes).
+- **Error Handling**: Implement comprehensive `try-except` blocks for external API calls. Provide clear error messages; log errors.
+- **Comments**: Sparse, focus on *why* complex logic exists.
+
+## Project-Specific Rules (from .cursorrules & CLAUDE.md)
+
+- **Vertex AI**: ALWAYS use Vertex AI (`gemini-2.0-flash-exp` model), never pass `api_key` to Agent (use ADC).
+- **Cloud Run**: ALWAYS target Cloud Run for deployment.
+- **Authentication**: MANDATORY to use Application Default Credentials (ADC) and service accounts. Never hardcode credentials.
+- **No Mock Data**: NEVER use mock, fallback, or placeholder data. Return real errors.

contributing/samples/security_agent/Dockerfile.backend

@@ -0,0 +1,50 @@
+# Multi-stage build for optimized backend container
+FROM python:3.11-slim as builder
+
+# Install system dependencies
+RUN apt-get update && apt-get install -y \
+    gcc \
+    g++ \
+    && rm -rf /var/lib/apt/lists/*
+
+WORKDIR /app
+
+# Copy requirements and install dependencies
+COPY requirements.txt .
+RUN pip install --user --no-cache-dir -r requirements.txt
+
+# Production stage
+FROM python:3.11-slim
+
+# Install system dependencies for runtime
+RUN apt-get update && apt-get install -y \
+    curl \
+    && rm -rf /var/lib/apt/lists/*
+
+WORKDIR /app
+
+# Copy installed packages from builder stage
+COPY --from=builder /root/.local /root/.local
+
+# Make sure scripts in .local are usable
+ENV PATH=/root/.local/bin:$PATH
+
+# Copy application code
+COPY backend/ ./backend/
+COPY agents/ ./agents/
+COPY .env .env
+
+# Set environment variables for Vertex AI
+ENV GOOGLE_CLOUD_PROJECT=mgm-digitalconcierge
+ENV GOOGLE_CLOUD_LOCATION=us-central1
+ENV PYTHONPATH=/app
+
+# Expose port
+EXPOSE 8000
+
+# Health check
+HEALTHCHECK --interval=30s --timeout=30s --start-period=5s --retries=3 \
+    CMD curl -f http://localhost:8000/health || exit 1
+
+# Run the application
+CMD ["uvicorn", "backend.main:app", "--host", "0.0.0.0", "--port", "8000"]

contributing/samples/security_agent/Dockerfile.frontend

@@ -0,0 +1,49 @@
+# Multi-stage build for optimized frontend container
+FROM python:3.11-slim as builder
+
+# Install system dependencies
+RUN apt-get update && apt-get install -y \
+    gcc \
+    g++ \
+    && rm -rf /var/lib/apt/lists/*
+
+WORKDIR /app
+
+# Copy requirements and install dependencies
+COPY requirements.txt .
+RUN pip install --user --no-cache-dir -r requirements.txt
+
+# Production stage
+FROM python:3.11-slim
+
+# Install system dependencies for runtime
+RUN apt-get update && apt-get install -y \
+    curl \
+    && rm -rf /var/lib/apt/lists/*
+
+WORKDIR /app
+
+# Copy installed packages from builder stage
+COPY --from=builder /root/.local /root/.local
+
+# Make sure scripts in .local are usable
+ENV PATH=/root/.local/bin:$PATH
+
+# Copy application code
+COPY frontend/ ./frontend/
+COPY .env .env
+
+# Set environment variables
+ENV GOOGLE_CLOUD_PROJECT=mgm-digitalconcierge
+ENV GOOGLE_CLOUD_LOCATION=us-central1
+ENV BACKEND_URL=https://security-agent-backend-xxx-uc.a.run.app
+
+# Expose port
+EXPOSE 8501
+
+# Health check
+HEALTHCHECK --interval=30s --timeout=30s --start-period=5s --retries=3 \
+    CMD curl -f http://localhost:8501/_stcore/health || exit 1
+
+# Run the application
+CMD ["streamlit", "run", "frontend/enhanced_security_agent_app.py", "--server.port=8501", "--server.address=0.0.0.0"]