Merge pull request #13 from studyplus/add_duration_checker

StudyplusRecordのdurationプロパティへ24時間上限を追加

Author: m-yamada04

CHANGELOG.md

@@ -1,3 +1,18 @@
+1.3.1 Release notes (2019-06-17)
+=============================================================
+
+### API Breaking Changes
+
+* None.
+
+### Enhancements
+
+* added lower than 24 hours validation when post study record.
+
+### Bugfixes
+
+* None.
+
 1.3.0 Release notes (2019-04-09)
 =============================================================
 

Demo/Info.plist

@@ -15,7 +15,7 @@
 	<key>CFBundlePackageType</key>
 	<string>APPL</string>
 	<key>CFBundleShortVersionString</key>
-	<string>1.3.0</string>
+	<string>1.3.1</string>
 	<key>CFBundleURLTypes</key>
 	<array>
 		<dict>

StudyplusSDK-V2.podspec

@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name                  = "StudyplusSDK-V2"
-  s.version               = "1.3.0"
+  s.version               = "1.3.1"
   s.summary               = "StudyplusSDK-V2 is Studyplus iOS SDK for Swift"
   s.homepage              = "http://info.studyplus.jp"
   s.license               = { :type => "MIT", :file => "LICENSE" }

StudyplusSDK/Info.plist

@@ -15,7 +15,7 @@
 	<key>CFBundlePackageType</key>
 	<string>FMWK</string>
 	<key>CFBundleShortVersionString</key>
-	<string>1.3.0</string>
+	<string>1.3.1</string>
 	<key>CFBundleVersion</key>
 	<string>$(CURRENT_PROJECT_VERSION)</string>
 	<key>NSPrincipalClass</key>

StudyplusSDK/Studyplus.swift

@@ -152,6 +152,11 @@ final public class Studyplus {
     ///   - failure: callback when failure to post the studyRecord
     public func post(studyRecord: StudyplusRecord, success: @escaping () -> Void, failure: @escaping (_ error: StudyplusError) -> Void) {
 
+        guard StudyplusRecord.durationRange ~= Int(studyRecord.duration) else {
+            failure(.postRecordFailed)
+            return
+        }
+        
         if !self.isConnected() {
             failure(.notConnected)
             return

StudyplusSDK/StudyplusRecord.swift

@@ -69,6 +69,8 @@ private extension Date {
  Studyplusに投稿する一件の勉強記録を表現するクラスです。
  */
 public struct StudyplusRecord {
+    
+    static let durationRange = 0...(24 * 60 * 60)
 
     /**
      The seconds of the learning.
@@ -102,6 +104,8 @@ public struct StudyplusRecord {
     ///
     /// - Parameters:
     ///   - duration: Specify the seconds of the learning. 勉強した時間（秒数）を指定してください。
+    ///     - min: 0
+    ///     - max: 86400 (24h)
     ///   - recordedAt: Time the learning is ended. 学習を終えた日時。
     ///   - amount: The amount of learning. 学習量。
     ///   - comment: Studyplus timeline comment. Studyplusのタイムライン上で表示されるコメント。