Refactor StudyplusLoginDelegate

Author: koji-1009

Lib/StudyplusSDK/Studyplus.swift

@@ -148,7 +148,7 @@ final public class Studyplus {
     ///     __[studyplus-{consumerKey}]__と正しいpathComponentsを持つことを確認してください。
     public func handle(_ url: URL) -> Bool {
         guard isAcceptableURL(url: url) else {
-            delegate?.studyplusDidFailToLogin(error: .unknownUrl(url))
+            delegate?.studyplusLoginFail(error: .unknownUrl(url))
             return false
         }
 
@@ -168,15 +168,15 @@ final public class Studyplus {
                                   username: username) { result in
                 switch result {
                 case .failure(let error):
-                    self.delegate?.studyplusDidFailToLogin(error: error)
+                    self.delegate?.studyplusLoginFail(error: error)
                 case .success:
-                    self.delegate?.studyplusDidSuccessToLogin()
+                    self.delegate?.studyplusLoginSuccess()
                 }
             }
         case "fail":
-            delegate?.studyplusDidFailToLogin(error: .fail)
+            delegate?.studyplusLoginFail(error: .applicationError)
         case "cancel":
-            delegate?.studyplusDidFailToLogin(error: .cancel)
+            delegate?.studyplusLoginFail(error: .cancel)
         default:
             return false
         }

Lib/StudyplusSDK/StudyplusError.swift

@@ -52,6 +52,6 @@ public enum StudyplusPostError: Error {
 public enum StudyplusLoginError: Error {
     case unknownUrl(_ url: URL)
     case keychainError
-    case fail
+    case applicationError
     case cancel
 }

Lib/StudyplusSDK/StudyplusLoginDelegate.swift

@@ -26,22 +26,7 @@
 
 import Foundation
 
-/**
- The delegate to receive callbacks from Studyplus.
-
- Studyplusオブジェクトに対する各種操作後のコールバックを受けるdelegateです。
- */
-public protocol StudyplusLoginDelegate: class {
-
-    /// Will be called after the Studyplus#login was successful.
-    ///
-    /// Studyplus#login が成功した後に呼ばれます。
-    func studyplusDidSuccessToLogin()
-
-    /// Will be called after the Studyplus#login was failure.
-    ///
-    /// Studyplus#login が失敗した後に呼ばれます。
-    ///
-    /// - Parameter error: failure reason, see StudyplusError. 失敗の理由です。詳細は StudyplusError を参照してください。
-    func studyplusDidFailToLogin(error: StudyplusLoginError)
+public protocol StudyplusLoginDelegate: AnyObject {
+    func studyplusLoginSuccess()
+    func studyplusLoginFail(error: StudyplusLoginError)
 }