Skip to content

Commit 04e30ef

Browse files
sudiptpaStyleCIBot
authored andcommitted
Applied fixes from StyleCI
1 parent dfeb46b commit 04e30ef

9 files changed

+53
-45
lines changed

src/DirectPostGateway.php

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
use Omnipay\Common\AbstractGateway;
66

77
/**
8-
* NABTransact Direct Post Gateway
8+
* NABTransact Direct Post Gateway.
99
*/
1010
class DirectPostGateway extends AbstractGateway
1111
{
@@ -22,9 +22,9 @@ public function getName()
2222
public function getDefaultParameters()
2323
{
2424
return array(
25-
'merchantId' => '',
25+
'merchantId' => '',
2626
'transactionPassword' => '',
27-
'testMode' => false,
27+
'testMode' => false,
2828
);
2929
}
3030

@@ -38,6 +38,7 @@ public function getMerchantId()
3838

3939
/**
4040
* @param $value
41+
*
4142
* @return mixed
4243
*/
4344
public function setMerchantId($value)
@@ -55,6 +56,7 @@ public function getTransactionPassword()
5556

5657
/**
5758
* @param $value
59+
*
5860
* @return mixed
5961
*/
6062
public function setTransactionPassword($value)
@@ -64,6 +66,7 @@ public function setTransactionPassword($value)
6466

6567
/**
6668
* @param array $parameters
69+
*
6770
* @return mixed
6871
*/
6972
public function authorize(array $parameters = array())
@@ -73,6 +76,7 @@ public function authorize(array $parameters = array())
7376

7477
/**
7578
* @param array $parameters
79+
*
7680
* @return mixed
7781
*/
7882
public function completeAuthorize(array $parameters = array())
@@ -82,6 +86,7 @@ public function completeAuthorize(array $parameters = array())
8286

8387
/**
8488
* @param array $parameters
89+
*
8590
* @return mixed
8691
*/
8792
public function purchase(array $parameters = array())
@@ -91,6 +96,7 @@ public function purchase(array $parameters = array())
9196

9297
/**
9398
* @param array $parameters
99+
*
94100
* @return mixed
95101
*/
96102
public function completePurchase(array $parameters = array())

src/Message/DirectPostAbstractRequest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
namespace Omnipay\NABTransact\Message;
44

55
/**
6-
* NABTransact Direct Post Abstract Request
6+
* NABTransact Direct Post Abstract Request.
77
*/
88
abstract class DirectPostAbstractRequest extends AbstractRequest
99
{

src/Message/DirectPostAuthorizeRequest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
namespace Omnipay\NABTransact\Message;
44

55
/**
6-
* NABTransact Direct Post Authorize Request
6+
* NABTransact Direct Post Authorize Request.
77
*/
88
class DirectPostAuthorizeRequest extends DirectPostAbstractRequest
99
{
@@ -59,6 +59,7 @@ public function generateFingerprint(array $data)
5959

6060
/**
6161
* @param $data
62+
*
6263
* @return mixed
6364
*/
6465
public function sendData($data)

src/Message/DirectPostAuthorizeResponse.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
use Omnipay\Common\Message\RequestInterface;
88

99
/**
10-
* NABTransact Direct Post Authorize Response
10+
* NABTransact Direct Post Authorize Response.
1111
*/
1212
class DirectPostAuthorizeResponse extends AbstractResponse implements RedirectResponseInterface
1313
{

src/Message/DirectPostCompletePurchaseRequest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
use Omnipay\Common\Exception\InvalidRequestException;
66

77
/**
8-
* NABTransact Direct Post Complete Purchase Request
8+
* NABTransact Direct Post Complete Purchase Request.
99
*/
1010
class DirectPostCompletePurchaseRequest extends DirectPostAbstractRequest
1111
{
@@ -45,6 +45,7 @@ public function generateResponseFingerprint($data)
4545

4646
/**
4747
* @param $data
48+
*
4849
* @return mixed
4950
*/
5051
public function sendData($data)

src/Message/DirectPostCompletePurchaseResponse.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
use Omnipay\Common\Message\AbstractResponse;
66

77
/**
8-
* NABTransact Direct Post Complete Purchase Response
8+
* NABTransact Direct Post Complete Purchase Response.
99
*/
1010
class DirectPostCompletePurchaseResponse extends AbstractResponse
1111
{

src/Message/DirectPostPurchaseRequest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
namespace Omnipay\NABTransact\Message;
44

55
/**
6-
* NABTransact Direct Post Purchase Request
6+
* NABTransact Direct Post Purchase Request.
77
*/
88
class DirectPostPurchaseRequest extends DirectPostAuthorizeRequest
99
{

tests/Message/DirectPostAuthorizeRequestTest.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@ public function setUp()
1212

1313
$this->request->initialize(
1414
array(
15-
'merchantId' => 'foo',
15+
'merchantId' => 'foo',
1616
'transactionPassword' => 'bar',
17-
'amount' => '12.00',
18-
'returnUrl' => 'https://www.abc.com/return',
19-
'card' => array(
20-
'number' => '4444333322221111',
17+
'amount' => '12.00',
18+
'returnUrl' => 'https://www.abc.com/return',
19+
'card' => array(
20+
'number' => '4444333322221111',
2121
'expiryMonth' => '6',
22-
'expiryYear' => '2030',
23-
'cvv' => '123',
22+
'expiryYear' => '2030',
23+
'cvv' => '123',
2424
),
2525
)
2626
);

tests/Message/DirectPostCompletePurchaseRequestTest.php

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,14 @@ public function setUp()
1414
public function testGenerateResponseFingerprint()
1515
{
1616
$this->request->initialize(array(
17-
'amount' => '465.18',
17+
'amount' => '465.18',
1818
'transactionPassword' => 'abc123',
1919
));
2020

2121
$data = array(
22-
'timestamp' => '20130602102927',
23-
'merchant' => 'ABC0030',
24-
'refid' => '222',
22+
'timestamp' => '20130602102927',
23+
'merchant' => 'ABC0030',
24+
'refid' => '222',
2525
'summarycode' => '2',
2626
);
2727

@@ -31,23 +31,23 @@ public function testGenerateResponseFingerprint()
3131
public function testSuccess()
3232
{
3333
$this->request->initialize(array(
34-
'amount' => '355.00',
34+
'amount' => '355.00',
3535
'transactionPassword' => 'abc123',
3636
));
3737

3838
$this->getHttpRequest()->query->replace(array(
39-
'timestamp' => '20130602112954',
39+
'timestamp' => '20130602112954',
4040
'callback_status_code' => '',
41-
'fingerprint' => 'd9b40fc6f841f41ef3475220fe6316406a5256ce',
42-
'txnid' => '205861',
43-
'merchant' => 'ABC0030',
44-
'restext' => 'Approved',
45-
'rescode' => '00',
46-
'expirydate' => '032016',
47-
'settdate' => '20130602',
48-
'refid' => '226',
49-
'pan' => '444433...111',
50-
'summarycode' => '1',
41+
'fingerprint' => 'd9b40fc6f841f41ef3475220fe6316406a5256ce',
42+
'txnid' => '205861',
43+
'merchant' => 'ABC0030',
44+
'restext' => 'Approved',
45+
'rescode' => '00',
46+
'expirydate' => '032016',
47+
'settdate' => '20130602',
48+
'refid' => '226',
49+
'pan' => '444433...111',
50+
'summarycode' => '1',
5151
));
5252

5353
$response = $this->request->send();
@@ -64,23 +64,23 @@ public function testSuccess()
6464
public function testFailure()
6565
{
6666
$this->request->initialize(array(
67-
'amount' => '465.18',
67+
'amount' => '465.18',
6868
'transactionPassword' => 'abc123',
6969
));
7070

7171
$this->getHttpRequest()->query->replace(array(
72-
'timestamp' => '20130602102927',
72+
'timestamp' => '20130602102927',
7373
'callback_status_code' => '',
74-
'fingerprint' => '0516a31bf96ad89c354266afb9bd4be43aaf853f',
75-
'txnid' => '205833',
76-
'merchant' => 'ABC0030',
77-
'restext' => 'Customer Dispute',
78-
'rescode' => '18',
79-
'expirydate' => '052016',
80-
'settdate' => '20130602',
81-
'refid' => '222',
82-
'pan' => '444433...111',
83-
'summarycode' => '2',
74+
'fingerprint' => '0516a31bf96ad89c354266afb9bd4be43aaf853f',
75+
'txnid' => '205833',
76+
'merchant' => 'ABC0030',
77+
'restext' => 'Customer Dispute',
78+
'rescode' => '18',
79+
'expirydate' => '052016',
80+
'settdate' => '20130602',
81+
'refid' => '222',
82+
'pan' => '444433...111',
83+
'summarycode' => '2',
8484
));
8585

8686
$response = $this->request->send();
@@ -93,4 +93,4 @@ public function testFailure()
9393
$this->assertSame('Customer Dispute', $response->getMessage());
9494
$this->assertSame('18', $response->getCode());
9595
}
96-
}
96+
}

0 commit comments

Comments
 (0)