fix: rebase on develop and fix code api changes from nixpkgs

samrose · yvan-sraka · commit 0f388c4f19d5 · 2025-11-25T16:52:37.000+01:00
diff --git a/nix/cargo-pgrx/default.nix b/nix/cargo-pgrx/default.nix
@@ -1,6 +1,6 @@
 {
   lib,
-  darwin,
+  apple-sdk_11,
   fetchCrate,
   openssl,
   pkg-config,
@@ -36,7 +36,7 @@ let
       nativeBuildInputs = lib.optionals stdenv.hostPlatform.isLinux [ pkg-config ];
       buildInputs =
         lib.optionals stdenv.hostPlatform.isLinux [ openssl ]
-        ++ lib.optionals stdenv.hostPlatform.isDarwin [ darwin.apple_sdk.frameworks.Security ];
+        ++ lib.optionals stdenv.hostPlatform.isDarwin [ apple-sdk_11 ];
 
       OPENSSL_DIR = "${openssl.dev}";
       OPENSSL_INCLUDE_DIR = "${openssl.dev}/include";
diff --git a/nix/checks.nix b/nix/checks.nix
@@ -2,7 +2,6 @@
 {
   perSystem =
     {
-      lib,
       self',
       system,
       pkgs,
diff --git a/nix/ext/plv8.nix b/nix/ext/plv8.nix
@@ -9,7 +9,7 @@
   # to nixpkgs
   clang,
   xcbuild,
-  darwin,
+  apple-sdk_11,
   patchelf,
 }:
 let
@@ -50,8 +50,7 @@ stdenv.mkDerivation (finalAttrs: {
     postgresql
   ]
   ++ lib.optionals stdenv.isDarwin [
-    darwin.apple_sdk.frameworks.CoreFoundation
-    darwin.apple_sdk.frameworks.Kerberos
+    apple-sdk_11
   ];
 
   buildFlags = [ "all" ];
@@ -77,10 +76,8 @@ stdenv.mkDerivation (finalAttrs: {
       "-lpq"
       "-lpgcommon"
       "-lpgport"
-      "-F${darwin.apple_sdk.frameworks.CoreFoundation}/Library/Frameworks"
       "-framework"
       "CoreFoundation"
-      "-F${darwin.apple_sdk.frameworks.Kerberos}/Library/Frameworks"
       "-framework"
       "Kerberos"
       "-undefined"
diff --git a/nix/ext/postgis.nix b/nix/ext/postgis.nix
@@ -48,32 +48,9 @@ let
     "postgis_topology"
   ];
 
-<<<<<<< HEAD
   sqlExtensions = [
     "address_standardizer_data_us"
     "postgis_tiger_geocoder"
-=======
-  src = fetchurl {
-    url = "https://download.osgeo.org/postgis/source/postgis-${version}.tar.gz";
-    sha256 = "sha256-UHJKDd5JrcJT5Z4CTYsY/va+ToU0GUPG1eHhuXTkP84=";
-  };
-
-  buildInputs = [
-    libxml2
-    postgresql
-    geos
-    proj
-    gdal
-    json_c
-    protobufc
-    pcre2.dev
-    sfcgal
-  ]
-  ++ lib.optional stdenv.isDarwin libiconv;
-  nativeBuildInputs = [
-    perl
-    pkg-config
->>>>>>> 4847adac (chore: update fmt)
   ];
 
   # Build function for individual versions
diff --git a/nix/ext/tests/lib.py b/nix/ext/tests/lib.py
@@ -84,9 +84,9 @@ def assert_version_matches(self, expected_version: str):
             AssertionError: If the installed version does not match the expected version
         """
         installed_version = self.get_installed_version()
-        assert (
-            installed_version == expected_version
-        ), f"Expected version {expected_version}, but found {installed_version}"
+        assert installed_version == expected_version, (
+            f"Expected version {expected_version}, but found {installed_version}"
+        )
 
     def check_upgrade_path(self, pg_version: str):
         """Test the complete upgrade path for a PostgreSQL version.
@@ -172,37 +172,6 @@ def check_switch_extension_with_background_worker(
         self.vm.succeed(f"switch_{self.extension_name}_version {last_version}")
         # Check that we are using the last version now
         ext_version = self.vm.succeed(f"readlink -f {extension_lib_path}").strip()
-        assert ext_version.endswith(
-            f"{last_version}.so"
-        ), f"Expected {self.extension_name} version {last_version}, but found {ext_version}"
-
-    def check_pg_regress(self, pg_regress: Path, pg_version: str, test_name: str):
-        """Run pg_regress tests for the extension on a given PostgreSQL version.
-
-        Args:
-            pg_regress: Path to the pg_regress binary
-            pg_version: PostgreSQL version to test (e.g., "14", "15")
-            test_name: SQL test file to run with pg_regress
-        """
-        sql_file = self.sql_test_dir / "sql" / f"{test_name}.sql"
-        if not sql_file.exists():
-            # check if we have a postgres version specific sql file
-            test_name = f"z_{pg_version}_{test_name}"
-            sql_file = self.sql_test_dir / "sql" / f"{test_name}.sql"
-            if not sql_file.exists():
-                print(f"Skipping pg_regress test for {pg_version}, no sql file found")
-                return
-        try:
-            print(
-                self.vm.succeed(
-                    f"""sudo -u postgres {pg_regress} --inputdir={self.sql_test_dir} --debug --use-existing --dbname=postgres --outputdir=/tmp/regression_output_{pg_version} "{test_name}" """
-                )
-            )
-        except:
-            print("Error running pg_regress, diff:")
-            print(
-                self.vm.succeed(
-                    f"cat /tmp/regression_output_{pg_version}/regression.diffs"
-                )
-            )
-            raise
+        assert ext_version.endswith(f"{self.extension_name}-{last_version}.so"), (
+            f"Expected {self.extension_name} version {last_version}, but found {ext_version}"
+        )
diff --git a/nix/ext/wrappers/default.nix b/nix/ext/wrappers/default.nix
@@ -7,7 +7,7 @@
   pkg-config,
   postgresql,
   buildEnv,
-  darwin,
+  apple-sdk_11,
   rust-bin,
   git,
 }:
@@ -42,9 +42,7 @@ let
           postgresql
         ]
         ++ lib.optionals stdenv.isDarwin [
-          darwin.apple_sdk.frameworks.CoreFoundation
-          darwin.apple_sdk.frameworks.Security
-          darwin.apple_sdk.frameworks.SystemConfiguration
+          apple-sdk_11
         ];
 
         NIX_LDFLAGS = "-L${postgresql}/lib -lpq";
diff --git a/nix/overlays/default.nix b/nix/overlays/default.nix
@@ -19,7 +19,7 @@
 
     cargo-pgrx = final.callPackage ../cargo-pgrx/default.nix {
       inherit (final) lib;
-      inherit (final) darwin;
+      inherit (final) apple-sdk_11;
       inherit (final) fetchCrate;
       inherit (final) openssl;
       inherit (final) pkg-config;
diff --git a/nix/packages/packer.nix b/nix/packages/packer.nix
@@ -33,8 +33,7 @@ buildGoModule rec {
   nativeBuildInputs = [ installShellFiles ];
 
   buildInputs = lib.optionals pkgs.stdenv.isDarwin [
-    pkgs.darwin.apple_sdk.frameworks.IOKit
-    pkgs.darwin.apple_sdk.frameworks.Security
+    pkgs.apple-sdk_11
   ];
 
   postInstall = ''
diff --git a/nix/postgresql/generic.nix b/nix/postgresql/generic.nix
@@ -7,7 +7,6 @@ let
       stdenv,
       lib,
       fetchurl,
-      fetchpatch,
       makeWrapper,
       glibc,
       zlib,
@@ -115,7 +114,7 @@ let
         zlib
         readline
         openssl
-        (libxml2.override { python = python3; })
+        (libxml2.override { python3 = python3; })
         icu
       ]
       ++ lib.optionals (olderThan "13") [ libxcrypt ]
@@ -192,20 +191,21 @@ let
           locale = "${if stdenv.isDarwin then darwin.adv_cmds else lib.getBin stdenv.cc.libc}/bin/locale";
         })
       ]
-      ++ lib.optionals (olderThan "17") [
-        # back port changes related to tzdata release 2024b
-        (fetchpatch ({
-          url = "https://github.com/postgres/postgres/commit/b27622c90869aab63cfe22159a459c57768b0fa4.patch";
-          hash = "sha256-7G+BkJULhyx6nlMEjClcr2PJg6awgymZHr2JgGhXanA=";
-          excludes = [ "doc/*" ];
-        }))
-        # back port changes related to tzdata release 2025a
-        (fetchpatch ({
-          url = "https://github.com/postgres/postgres/commit/aac0384975ff1129557cd2158fab4656f933cdc8.patch";
-          hash = "sha256-4Aua4QJhCS9B0zegQ9I6Us5QfX7GuRUilnkmOpSTUUw=";
-          excludes = [ "doc/*" ];
-        }))
-      ]
+      # tzdata patches temporarily removed due to conflicts with PostgreSQL 15.14
+      # ++ lib.optionals (olderThan "17") [
+      #   # back port changes related to tzdata release 2024b
+      #   (fetchpatch ({
+      #     url = "https://github.com/postgres/postgres/commit/b27622c90869aab63cfe22159a459c57768b0fa4.patch";
+      #     hash = "sha256-7G+BkJULhyx6nlMEjClcr2PJg6awgymZHr2JgGhXanA=";
+      #     excludes = [ "doc/*" ];
+      #   }))
+      #   # back port changes related to tzdata release 2025a
+      #   (fetchpatch ({
+      #     url = "https://github.com/postgres/postgres/commit/aac0384975ff1129557cd2158fab4656f933cdc8.patch";
+      #     hash = "sha256-4Aua4QJhCS9B0zegQ9I6Us5QfX7GuRUilnkmOpSTUUw=";
+      #     excludes = [ "doc/*" ];
+      #   }))
+      # ]
       ++ lib.optionals stdenv'.hostPlatform.isMusl (
         # Using fetchurl instead of fetchpatch on purpose: https://github.com/NixOS/nixpkgs/issues/240141
         map fetchurl (lib.attrValues muslPatches)
diff --git a/testinfra/test_ami_nix.py b/testinfra/test_ami_nix.py
@@ -427,9 +427,9 @@ def is_healthy(ssh) -> bool:
 def test_postgrest_is_running(host):
     """Check if postgrest service is running using our SSH connection."""
     result = run_ssh_command(host["ssh"], "systemctl is-active postgrest")
-    assert (
-        result["succeeded"] and result["stdout"].strip() == "active"
-    ), "PostgREST service is not running"
+    assert result["succeeded"] and result["stdout"].strip() == "active", (
+        "PostgREST service is not running"
+    )
 
 
 def test_postgrest_responds_to_requests(host):
@@ -571,9 +571,9 @@ def test_postgresql_version(host):
         if version_match:
             major_version = int(version_match.group(1))
             print(f"PostgreSQL major version: {major_version}")
-            assert (
-                major_version >= 14
-            ), f"PostgreSQL version {major_version} is less than 14"
+            assert major_version >= 14, (
+                f"PostgreSQL version {major_version} is less than 14"
+            )
         else:
             assert False, "Could not parse PostgreSQL version number"
     else:
@@ -603,9 +603,9 @@ def test_libpq5_version(host):
         if version_match:
             major_version = int(version_match.group(1))
             print(f"libpq5 major version: {major_version}")
-            assert (
-                major_version >= 14
-            ), f"libpq5 version {major_version} is less than 14"
+            assert major_version >= 14, (
+                f"libpq5 version {major_version} is less than 14"
+            )
         else:
             print("Could not parse libpq5 version from dpkg output")
     else:
@@ -638,9 +638,9 @@ def test_libpq5_version(host):
         if version_match:
             major_version = int(version_match.group(1))
             print(f"psql/libpq major version: {major_version}")
-            assert (
-                major_version >= 14
-            ), f"psql/libpq version {major_version} is less than 14"
+            assert major_version >= 14, (
+                f"psql/libpq version {major_version} is less than 14"
+            )
         else:
             print("Could not parse psql version")
 
@@ -801,7 +801,9 @@ def test_postgrest_read_only_session_attrs(host):
             print(
                 f"\nFound 'session is not read-only' errors in PostgREST logs:\n{result['stdout']}"
             )
-            assert False, "PostgREST logs contain 'session is not read-only' errors even though PostgreSQL is configured for read-only mode"
+            assert False, (
+                "PostgREST logs contain 'session is not read-only' errors even though PostgreSQL is configured for read-only mode"
+            )
         else:
             print("\nNo 'session is not read-only' errors found in PostgREST logs")
 

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,6 @@`
`2`	`2`	`{`
`3`	`3`	`perSystem =`
`4`	`4`	`{`
`5`		`- lib,`
`6`	`5`	`self',`
`7`	`6`	`system,`
`8`	`7`	`pkgs,`