fix(security): replace privileged with CAP_SYS_PTRACE #651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply principle of least privilege by dropping all capabilities except CAP_SYS_PTRACE which Kepler needs to read /proc/<pid> Also enforce readonly root filesystem and prevent privilege escalation Security improvements: - Set privileged: false (no full root capabilities) - Drop ALL capabilities, add only SYS_PTRACE - Set allowPrivilegeEscalation: false - Set readOnlyRootFilesystem: true - Updated OpenShift SCC with same constraints Signed-off-by: vprashar2929 <vibhu.sharma2929@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #651 +/- ##
==========================================
+ Coverage 78.65% 78.89% +0.23%
==========================================
Files 11 11
Lines 1073 1085 +12
==========================================
+ Hits 844 856 +12
Misses 199 199
Partials 30 30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
pls mention if this fix is tested on which openshift version |
vimalk78
reviewed
Dec 4, 2025
Comment on lines
+353
to
+354
| RequiredDropCapabilities: []corev1.Capability{"ALL"}, | ||
| AllowedCapabilities: []corev1.Capability{"SYS_PTRACE"}, |
vimalk78
reviewed
Dec 4, 2025
Collaborator
vimalk78
left a comment
vimalk78
left a comment
There was a problem hiding this comment.
can you add an e2e test which checks kepler's privileges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply principle of least privilege by dropping all capabilities except CAP_SYS_PTRACE which Kepler needs to read /proc/ Also enforce readonly root filesystem and prevent privilege escalation
Security improvements: