From 6419e74c2c3ae56c6627f7ee9441c62e923ed48e Mon Sep 17 00:00:00 2001 From: Zhiwei Liang Date: Tue, 24 Mar 2026 17:12:12 -0400 Subject: [PATCH 1/2] fix: replace deprecated URLDecoder method with charset specification Signed-off-by: Zhiwei Liang --- .../java/io/swagger/codegen/v3/auth/AuthParser.java | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/modules/swagger-codegen/src/main/java/io/swagger/codegen/v3/auth/AuthParser.java b/modules/swagger-codegen/src/main/java/io/swagger/codegen/v3/auth/AuthParser.java index 18b1a618c89..b9acda92659 100644 --- a/modules/swagger-codegen/src/main/java/io/swagger/codegen/v3/auth/AuthParser.java +++ b/modules/swagger-codegen/src/main/java/io/swagger/codegen/v3/auth/AuthParser.java @@ -4,8 +4,10 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import java.io.UnsupportedEncodingException; import java.net.URLDecoder; import java.net.URLEncoder; +import java.nio.charset.StandardCharsets; import java.util.ArrayList; import java.util.List; @@ -22,8 +24,11 @@ public static List parse(String urlEncodedAuthStr) { for (String part : parts) { String[] kvPair = part.split(":"); if (kvPair.length == 2) { - // FIXME replace the deprecated method by decode(string, encoding). Which encoding is used ? Default UTF-8 ? - auths.add(new AuthorizationValue(URLDecoder.decode(kvPair[0]), URLDecoder.decode(kvPair[1]), "header")); + try { + auths.add(new AuthorizationValue(URLDecoder.decode(kvPair[0], StandardCharsets.UTF_8.name()), URLDecoder.decode(kvPair[1], StandardCharsets.UTF_8.name()), "header")); + } catch (UnsupportedEncodingException e) { + throw new AssertionError("UTF-8 is not supported", e); + } } } } @@ -38,9 +43,9 @@ public static String reconstruct(List authorizationValueList if (b.toString().length() > 0) { b.append(","); } - b.append(URLEncoder.encode(v.getKeyName(), "UTF-8")) + b.append(URLEncoder.encode(v.getKeyName(), StandardCharsets.UTF_8.name())) .append(":") - .append(URLEncoder.encode(v.getValue(), "UTF-8")); + .append(URLEncoder.encode(v.getValue(), StandardCharsets.UTF_8.name())); } catch (Exception e) { // continue LOGGER.error(e.getMessage(), e); From 48ebb8c5cd4951ca7632aaabc40458eb8b8d5648 Mon Sep 17 00:00:00 2001 From: Zhiwei Liang Date: Tue, 24 Mar 2026 18:02:29 -0400 Subject: [PATCH 2/2] Change exception to UncheckedIOException Signed-off-by: Zhiwei Liang --- .../src/main/java/io/swagger/codegen/v3/auth/AuthParser.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/swagger-codegen/src/main/java/io/swagger/codegen/v3/auth/AuthParser.java b/modules/swagger-codegen/src/main/java/io/swagger/codegen/v3/auth/AuthParser.java index b9acda92659..b7d35c7a19d 100644 --- a/modules/swagger-codegen/src/main/java/io/swagger/codegen/v3/auth/AuthParser.java +++ b/modules/swagger-codegen/src/main/java/io/swagger/codegen/v3/auth/AuthParser.java @@ -4,6 +4,7 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import java.io.UncheckedIOException; import java.io.UnsupportedEncodingException; import java.net.URLDecoder; import java.net.URLEncoder; @@ -27,7 +28,7 @@ public static List parse(String urlEncodedAuthStr) { try { auths.add(new AuthorizationValue(URLDecoder.decode(kvPair[0], StandardCharsets.UTF_8.name()), URLDecoder.decode(kvPair[1], StandardCharsets.UTF_8.name()), "header")); } catch (UnsupportedEncodingException e) { - throw new AssertionError("UTF-8 is not supported", e); + throw new UncheckedIOException("UTF-8 is not supported", e); } } }