From 59b87a60ebf8762d031201cded8404afc7df80ae Mon Sep 17 00:00:00 2001 From: Sam Washko Date: Fri, 29 Sep 2023 15:50:17 -0700 Subject: [PATCH 01/26] coverage workflow --- .github/workflows/coverage.yml | 79 ++++++++++++++++------------------ 1 file changed, 37 insertions(+), 42 deletions(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 612469b9..76caacb9 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -1,43 +1,38 @@ -name: Coverage - on: - push: - branches: main - pull_request: - branches: "*" - -jobs: - test: - runs-on: ubuntu-latest - strategy: - matrix: - python-version: ["3.8", "3.9", "3.10"] - - steps: - - uses: actions/checkout@v2 - - name: Set up Python ${{ matrix.python-version }} - uses: actions/setup-python@v2 - with: - python-version: ${{ matrix.python-version }} - - uses: snok/install-poetry@v1 - with: - virtualenvs-create: true - virtualenvs-in-project: true - installer-parallel: true - - name: Load cached venv - id: cached-poetry-dependencies - uses: actions/cache@v3 - with: - path: .venv - key: venv-test-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-${{ hashFiles('**/poetry.lock') }} - - name: Install Dependencies - if: steps.cached-poetry-dependencies.outputs.cache-hit != 'true' - run: | - make install-test - - name: Run Coverage - run: | - make test - - name: Upload coverage reports to Codecov - uses: codecov/codecov-action@v3 - with: - token: ${{ secrets.CODECOV_TOKEN }} + push: + branches: main + pull_request: + branches: "*" + jobs: + test: + runs-on: ubuntu-latest + env: + OS: ubuntu-latest + PYTHON: '3.9' + steps: + - uses: actions/checkout@v2 + - name: Set up Python + uses: actions/setup-python@v2 + id: setup-python + with: + python-version: "3.9" + - uses: snok/install-poetry@v1 + with: + virtualenvs-create: true + virtualenvs-in-project: true + installer-parallel: true + - name: Load cached venv + id: cached-poetry-dependencies + uses: actions/cache@v3 + with: + path: .venv + key: venv-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-${{ hashFiles('**/poetry.lock') }} + - name: Install Dependencies + run: | + make install-test + - name: Run Coverage + run: | + pip install coverage + pip install pytest + poetry add coverage codecov + make coverage From 89cd7310a5a05ac135a8a69a626823ae69bbba5f Mon Sep 17 00:00:00 2001 From: Sam Washko Date: Fri, 29 Sep 2023 15:54:14 -0700 Subject: [PATCH 02/26] upload step --- .github/workflows/coverage.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 76caacb9..9cd76925 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -36,3 +36,8 @@ on: pip install pytest poetry add coverage codecov make coverage + - name: Upload coverage reports to Codecov + uses: codecov/codecov-action@v3 + with: + token: ${{ secrets.CODECOV_TOKEN }} + verbose: true From d46e70b4184bff5b8adc9faedc6a11460c3833b6 Mon Sep 17 00:00:00 2001 From: Sam Washko Date: Fri, 29 Sep 2023 15:59:13 -0700 Subject: [PATCH 03/26] Update coverage.yml --- .github/workflows/coverage.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 9cd76925..5c231d3d 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -1,9 +1,10 @@ +name: Coverage on: push: branches: main pull_request: branches: "*" - jobs: +jobs: test: runs-on: ubuntu-latest env: @@ -26,7 +27,7 @@ on: uses: actions/cache@v3 with: path: .venv - key: venv-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-${{ hashFiles('**/poetry.lock') }} + key: venv-test-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-${{ hashFiles('**/poetry.lock') }} - name: Install Dependencies run: | make install-test From a8584b2267f0bb3e3c00256f9b583cc20b2cf2af Mon Sep 17 00:00:00 2001 From: Sam Washko Date: Fri, 29 Sep 2023 16:07:53 -0700 Subject: [PATCH 04/26] if --- .github/workflows/coverage.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 5c231d3d..4ee490bc 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -29,6 +29,7 @@ jobs: path: .venv key: venv-test-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-${{ hashFiles('**/poetry.lock') }} - name: Install Dependencies + if: steps.cached-poetry-dependencies.outputs.cache-hit != 'true' run: | make install-test - name: Run Coverage From 297bf620f0e0c89afc8fd170f420c28927e92e7f Mon Sep 17 00:00:00 2001 From: Sam Washko Date: Fri, 29 Sep 2023 16:33:50 -0700 Subject: [PATCH 05/26] Create codecov.yml --- codecov.yml | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 codecov.yml diff --git a/codecov.yml b/codecov.yml new file mode 100644 index 00000000..e69de29b From 41439d16a19960f4b93fd6ff4e8b3de792c346fe Mon Sep 17 00:00:00 2001 From: Sam Washko Date: Fri, 29 Sep 2023 17:49:35 -0700 Subject: [PATCH 06/26] ignore test files --- codecov.yml | 2 ++ tests/test_modelscan.py | 30 +++++++++++++++--------------- 2 files changed, 17 insertions(+), 15 deletions(-) diff --git a/codecov.yml b/codecov.yml index e69de29b..40a3e00a 100644 --- a/codecov.yml +++ b/codecov.yml @@ -0,0 +1,2 @@ +ignore: + - "*/tests/*” diff --git a/tests/test_modelscan.py b/tests/test_modelscan.py index d6395226..6a37f5d2 100644 --- a/tests/test_modelscan.py +++ b/tests/test_modelscan.py @@ -685,21 +685,21 @@ def test_scan_directory_path(pickle_file_path: str) -> None: compare_results(ms.issues.all_issues, expected) -def test_scan_huggingface_model() -> None: - expected = [ - Issue( - IssueCode.UNSAFE_OPERATOR, - IssueSeverity.CRITICAL, - OperatorIssueDetails( - "__builtin__", - "eval", - "https://huggingface.co/ykilcher/totally-harmless-model/resolve/main/pytorch_model.bin:archive/data.pkl", - ), - ) - ] - ms = Modelscan() - ms.scan_huggingface_model("ykilcher/totally-harmless-model") - assert ms.issues.all_issues == expected +# def test_scan_huggingface_model() -> None: +# expected = [ +# Issue( +# IssueCode.UNSAFE_OPERATOR, +# IssueSeverity.CRITICAL, +# OperatorIssueDetails( +# "__builtin__", +# "eval", +# "https://huggingface.co/ykilcher/totally-harmless-model/resolve/main/pytorch_model.bin:archive/data.pkl", +# ), +# ) +# ] +# ms = Modelscan() +# ms.scan_huggingface_model("ykilcher/totally-harmless-model") +# assert ms.issues.all_issues == expected # def test_scan_tf() -> None: From 357ab2fdb50b0553210712da15b43664340d722b Mon Sep 17 00:00:00 2001 From: Sam Washko Date: Fri, 29 Sep 2023 17:54:30 -0700 Subject: [PATCH 07/26] take out env --- .github/workflows/coverage.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 4ee490bc..6168468f 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -7,9 +7,6 @@ on: jobs: test: runs-on: ubuntu-latest - env: - OS: ubuntu-latest - PYTHON: '3.9' steps: - uses: actions/checkout@v2 - name: Set up Python From 4c18f57b95892beaf2cb8a95f1a505f353368435 Mon Sep 17 00:00:00 2001 From: Sam Washko Date: Mon, 2 Oct 2023 09:40:35 -0700 Subject: [PATCH 08/26] take out pip pytest --- .github/workflows/coverage.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 6168468f..dd8c67b8 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -32,7 +32,6 @@ jobs: - name: Run Coverage run: | pip install coverage - pip install pytest poetry add coverage codecov make coverage - name: Upload coverage reports to Codecov From 26e69638f37739063a2b2af03b2d654d209228da Mon Sep 17 00:00:00 2001 From: Sam Washko Date: Mon, 2 Oct 2023 09:42:51 -0700 Subject: [PATCH 09/26] take out pip coverage --- .github/workflows/coverage.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index dd8c67b8..68f05fb9 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -31,7 +31,6 @@ jobs: make install-test - name: Run Coverage run: | - pip install coverage poetry add coverage codecov make coverage - name: Upload coverage reports to Codecov From 0c492509530bfb3f0409734448d5b691bba25f7e Mon Sep 17 00:00:00 2001 From: Sam Washko Date: Mon, 2 Oct 2023 09:47:28 -0700 Subject: [PATCH 10/26] poetry lock coverage test --- poetry.lock | 4 ++-- pyproject.toml | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/poetry.lock b/poetry.lock index 2d571c61..3b4b6a02 100644 --- a/poetry.lock +++ b/poetry.lock @@ -1265,8 +1265,8 @@ files = [ [package.dependencies] numpy = [ {version = ">=1.20.3", markers = "python_version < \"3.10\""}, - {version = ">=1.21.0", markers = "python_version >= \"3.10\" and python_version < \"3.11\""}, {version = ">=1.23.2", markers = "python_version >= \"3.11\""}, + {version = ">=1.21.0", markers = "python_version >= \"3.10\" and python_version < \"3.11\""}, ] python-dateutil = ">=2.8.2" pytz = ">=2020.1" @@ -2140,4 +2140,4 @@ tensorflow = ["tensorflow", "tensorflow-macos"] [metadata] lock-version = "2.0" python-versions = ">=3.8,<3.12" -content-hash = "8a05aa605ce557241dd71fed9a13453959593d6727880d0b5023feec61f217b1" +content-hash = "e008ff5953e99b987a1e17a6b0853f024d3e71112594c8abb65a257798274aa6" diff --git a/pyproject.toml b/pyproject.toml index 156fc329..16eb148a 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -33,6 +33,7 @@ dill = "^0.3.7" pandas = "^2.0.3" requests = "^2.31.0" pytest-cov = "^4.1.0" +coverage = "^7.3.1" [tool.poetry.group.dev.dependencies] dunamai = "^1.18.0" From 12355eca459334dde789cc53ef6b234e64d4242a Mon Sep 17 00:00:00 2001 From: Sam Washko Date: Mon, 2 Oct 2023 09:54:30 -0700 Subject: [PATCH 11/26] add back pip coverage --- .github/workflows/coverage.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 68f05fb9..dd8c67b8 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -31,6 +31,7 @@ jobs: make install-test - name: Run Coverage run: | + pip install coverage poetry add coverage codecov make coverage - name: Upload coverage reports to Codecov From 57bdb4a76e64a599899f58f4fbec32090115b3c0 Mon Sep 17 00:00:00 2001 From: Sam Washko Date: Mon, 2 Oct 2023 09:58:42 -0700 Subject: [PATCH 12/26] remove poetry coverage --- .github/workflows/coverage.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index dd8c67b8..9e5ee2ef 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -32,7 +32,7 @@ jobs: - name: Run Coverage run: | pip install coverage - poetry add coverage codecov + poetry add codecov make coverage - name: Upload coverage reports to Codecov uses: codecov/codecov-action@v3 From 7c9403a4e91733a4b2973c1aebe9cf7e784c444c Mon Sep 17 00:00:00 2001 From: Sam Washko Date: Mon, 2 Oct 2023 10:02:50 -0700 Subject: [PATCH 13/26] poetry lock codecov --- poetry.lock | 17 ++++++++++++++++- pyproject.toml | 1 + 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/poetry.lock b/poetry.lock index 3b4b6a02..7eba47b2 100644 --- a/poetry.lock +++ b/poetry.lock @@ -378,6 +378,21 @@ files = [ [package.dependencies] colorama = {version = "*", markers = "platform_system == \"Windows\""} +[[package]] +name = "codecov" +version = "2.1.13" +description = "Hosted coverage reports for GitHub, Bitbucket and Gitlab" +optional = false +python-versions = ">=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*" +files = [ + {file = "codecov-2.1.13-py2.py3-none-any.whl", hash = "sha256:c2ca5e51bba9ebb43644c43d0690148a55086f7f5e6fd36170858fa4206744d5"}, + {file = "codecov-2.1.13.tar.gz", hash = "sha256:2362b685633caeaf45b9951a9b76ce359cd3581dd515b430c6c3f5dfb4d92a8c"}, +] + +[package.dependencies] +coverage = "*" +requests = ">=2.7.9" + [[package]] name = "colorama" version = "0.4.6" @@ -2140,4 +2155,4 @@ tensorflow = ["tensorflow", "tensorflow-macos"] [metadata] lock-version = "2.0" python-versions = ">=3.8,<3.12" -content-hash = "e008ff5953e99b987a1e17a6b0853f024d3e71112594c8abb65a257798274aa6" +content-hash = "63464c3d949dae7ab8e6f4866faa9d6c5ddc8f0b467974fd0033138e807ad5ad" diff --git a/pyproject.toml b/pyproject.toml index 16eb148a..ed13ec1b 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -34,6 +34,7 @@ pandas = "^2.0.3" requests = "^2.31.0" pytest-cov = "^4.1.0" coverage = "^7.3.1" +codecov = "^2.1.13" [tool.poetry.group.dev.dependencies] dunamai = "^1.18.0" From 2832e20fb451185590952e7e65c16d9ee22466f4 Mon Sep 17 00:00:00 2001 From: Sam Washko Date: Mon, 2 Oct 2023 10:05:55 -0700 Subject: [PATCH 14/26] remove poetry add codecov --- .github/workflows/coverage.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 9e5ee2ef..f16f2450 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -32,7 +32,6 @@ jobs: - name: Run Coverage run: | pip install coverage - poetry add codecov make coverage - name: Upload coverage reports to Codecov uses: codecov/codecov-action@v3 From 630137baf125c58ca2c846ff903530f976cc6290 Mon Sep 17 00:00:00 2001 From: Sam Washko Date: Mon, 2 Oct 2023 10:09:52 -0700 Subject: [PATCH 15/26] remove pip coverage --- .github/workflows/coverage.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index f16f2450..6db16af7 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -31,7 +31,6 @@ jobs: make install-test - name: Run Coverage run: | - pip install coverage make coverage - name: Upload coverage reports to Codecov uses: codecov/codecov-action@v3 From 4ae04c30767b1ea5a3d5befdcd79370247f3e0e7 Mon Sep 17 00:00:00 2001 From: Sam Washko Date: Mon, 2 Oct 2023 11:23:56 -0700 Subject: [PATCH 16/26] re-add pip coverage --- .github/workflows/coverage.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 6db16af7..f16f2450 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -31,6 +31,7 @@ jobs: make install-test - name: Run Coverage run: | + pip install coverage make coverage - name: Upload coverage reports to Codecov uses: codecov/codecov-action@v3 From a5e78a031414f7b4e8eeca189c7db82caf3c9195 Mon Sep 17 00:00:00 2001 From: Sam Washko Date: Mon, 2 Oct 2023 18:21:53 -0700 Subject: [PATCH 17/26] no token --- .github/workflows/coverage.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index f16f2450..235ad9e1 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -36,5 +36,4 @@ jobs: - name: Upload coverage reports to Codecov uses: codecov/codecov-action@v3 with: - token: ${{ secrets.CODECOV_TOKEN }} verbose: true From 41d6674b6e534ce2d1779383fe48f549c3a156b4 Mon Sep 17 00:00:00 2001 From: Sam Washko Date: Mon, 2 Oct 2023 18:27:51 -0700 Subject: [PATCH 18/26] coverage comentator --- .github/workflows/coverage.yml | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 235ad9e1..15472b02 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -31,9 +31,7 @@ jobs: make install-test - name: Run Coverage run: | - pip install coverage + pip install coverage flake8 make coverage - - name: Upload coverage reports to Codecov - uses: codecov/codecov-action@v3 - with: - verbose: true + - name: Comment coverage > pytest-coverage.txt + uses: coroo/pytest-coverage-commentator@v1.0.2 From faa0e00819b3423c9c47fc696a37eaf96720bfdf Mon Sep 17 00:00:00 2001 From: Sam Washko Date: Mon, 2 Oct 2023 18:28:41 -0700 Subject: [PATCH 19/26] move file assignment --- .github/workflows/coverage.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 15472b02..38801d04 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -32,6 +32,6 @@ jobs: - name: Run Coverage run: | pip install coverage flake8 - make coverage - - name: Comment coverage > pytest-coverage.txt + make coverage > pytest-coverage.txt + - name: Comment coverage uses: coroo/pytest-coverage-commentator@v1.0.2 From 2c36fbee9286ff494c85b3962dd0e5fb50a19955 Mon Sep 17 00:00:00 2001 From: Sam Washko Date: Mon, 2 Oct 2023 18:45:18 -0700 Subject: [PATCH 20/26] github output --- .github/workflows/coverage.yml | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 38801d04..ee1479eb 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -7,6 +7,8 @@ on: jobs: test: runs-on: ubuntu-latest + outputs: + coverage: ${{ steps.coverage.outputs.coverage-report }} steps: - uses: actions/checkout@v2 - name: Set up Python @@ -30,8 +32,21 @@ jobs: run: | make install-test - name: Run Coverage + id: coverage run: | - pip install coverage flake8 - make coverage > pytest-coverage.txt + { + pip install coverage flake8 + echo 'coverage-report<> "$GITHUB_OUTPUT" + comment: + runs-on: ubuntu-latest + permissions: + pull-requests: write + needs: test + steps: - name: Comment coverage uses: coroo/pytest-coverage-commentator@v1.0.2 + with: + pytest-coverage: [${{needs.test.outputs.coverage}}] From 7da9d04731694d17ca87fa6b4a2e49bf7af18754 Mon Sep 17 00:00:00 2001 From: Sam Washko Date: Mon, 2 Oct 2023 18:49:39 -0700 Subject: [PATCH 21/26] no [] --- .github/workflows/coverage.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index ee1479eb..0d392242 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -49,4 +49,4 @@ jobs: - name: Comment coverage uses: coroo/pytest-coverage-commentator@v1.0.2 with: - pytest-coverage: [${{needs.test.outputs.coverage}}] + pytest-coverage: ${{needs.test.outputs.coverage}} From c674ba89c3618e6343aa32b0309a8c1ed6a82902 Mon Sep 17 00:00:00 2001 From: Sam Washko Date: Mon, 2 Oct 2023 20:06:33 -0700 Subject: [PATCH 22/26] no -v --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 5c382ba2..8386b7c0 100644 --- a/Makefile +++ b/Makefile @@ -41,4 +41,4 @@ format: black . coverage: - poetry run pytest -v --cov=./ + poetry run pytest --cov=./ From c868d804e630c6584a29c38296f8e2bb2e314363 Mon Sep 17 00:00:00 2001 From: Sam Washko Date: Mon, 2 Oct 2023 20:11:47 -0700 Subject: [PATCH 23/26] move pip --- .github/workflows/coverage.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 0d392242..ed16d9a6 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -34,8 +34,8 @@ jobs: - name: Run Coverage id: coverage run: | + pip install coverage flake8 { - pip install coverage flake8 echo 'coverage-report< Date: Mon, 2 Oct 2023 20:19:22 -0700 Subject: [PATCH 24/26] separate file step --- .github/workflows/coverage.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index ed16d9a6..00f71c23 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -46,7 +46,10 @@ jobs: pull-requests: write needs: test steps: + - name: Save output + run: | + ${{needs.test.outputs.coverage}} > pytest-coverage.txt - name: Comment coverage uses: coroo/pytest-coverage-commentator@v1.0.2 with: - pytest-coverage: ${{needs.test.outputs.coverage}} + pytest-coverage: pytest-coverage.txt From f0c829117f209b2e94f72a0115ddcc987a9d3681 Mon Sep 17 00:00:00 2001 From: Sam Washko Date: Mon, 2 Oct 2023 20:24:18 -0700 Subject: [PATCH 25/26] echo --- .github/workflows/coverage.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 00f71c23..3d70c768 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -48,7 +48,7 @@ jobs: steps: - name: Save output run: | - ${{needs.test.outputs.coverage}} > pytest-coverage.txt + echo ${{needs.test.outputs.coverage}} > pytest-coverage.txt - name: Comment coverage uses: coroo/pytest-coverage-commentator@v1.0.2 with: From 0fb5baf7b4666cb2f205ec8918257755d5f17bd6 Mon Sep 17 00:00:00 2001 From: Sam Washko Date: Mon, 2 Oct 2023 20:33:33 -0700 Subject: [PATCH 26/26] quotes --- .github/workflows/coverage.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 3d70c768..e47fdf97 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -48,7 +48,7 @@ jobs: steps: - name: Save output run: | - echo ${{needs.test.outputs.coverage}} > pytest-coverage.txt + echo "${{needs.test.outputs.coverage}}" > pytest-coverage.txt - name: Comment coverage uses: coroo/pytest-coverage-commentator@v1.0.2 with: