Fix race condition during iteration through modules (llvm#139283) (llvm#139862)

Use the locking iterator to ensure module don't change during iteration.

(cherry picked from commit c72c0b2)

Author: nd

lldb/source/Target/Target.cpp

@@ -1452,8 +1452,7 @@ bool Target::IgnoreWatchpointByID(lldb::watch_id_t watch_id,
 
 ModuleSP Target::GetExecutableModule() {
   // search for the first executable in the module list
-  for (size_t i = 0; i < m_images.GetSize(); ++i) {
-    ModuleSP module_sp = m_images.GetModuleAtIndex(i);
+  for (ModuleSP module_sp : m_images.Modules()) {
     lldb_private::ObjectFile *obj = module_sp->GetObjectFile();
     if (obj == nullptr)
       continue;