Rename new eval option to its abstraction not its implementation

Author: kastiglione

lldb/include/lldb/Target/Target.h

@@ -568,11 +568,13 @@ class EvaluateExpressionOptions {
 
   bool GetPreparePlaygroundStubFunctions() const { return m_prepare_playground_stub_functions; }
 
-  void SetDisableAvailability(bool disable = true) {
-    m_disable_availability = disable;
+  void SetUseContextFreeSwiftPrintObject(bool enable = true) {
+    m_use_context_free_swift_print_object = enable;
   }
 
-  bool GetDisableAvailability() const { return m_disable_availability; }
+  bool GetUseContextFreeSwiftPrintObject() const {
+    return m_use_context_free_swift_print_object;
+  }
 
 private:
   ExecutionPolicy m_execution_policy = default_execution_policy;
@@ -615,8 +617,10 @@ class EvaluateExpressionOptions {
   mutable uint32_t m_pound_line_line = 0;
   bool m_prepare_playground_stub_functions = true;
 
-  /// Disable compiler availability checking.
-  bool m_disable_availability = false;
+  /// An evaluation mode that for swift. Has the following effects:
+  ///   1. Disables implicit module loading
+  ///   2. Disables compiler availability checking
+  bool m_use_context_free_swift_print_object = false;
 
   /// During expression evaluation, any SymbolContext in this list will be
   /// used for symbol/function lookup before any other context (except for

lldb/source/Plugins/ExpressionParser/Swift/SwiftExpressionSourceCode.cpp

@@ -640,7 +640,7 @@ Status SwiftExpressionSourceCode::GetText(
     if (triple.isOSDarwin()) {
       if (auto process_sp = exe_ctx.GetProcessSP()) {
         os_vers << getAvailabilityName(triple) << " ";
-        if (options.GetDisableAvailability()) {
+        if (options.GetUseContextFreeSwiftPrintObject()) {
           // Disable availability by setting the OS version to 9999. This
           // placeholder OS version used for future OS versions when building
           // the Swift standard library locally.

lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntime.cpp

@@ -914,7 +914,7 @@ std::string SwiftLanguageRuntime::GetObjectDescriptionExpr_Copy(
 
 static llvm::Expected<ValueObjectSP>
 RunObjectDescription(ValueObject &object, std::string &expr_string,
-                     Process &process, bool disable_availability = false) {
+                     Process &process, bool context_free = false) {
   Log *log(GetLog(LLDBLog::DataFormatters | LLDBLog::Expressions));
   ValueObjectSP result_sp;
   EvaluateExpressionOptions eval_options;
@@ -923,8 +923,8 @@ RunObjectDescription(ValueObject &object, std::string &expr_string,
   eval_options.SetSuppressPersistentResult(true);
   eval_options.SetIgnoreBreakpoints(true);
   eval_options.SetTimeout(process.GetUtilityExpressionTimeout());
-  if (disable_availability)
-    eval_options.SetDisableAvailability();
+  if (context_free)
+    eval_options.SetUseContextFreeSwiftPrintObject();
 
   StackFrameSP frame_sp = object.GetFrameSP();
   if (!frame_sp)