Merge pull request #71219 from DougGregor/abstraction-pattern-typed-throws-bad-assert

[Abstraction pattern] Eliminate unnecessary assertion for typed throws

Author: DougGregor

lib/SIL/IR/AbstractionPattern.cpp

@@ -1270,11 +1270,6 @@ AbstractionPattern::getFunctionThrownErrorType(
     if (!substErrorType)
       return llvm::None;
 
-    if (!(*substErrorType)->isEqual(ctx.getErrorExistentialType())) {
-      llvm::errs() << "unsupported reabstraction\n";
-      abort();
-    }
-
     return std::make_pair(AbstractionPattern(*substErrorType),
                           (*substErrorType)->getCanonicalType());
   }

test/IRGen/typed_throws.swift

@@ -7,7 +7,7 @@
 // XFAIL: CPU=arm64e
 // REQUIRES: PTRSIZE=64
 
-enum MyBigError: Error {
+public enum MyBigError: Error {
   case epicFail
 }
 
@@ -22,6 +22,10 @@ func createsP() {
   requiresP(X.self)
 }
 
+// This is for TypeH.method
+// CHECK-NOMANGLE: @"$s12typed_throws5TypeHV6methodySSSiAA10MyBigErrorOYKcvpMV" =
+
+
 // CHECK-LABEL: define {{.*}}hidden swiftcc ptr @"$s12typed_throws13buildMetatypeypXpyF"()
 func buildMetatype() -> Any.Type {
   typealias Fn = (Int) throws(MyBigError) -> Void
@@ -78,3 +82,8 @@ func callee() throws (S) {
 func testit() throws (S) {
   try callee()
 }
+
+// Used to crash in abstract pattern creation.
+public struct TypeH {
+  public var method: (Int) throws(MyBigError) -> String
+}