swift SIL: fix Function.isGeneric

It didn't work for functions in generic contexts, which don't add a generic parameter themselves

Author: eeckstein

SwiftCompilerSources/Sources/Optimizer/FunctionPasses/ReleaseDevirtualizer.swift

@@ -108,7 +108,7 @@ private func tryDevirtualizeRelease(
   let functionRef = builder.createFunctionRef(dealloc)
 
   let substitutionMap: SubstitutionMap
-  if dealloc.isGenericFunction {
+  if dealloc.isGeneric {
     substitutionMap = context.getContextSubstitutionMap(for: type)
   } else {
     // In embedded Swift, dealloc might be a specialized deinit, so the substitution map on the old apply isn't valid for the new apply

SwiftCompilerSources/Sources/Optimizer/ModulePasses/MandatoryPerformanceOptimizations.swift

@@ -351,7 +351,7 @@ fileprivate struct FunctionWorklist {
   }
 
   mutating func addAllNonGenericFunctions(of moduleContext: ModulePassContext) {
-    for f in moduleContext.functions where !f.isGenericFunction {
+    for f in moduleContext.functions where !f.isGeneric {
       pushIfNotVisited(f)
     }
     return

SwiftCompilerSources/Sources/SIL/Function.swift

@@ -166,7 +166,7 @@ final public class Function : CustomStringConvertible, HasShortDescription, Hash
 
   public var isDestructor: Bool { bridged.isDestructor() }
 
-  public var isGenericFunction: Bool { bridged.isGenericFunction() }
+  public var isGeneric: Bool { bridged.isGeneric() }
 
   /// Kinds of effect attributes which can be defined for a Swift function.
   public enum EffectAttribute {

include/swift/SIL/SILBridging.h

@@ -529,7 +529,7 @@ struct BridgedFunction {
   BRIDGED_INLINE bool isGlobalInitFunction() const;
   BRIDGED_INLINE bool isGlobalInitOnceFunction() const;
   BRIDGED_INLINE bool isDestructor() const;
-  BRIDGED_INLINE bool isGenericFunction() const;
+  BRIDGED_INLINE bool isGeneric() const;
   BRIDGED_INLINE bool hasSemanticsAttr(BridgedStringRef attrName) const;
   BRIDGED_INLINE bool hasUnsafeNonEscapableResult() const;
   BRIDGED_INLINE bool hasResultDependsOnSelf() const;

include/swift/SIL/SILBridgingImpl.h

@@ -620,8 +620,8 @@ bool BridgedFunction::isDestructor() const {
   return false;
 }
 
-bool BridgedFunction::isGenericFunction() const {
-  return !getFunction()->getGenericSignature().isNull();
+bool BridgedFunction::isGeneric() const {
+  return getFunction()->isGeneric();
 }
 
 bool BridgedFunction::hasSemanticsAttr(BridgedStringRef attrName) const {