[SourceKit] Migrate renameAvailabilityInfo to use the SwiftSyntax NameMatcher

The `NameMatcher` implemented in swift-syntax as slightly different semantics because it consideres `(callable.|callAsFunction)(x: 78)` as a reference to `callAsFunction` instead of a call with argument labels `(x: 78)`, which means that one test needs to be updated.

Author: ahoppen

lib/Refactoring/LocalRename.cpp

@@ -16,6 +16,7 @@
 #include "swift/AST/USRGeneration.h"
 #include "swift/Basic/StringExtras.h"
 #include "swift/Frontend/PrintingDiagnosticConsumer.h"
+#include "swift/IDE/IDEBridging.h"
 #include "swift/Index/Index.h"
 
 using namespace swift::refactoring;
@@ -44,6 +45,31 @@ struct RenameRefInfo {
   bool IsArgLabel; ///< Whether Loc is on an arg label, rather than base name.
 };
 
+#if SWIFT_BUILD_SWIFT_SYNTAX
+/// Returns `true` if the `RefInfo` points to a location that doesn't have any
+/// arguments. For example, returns `true` for `Foo.init` but `false` for
+/// `Foo.init()` or `Foo.init(a: 1)`.
+static bool
+isReferenceWithoutArguments(const llvm::Optional<RenameRefInfo> &refInfo) {
+  if (!refInfo) {
+    return false;
+  }
+  if (refInfo->IsArgLabel) {
+    return false;
+  }
+  BridgedSourceLoc Loc(refInfo->Loc);
+  BridgedResolvedLocVector bridgedResolvedLocs =
+      swift_SwiftIDEUtilsBridging_runNameMatcher(
+          refInfo->SF->getExportedSourceFile(), &Loc, 1);
+  std::vector<ResolvedLoc> resolvedLocs = bridgedResolvedLocs.takeUnbridged();
+  if (!resolvedLocs.empty()) {
+    ResolvedLoc resolvedLoc = resolvedLocs.front();
+    return resolvedLoc.labelRanges.empty();
+  }
+  return false;
+}
+#endif // SWIFT_BUILD_SWIFT_SYNTAX
+
 static llvm::Optional<RefactorAvailabilityInfo>
 renameAvailabilityInfo(const ValueDecl *VD,
                        llvm::Optional<RenameRefInfo> RefInfo) {
@@ -88,12 +114,11 @@ renameAvailabilityInfo(const ValueDecl *VD,
       if (!CD->getParameters()->size())
         return llvm::None;
 
-      if (RefInfo && !RefInfo->IsArgLabel) {
-        NameMatcher Matcher(*(RefInfo->SF));
-        auto Resolved = Matcher.resolve({RefInfo->Loc});
-        if (Resolved.labelRanges.empty())
-          return llvm::None;
+#if SWIFT_BUILD_SWIFT_SYNTAX
+      if (isReferenceWithoutArguments(RefInfo)) {
+        return llvm::None;
       }
+#endif
     }
 
     // Disallow renaming 'callAsFunction' method with no arguments.
@@ -104,12 +129,11 @@ renameAvailabilityInfo(const ValueDecl *VD,
         if (!FD->getParameters()->size())
           return llvm::None;
 
-        if (RefInfo && !RefInfo->IsArgLabel) {
-          NameMatcher Matcher(*(RefInfo->SF));
-          auto Resolved = Matcher.resolve({RefInfo->Loc});
-          if (Resolved.labelRanges.empty())
-            return llvm::None;
+#if SWIFT_BUILD_SWIFT_SYNTAX
+        if (isReferenceWithoutArguments(RefInfo)) {
+          return llvm::None;
         }
+#endif
       }
     }
   }

lib/Refactoring/SyntacticRename.cpp

@@ -84,7 +84,7 @@ swift::ide::resolveRenameLocations(ArrayRef<RenameLoc> RenameLocs,
       swift_SwiftIDEUtilsBridging_runNameMatcher(SF.getExportedSourceFile(),
                                                  BridgedUnresolvedLocs.data(),
                                                  BridgedUnresolvedLocs.size());
-  const std::vector<ResolvedLoc> &resolvedLocsInSourceOrder =
+  std::vector<ResolvedLoc> resolvedLocsInSourceOrder =
       bridgedResolvedLocs.takeUnbridged();
 
   // Callers need to corrolate the `ResolvedLoc` with the `RenameLoc` that they

test/SourceKit/Refactoring/basic.swift

@@ -152,7 +152,7 @@ func hasCallToAsyncAlternative(c: ConvertAsync) {
 // RUN: %sourcekitd-test -req=cursor -pos=95:10  -cursor-action %s -- %s | %FileCheck %s -check-prefix=CHECK-GLOBAL
 // RUN: %sourcekitd-test -req=cursor -pos=96:10  -cursor-action %s -- %s | %FileCheck %s -check-prefix=CHECK-GLOBAL
 // RUN: %sourcekitd-test -req=cursor -pos=96:25  -cursor-action %s -- %s | %FileCheck %s -check-prefix=CHECK-GLOBAL
-// RUN: %sourcekitd-test -req=cursor -pos=97:11  -cursor-action %s -- %s | %FileCheck %s -check-prefix=CHECK-GLOBAL
+// RUN: %sourcekitd-test -req=cursor -pos=97:11  -cursor-action %s -- %s | %FileCheck %s -check-prefix=CHECK-NORENAME
 // RUN: %sourcekitd-test -req=cursor -pos=97:27  -cursor-action %s -- %s | %FileCheck %s -check-prefix=CHECK-GLOBAL
 // RUN: %sourcekitd-test -req=cursor -pos=98:11  -cursor-action %s -- %s | %FileCheck %s -check-prefix=CHECK-NORENAME