[embedded] Introduce isGenericFunction and addAllNonGenericFunctions.

Author: zoecarver

SwiftCompilerSources/Sources/Optimizer/ModulePasses/MandatoryPerformanceOptimizations.swift

@@ -32,6 +32,11 @@ let mandatoryPerformanceOptimizations = ModulePass(name: "mandatory-performance-
   var worklist = FunctionWorklist()
   worklist.addAllPerformanceAnnotatedFunctions(of: moduleContext)
   worklist.addAllAnnotatedGlobalInitOnceFunctions(of: moduleContext)
+  // For embedded Swift, optimize all the functions (there cannot be any
+  // generics, type metadata, etc.)
+  if moduleContext.options.enableEmbeddedSwift {
+    worklist.addAllNonGenericFunctions(of: moduleContext)
+  }
 
   optimizeFunctionsTopDown(using: &worklist, moduleContext)
 }
@@ -300,18 +305,16 @@ fileprivate struct FunctionWorklist {
   }
 
   mutating func addAllPerformanceAnnotatedFunctions(of moduleContext: ModulePassContext) {
-    // For embedded Swift, optimize all the functions (there cannot be any
-    // generics, type metadata, etc.)
-    if moduleContext.options.enableEmbeddedSwift {
-      for f in moduleContext.functions {
-        pushIfNotVisited(f)
-      }
-      return
+    for f in moduleContext.functions where f.performanceConstraints != .none {
+      pushIfNotVisited(f)
     }
+  }
 
-    for f in moduleContext.functions where f.performanceConstraints != .none {
+  mutating func addAllNonGenericFunctions(of moduleContext: ModulePassContext) {
+    for f in moduleContext.functions where f.isGenericFunction {
       pushIfNotVisited(f)
     }
+    return
   }
 
   mutating func addAllAnnotatedGlobalInitOnceFunctions(of moduleContext: ModulePassContext) {

SwiftCompilerSources/Sources/SIL/Function.swift

@@ -137,6 +137,8 @@ final public class Function : CustomStringConvertible, HasShortDescription, Hash
   /// It's called from a `[global_init]` function via a `builtin "once"`.
   public var isGlobalInitOnceFunction: Bool { bridged.isGlobalInitOnceFunction() }
 
+  public var isGenericFunction: Bool { bridged.isGenericFunction() }
+
   /// Kinds of effect attributes which can be defined for a Swift function.
   public enum EffectAttribute {
     /// No effect attribute is specified.

include/swift/SIL/SILBridging.h

@@ -260,6 +260,10 @@ struct BridgedFunction {
     return getFunction()->isGlobalInitOnceFunction();
   }
 
+  bool isGenericFunction() const {
+    return getFunction()->getGenericSignature().isNull();
+  }
+
   bool hasSemanticsAttr(llvm::StringRef attrName) const {
     return getFunction()->hasSemanticsAttr(attrName);
   }