Frontend: Ignore -experimental-lazy-typecheck when verifying module interfaces.

Author: tshortli

lib/Frontend/ArgsToFrontendOptionsConverter.cpp

@@ -325,6 +325,12 @@ bool ArgsToFrontendOptionsConverter::convert(
   Opts.SkipNonExportableDecls |=
       Args.hasArg(OPT_experimental_skip_non_inlinable_function_bodies) &&
       Args.hasArg(OPT_experimental_skip_non_inlinable_function_bodies_is_lazy);
+  // HACK: The driver currently erroneously passes all flags to module interface
+  // verification jobs. -experimental-skip-non-exportable-decls is not
+  // appropriate for verification tasks and should be ignored, though.
+  if (Opts.RequestedAction ==
+      FrontendOptions::ActionType::TypecheckModuleFromInterface)
+    Opts.SkipNonExportableDecls = false;
 
   Opts.DebugPrefixSerializedDebuggingOptions |=
       Args.hasArg(OPT_prefix_serialized_debugging_options);

lib/Frontend/CompilerInvocation.cpp

@@ -1506,6 +1506,12 @@ static bool ParseTypeCheckerArgs(TypeCheckerOptions &Opts, ArgList &Args,
   Opts.EnableLazyTypecheck |=
       Args.hasArg(OPT_experimental_skip_non_inlinable_function_bodies) &&
       Args.hasArg(OPT_experimental_skip_non_inlinable_function_bodies_is_lazy);
+  // HACK: The driver currently erroneously passes all flags to module interface
+  // verification jobs. -experimental-skip-non-exportable-decls is not
+  // appropriate for verification tasks and should be ignored, though.
+  if (FrontendOpts.RequestedAction ==
+      FrontendOptions::ActionType::TypecheckModuleFromInterface)
+    Opts.EnableLazyTypecheck = false;
 
   return HadError;
 }

test/ModuleInterface/verify-module-interfaces-no-lazy-typecheck.swift

@@ -0,0 +1,12 @@
+// swift-interface-format-version: 1.0
+// swift-compiler-version: Swift version 5.11
+// swift-module-flags: -swift-version 5 -enable-library-evolution -module-name Test
+// expected-error @-3 {{failed to verify module interface of 'Test'}}
+import Swift
+public struct S {
+  @inlinable public func foo() {
+    doesNotExist() // expected-error {{cannot find 'doesNotExist' in scope}}
+  }
+}
+
+// RUN: %target-swift-typecheck-module-from-interface(%s) -module-name Test -verify -verify-ignore-unknown -experimental-lazy-typecheck