Remove Type.selfOrAnyFieldHasValueDeinit

It's not needed anymore

Author: eeckstein

SwiftCompilerSources/Sources/SIL/Type.swift

@@ -43,10 +43,6 @@ public struct Type : CustomStringConvertible, NoReflectionChildren {
     return bridged.isReferenceCounted(function.bridged)
   }
 
-  public func selfOrAnyFieldHasValueDeinit(in function: Function) -> Bool {
-    return bridged.selfOrAnyFieldHasValueDeinit(function.bridged)
-  }
-
   public var isUnownedStorageType: Bool {
     return bridged.isUnownedStorageType()
   }

include/swift/SIL/SILBridging.h

@@ -115,7 +115,6 @@ struct BridgedType {
   BRIDGED_INLINE bool isValueTypeWithDeinit() const;
   BRIDGED_INLINE bool isLoadable(BridgedFunction f) const;
   BRIDGED_INLINE bool isReferenceCounted(BridgedFunction f) const;
-  BRIDGED_INLINE bool selfOrAnyFieldHasValueDeinit(BridgedFunction f) const;
   BRIDGED_INLINE bool isUnownedStorageType() const;
   BRIDGED_INLINE bool hasArchetype() const;
   BRIDGED_INLINE bool isNominalOrBoundGenericNominal() const;

include/swift/SIL/SILBridgingImpl.h

@@ -88,12 +88,6 @@ bool BridgedType::isReferenceCounted(BridgedFunction f) const {
   return unbridged().isReferenceCounted(f.getFunction());
 }
 
-bool BridgedType::selfOrAnyFieldHasValueDeinit(BridgedFunction f) const {
-  swift::SILType contextType = unbridged().hasTypeParameter() ? f.getFunction()->mapTypeIntoContext(unbridged())
-                                                              : unbridged();
-  return f.getFunction()->getTypeLowering(contextType).selfOrAnyFieldHasValueDeinit();
-}
-
 bool BridgedType::isUnownedStorageType() const {
   return unbridged().isUnownedStorageType();
 }

include/swift/SIL/TypeLowering.h

@@ -192,11 +192,10 @@ class TypeLowering {
       InfiniteFlag               = 1 << 5,
       HasRawPointerFlag          = 1 << 6,
       LexicalFlag                = 1 << 7,
-      HasValueDeinitFlag         = 1 << 8,
     };
     // clang-format on
 
-    uint16_t Flags;
+    uint8_t Flags;
   public:
     /// Construct a default RecursiveProperties, which corresponds to
     /// a trivial, loadable, fixed-layout type.
@@ -273,9 +272,6 @@ class TypeLowering {
     IsLexical_t isLexical() const {
       return IsLexical_t((Flags & LexicalFlag) != 0);
     }
-    bool hasValueDeinit() const {
-      return (Flags & HasValueDeinitFlag) != 0;
-    }
 
     void setNonTrivial() { Flags |= NonTrivialFlag; }
     void setNonFixedABI() { Flags |= NonFixedABIFlag; }
@@ -289,7 +285,6 @@ class TypeLowering {
     void setLexical(IsLexical_t isLexical) {
       Flags = (Flags & ~LexicalFlag) | (isLexical ? LexicalFlag : 0);
     }
-    void setHasValueDeinit() { Flags |= HasValueDeinitFlag; }
   };
 
 private:
@@ -368,10 +363,6 @@ class TypeLowering {
     return Properties.isOrContainsRawPointer();
   }
 
-  bool selfOrAnyFieldHasValueDeinit() const {
-    return Properties.hasValueDeinit();
-  }
-
   /// Returns true if the type is a scalar reference-counted reference, which
   /// can be retained and released.
   bool isReferenceCounted() const {

lib/SIL/IR/TypeLowering.cpp

@@ -2369,9 +2369,6 @@ namespace {
         properties.setLexical(IsLexical);
         return handleMoveOnlyAddressOnly(structType, properties);
       }
-      if (D->getValueTypeDestructor()) {
-        properties.setHasValueDeinit();
-      }
 
       auto subMap = structType->getContextSubstitutionMap(&TC.M, D);
 
@@ -2454,9 +2451,6 @@ namespace {
         return new (TC) LoadableEnumTypeLowering(enumType, properties,
                                                  Expansion);
       }
-      if (D->getValueTypeDestructor()) {
-        properties.setHasValueDeinit();
-      }
 
       auto subMap = enumType->getContextSubstitutionMap(&TC.M, D);