improving tests readability

Author: dancamarotto

test/Constraints/casts.swift

@@ -744,13 +744,9 @@ do {
 
 // https://github.com/apple/swift/issues/68825
 do {
-  func x(a: Any) {
-    _ = a is a
-    // expected-error@-1 {{type-casting operator expects a type on its right-hand side (got: parameter 'a')}}
-    // expected-note@-3 {{'a' declared here}}
-    _ = a as a
-    // expected-error@-1 {{type-casting operator expects a type on its right-hand side (got: parameter 'a')}}
-    // expected-note@-6 {{'a' declared here}}
+  func x(a: Any) { // expected-note 2 {{'a' declared here}}
+    _ = a is a // expected-error {{type-casting operator expects a type on its right-hand side (got: parameter 'a')}}
+    _ = a as a // expected-error {{type-casting operator expects a type on its right-hand side (got: parameter 'a')}}
     _ = a is Issue68825 // expected-error {{cannot find type 'Issue68825' in scope}}
     _ = a is String // OK
   }

test/Parse/omit_return.swift

@@ -1709,9 +1709,8 @@ class CImplicitIdentityExpr { func gimme() -> CImplicitIdentityExpr { self } }
 
 class CImplicitDotSelfExpr { func gimme() -> CImplicitDotSelfExpr { self.self } }
 
-func badIs<T>(_ value: Any, anInstanceOf type: T.Type) -> Bool {
+func badIs<T>(_ value: Any, anInstanceOf type: T.Type) -> Bool { // expected-note {{'type' declared here}}
     value is type // expected-error {{type-casting operator expects a type on its right-hand side (got: parameter 'type')}}
-    // expected-note@-2 {{'type' declared here}}
 }
 
 

test/Parse/omit_return_fail.swift

@@ -1,18 +1,16 @@
 // RUN: %target-swift-frontend %s -typecheck -verify
 
-func badIs<T>(_ value: Any, anInstanceOf type: T.Type) -> Bool {
+func badIs<T>(_ value: Any, anInstanceOf type: T.Type) -> Bool { // expected-note {{'type' declared here}}
     value is type // expected-error {{type-casting operator expects a type on its right-hand side (got: parameter 'type')}}
-    // expected-note@-2 {{'type' declared here}}
 }
 
 func foo() -> Int {
     return // expected-error {{non-void function should return a value}}
 }
 
-func badIs_ifdecl<T>(_ value: Any, anInstanceOf type: T.Type) -> Bool {
+func badIs_ifdecl<T>(_ value: Any, anInstanceOf type: T.Type) -> Bool { // expected-note {{'type' declared here}}
     #if true
     value is type // expected-error {{type-casting operator expects a type on its right-hand side (got: parameter 'type')}}
-    // expected-note@-3 {{'type' declared here}}
     #endif
 }
 

test/Parse/omit_return_ifdecl.swift

@@ -2430,10 +2430,9 @@ class CImplicitIdentityExpr { func gimme() -> CImplicitIdentityExpr { self } }
 
 class CImplicitDotSelfExpr { func gimme() -> CImplicitDotSelfExpr { self.self } }
 
-func badIs<T>(_ value: Any, anInstanceOf type: T.Type) -> Bool {
+func badIs<T>(_ value: Any, anInstanceOf type: T.Type) -> Bool { // expected-note {{'type' declared here}}
     #if true
     value is type // expected-error {{type-casting operator expects a type on its right-hand side (got: parameter 'type')}}
-    // expected-note@-3 {{'type' declared here}}
     #endif
 }